From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#35264: "Match data clobbered by buffer modification hooks" when hooks only shifted match-data's markers Date: Wed, 12 May 2021 17:57:14 +0200 Message-ID: <87v97ogd2d.fsf@gnus.org> References: <87h8b119oy.fsf@gmail.com> <871s0f7det.fsf@gmail.com> <87a6x5z11g.fsf@gnus.org> <8735usj9z9.fsf@gnus.org> <83o8dg2e81.fsf@gnu.org> <87cztwhs9m.fsf@gnus.org> <83im3o2brt.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23494"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: npostavs@gmail.com, monnier@iro.umontreal.ca, 35264@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 12 18:06:26 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lgrNR-0005vy-Tv for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 May 2021 18:06:25 +0200 Original-Received: from localhost ([::1]:42442 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgrNQ-0002b3-TW for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 May 2021 12:06:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55494) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgrFK-0006em-0K for bug-gnu-emacs@gnu.org; Wed, 12 May 2021 11:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56809) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lgrFJ-0007Xb-OS for bug-gnu-emacs@gnu.org; Wed, 12 May 2021 11:58:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lgrFJ-0006F2-Nl for bug-gnu-emacs@gnu.org; Wed, 12 May 2021 11:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 May 2021 15:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35264 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35264-submit@debbugs.gnu.org id=B35264.162083504523937 (code B ref 35264); Wed, 12 May 2021 15:58:01 +0000 Original-Received: (at 35264) by debbugs.gnu.org; 12 May 2021 15:57:25 +0000 Original-Received: from localhost ([127.0.0.1]:40122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgrEj-0006E0-A7 for submit@debbugs.gnu.org; Wed, 12 May 2021 11:57:25 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:60154) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgrEi-0006Do-3p for 35264@debbugs.gnu.org; Wed, 12 May 2021 11:57:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=03q7tLAPOtyNabpURVT4RzeJEyDRaNfNQebQHn+c0KA=; b=rNi3WZIkTXTjuq7H9/8hL7oyDY qCFQkf2uWRkc+qDydQENvU0NS9iNPAgp5btMpV3v/fE/ccdVWvpAGTl5sh8qkLVW5WJzmBa2jysIC 1vJ9Uz2tOtTfu2+BA4F0vgsMBrOL5UN+DXaBgbYgT1IieKxRcmFhsFWxOZy/q55ITWIQ=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lgrEY-0006Om-Ud; Wed, 12 May 2021 17:57:17 +0200 X-Now-Playing: Tuxedomoon's _Live in Alberobello, Italy_: "Muchos Colores" In-Reply-To: <83im3o2brt.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 12 May 2021 18:48:54 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206345 Archived-At: Eli Zaretskii writes: >> I tried the code example in that bug report now (with the patch that >> removes the sanity check), and it did not crash Emacs. So that sanity >> check no longer seems to be necessary? > > Probably because some code somewhere uses save-match-data. I guess. But we have a case here where the sanity check is definitely wrong, and we don't have a reproducing case (any more) for the problem the check is trying to fix... which seems to indicate to me that we should apply the patch (i.e., remove the buggy sanity check). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no