unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Tassilo Horn <tsdh@gnu.org>
Cc: 50689@debbugs.gnu.org
Subject: bug#50689: 28.0.50; Wrong VC repo URL detection in bug-reference-mode
Date: Mon, 20 Sep 2021 14:53:32 +0100	[thread overview]
Message-ID: <87v92v9wv7.fsf@tcd.ie> (raw)
In-Reply-To: <87ee9jpvlz.fsf@gnu.org> (Tassilo Horn's message of "Mon, 20 Sep 2021 08:45:18 +0200")

close 50689 28.1
quit

Tassilo Horn [2021-09-20 08:45 +0200] wrote:

> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>> How's the attached fix?
>
> LGTM.

Thanks, pushed:

Fix VC repo URL detection in bug-reference-mode
7d5930a6f0 2021-09-20 14:41:13 +0100
https://git.sv.gnu.org/cgit/emacs.git/commit/?id=7d5930a6f0c7b44c00df403d5fe8a3f40e51902f

> Not sure about when-let/seq-fns.  I refrained from using them in
> bug-reference.el so that it doesn't require subr-x.el and seq.el.

when-let is an autoloaded macro, so subr-x.el won't be loaded at all at
runtime (assuming everything is byte-compiled).

seq-some is an autoloaded function, so seq.el won't be loaded until
bug-reference-try-setup-from-vc is invoked (and anyway in practice it is
hard to do anything in Emacs any more without seq.el being loaded at
some point).

> But OTHO, I very much like them and would happily use them once they
> are loaded anyway.

I'm therefore closing this report.

Thanks,

-- 
Basil





  reply	other threads:[~2021-09-20 13:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-19 23:43 bug#50689: 28.0.50; Wrong VC repo URL detection in bug-reference-mode Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-20  6:45 ` Tassilo Horn
2021-09-20 13:53   ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-09-20 13:57     ` Tassilo Horn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v92v9wv7.fsf@tcd.ie \
    --to=bug-gnu-emacs@gnu.org \
    --cc=50689@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    --cc=tsdh@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).