From: Tassilo Horn <tsdh@gnu.org>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 50689@debbugs.gnu.org
Subject: bug#50689: 28.0.50; Wrong VC repo URL detection in bug-reference-mode
Date: Mon, 20 Sep 2021 08:45:18 +0200 [thread overview]
Message-ID: <87ee9jpvlz.fsf@gnu.org> (raw)
In-Reply-To: <877dfcb08k.fsf@tcd.ie>
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
Hey Basil,
> Tags: patch
>
> In a clone of https://github.com/abo-abo/swiper.git, with the following
> remotes:
>
> $ git remote -v
> elpa savannah:/srv/git/emacs/elpa.git (fetch)
> elpa savannah:/srv/git/emacs/elpa.git (push)
> origin git@github.com:basil-conto/swiper.git (fetch)
> origin git@github.com:basil-conto/swiper.git (push)
> upstream git@github.com:abo-abo/swiper.git (fetch)
> upstream git@github.com:abo-abo/swiper.git (push)
>
> 0. emacs -Q ivy.el
> 1. M-: (vc-call-backend 'Git 'repository-url "upstream") RET
>
> This returns: "git@github.com:basil-conto/swiper.git"
> instead of: "git@github.com:abo-abo/swiper.git"
>
> Step 1 is effectively what bug-reference-try-setup-from-vc does, and I
> believe the incorrect result is due to vc-git-repository-url expecting
> a file name, not a Git remote name, as its first argument.
Oh, good catch!
BTW, I've thought I've checked that previously <fork>/issues/X
redirected you to <originalrepo>/issues/X but that doesn't seem to be
the case right anymore...
> How's the attached fix?
LGTM. Not sure about when-let/seq-fns. I refrained from using them in
bug-reference.el so that it doesn't require subr-x.el and seq.el. But
OTHO, I very much like them and would happily use them once they are
loaded anyway.
Bye,
Tassilo
next prev parent reply other threads:[~2021-09-20 6:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-19 23:43 bug#50689: 28.0.50; Wrong VC repo URL detection in bug-reference-mode Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-20 6:45 ` Tassilo Horn [this message]
2021-09-20 13:53 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-20 13:57 ` Tassilo Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee9jpvlz.fsf@gnu.org \
--to=tsdh@gnu.org \
--cc=50689@debbugs.gnu.org \
--cc=contovob@tcd.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).