From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#50689: 28.0.50; Wrong VC repo URL detection in bug-reference-mode Date: Mon, 20 Sep 2021 14:53:32 +0100 Message-ID: <87v92v9wv7.fsf@tcd.ie> References: <877dfcb08k.fsf@tcd.ie> <87ee9jpvlz.fsf@gnu.org> Reply-To: "Basil L. Contovounesios" Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17395"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 50689@debbugs.gnu.org To: Tassilo Horn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 20 15:54:54 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSJkz-0004Jy-GM for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Sep 2021 15:54:53 +0200 Original-Received: from localhost ([::1]:48824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSJkx-0000b3-JC for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Sep 2021 09:54:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59266) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSJkA-0008E8-Up for bug-gnu-emacs@gnu.org; Mon, 20 Sep 2021 09:54:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57963) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mSJkA-0000VD-Mr for bug-gnu-emacs@gnu.org; Mon, 20 Sep 2021 09:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mSJkA-0000H0-Dx for bug-gnu-emacs@gnu.org; Mon, 20 Sep 2021 09:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Sep 2021 13:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50689 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50689-submit@debbugs.gnu.org id=B50689.16321460271024 (code B ref 50689); Mon, 20 Sep 2021 13:54:02 +0000 Original-Received: (at 50689) by debbugs.gnu.org; 20 Sep 2021 13:53:47 +0000 Original-Received: from localhost ([127.0.0.1]:41276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSJju-0000GS-UT for submit@debbugs.gnu.org; Mon, 20 Sep 2021 09:53:47 -0400 Original-Received: from mail-wr1-f50.google.com ([209.85.221.50]:44908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSJjo-0000Fr-Ln for 50689@debbugs.gnu.org; Mon, 20 Sep 2021 09:53:44 -0400 Original-Received: by mail-wr1-f50.google.com with SMTP id d6so29821164wrc.11 for <50689@debbugs.gnu.org>; Mon, 20 Sep 2021 06:53:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=tnxd8R78bDQHnvr64Xiv/U+PmlDfH76adAh1S02hl5U=; b=YJpqByjzx/8z8dOXNpT1nj4DEoYL+CO1sADPqmRLcF3enzKSD5tTltzgtIa7worpnn hWPRD9ggnQ/0sh19GhJjPbFKxy4DwEF9lcmN6hScyS1kyhtzd/oq3wGcFcupCA9C9g0b rDplIbfN37NPozvk+sUIMY6Mf2aVht6AnBfpaIl60460EPt/yfYSy8hNXshPMmWfqLz3 JIDZbru7qFZlMf7NK4zer+b1THY6hHy4ROSz0DEAVQ10f7rl774gnxVyN6kHE7orfp33 w2loEOCgBAmh5UGVi39mrFKqNeijJMKJkZr1k/FgNj7bGZ7GSTPu2V2ycS/CL+4vk5B3 gPow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=tnxd8R78bDQHnvr64Xiv/U+PmlDfH76adAh1S02hl5U=; b=VfkVy3CRJAfN5cRn+3b4+Fy7B/FRDtI1QUJY789yR82SlRNXgfkFxDbRMm6WdXwUKC tuWttMwRCEuRhNnJlSFghr4+mOq4jF2M/ntEkAA7mePuWN46NJR/htaNTuCtPTUNWk6D Vhx5PsagZH2leHb+WsjQ5XCuimwvv/0Gh64RU7l0n5iqH9+TR9reqjcMGFSAJebgZLLH XYUSdemlp37iik9duloXKnAe0U9yHIdZREEOoZbQSIvl3ojDlAuC3NnVK2+ZkAVBKCes +EwzxJ+UY3gtECmiNNc2c3MlGt2Y9IpnEFj4ifiVoamUiYf7SQmBK94iM9PKFxYqH6ge h7hQ== X-Gm-Message-State: AOAM533upRhPn8rkEjqQm5ZB13dwAvp9s1j1iRzm3QreREtI08f0YITN mX6DY0B8TNPcHqScnx3hXmIxjg== X-Google-Smtp-Source: ABdhPJw03pIZvzXrvS/pL910vv2ru4y6wK2smGPwsipSmTPJlUvvVFYUS8H6uzijf4oEzf6lXSK2Pw== X-Received: by 2002:a05:6000:1a52:: with SMTP id t18mr28094410wry.21.1632146014569; Mon, 20 Sep 2021 06:53:34 -0700 (PDT) Original-Received: from localhost ([86.43.127.200]) by smtp.gmail.com with ESMTPSA id a77sm4229759wme.28.2021.09.20.06.53.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Sep 2021 06:53:34 -0700 (PDT) In-Reply-To: <87ee9jpvlz.fsf@gnu.org> (Tassilo Horn's message of "Mon, 20 Sep 2021 08:45:18 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214862 Archived-At: close 50689 28.1 quit Tassilo Horn [2021-09-20 08:45 +0200] wrote: > "Basil L. Contovounesios" writes: >> How's the attached fix? > > LGTM. Thanks, pushed: Fix VC repo URL detection in bug-reference-mode 7d5930a6f0 2021-09-20 14:41:13 +0100 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=7d5930a6f0c7b44c00df403d5fe8a3f40e51902f > Not sure about when-let/seq-fns. I refrained from using them in > bug-reference.el so that it doesn't require subr-x.el and seq.el. when-let is an autoloaded macro, so subr-x.el won't be loaded at all at runtime (assuming everything is byte-compiled). seq-some is an autoloaded function, so seq.el won't be loaded until bug-reference-try-setup-from-vc is invoked (and anyway in practice it is hard to do anything in Emacs any more without seq.el being loaded at some point). > But OTHO, I very much like them and would happily use them once they > are loaded anyway. I'm therefore closing this report. Thanks, -- Basil