unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Protesilaos Stavrou <info@protesilaos.com>
To: Visuwesh <visuweshm@gmail.com>
Cc: 65039@debbugs.gnu.org
Subject: bug#65039: 30.0.50; [PATCH] Add bookmark handler for M-x shell
Date: Fri, 04 Aug 2023 12:20:37 +0300	[thread overview]
Message-ID: <87v8dv2mfu.fsf@protesilaos.com> (raw)
In-Reply-To: <87fs50835j.fsf@gmail.com>

> From: Visuwesh <visuweshm@gmail.com>
> Date: Thu,  3 Aug 2023 22:38:24 +0530
>
> [வியாழன் ஆகஸ்ட் 03, 2023] Protesilaos Stavrou wrote:
>
>> Dear maintainers,
>>
>> I noticed that M-x shell does not have a bookmark handler like M-x
>> eshell does.  What do you think about the attached patch?
>
> I think it would be nice to also store the "Remote shell path" for
> remote TRAMP buffers.  I have no idea how to retrieve this value,
> however.
> [ When I visit a TRAMP ssh buffer and say M-x shell, it asks for the
>   remote shell path.  ]

The code is adapted from Eshell, which has the capability you describe.
I do not have the means to test an SSH connection.  Though I tried the
'sudo' TRAMP method and the bookmarking correctly logs me in as root
when I do 'bookmark-jump'.  This works even if I kill the shell buffer
and all TRAMP buffers.

-- 
Protesilaos Stavrou
https://protesilaos.com





  reply	other threads:[~2023-08-04  9:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-03 14:41 bug#65039: 30.0.50; [PATCH] Add bookmark handler for M-x shell Protesilaos Stavrou
2023-08-03 15:56 ` Eli Zaretskii
2023-08-04  9:17   ` Protesilaos Stavrou
2023-08-04 10:32     ` Eli Zaretskii
2023-08-04 14:06       ` Protesilaos Stavrou
2023-08-05  9:18         ` Eli Zaretskii
2023-09-03 11:15           ` Stefan Kangas
2023-09-03 11:42             ` Eli Zaretskii
2023-09-05  4:39             ` Protesilaos Stavrou
2023-09-05  6:17               ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-18  5:28                 ` Protesilaos Stavrou
2023-08-04 14:35       ` Drew Adams
2023-08-03 17:08 ` Visuwesh
2023-08-04  9:20   ` Protesilaos Stavrou [this message]
2023-08-04 13:01     ` Visuwesh
2023-08-04 14:13       ` Protesilaos Stavrou
2023-08-04 14:35         ` Visuwesh
2023-08-11  4:55           ` Protesilaos Stavrou
2023-08-04 17:01     ` Jim Porter
2023-08-06  4:43       ` Protesilaos Stavrou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8dv2mfu.fsf@protesilaos.com \
    --to=info@protesilaos.com \
    --cc=65039@debbugs.gnu.org \
    --cc=visuweshm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).