From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#65039: 30.0.50; [PATCH] Add bookmark handler for M-x shell Date: Fri, 04 Aug 2023 12:20:37 +0300 Message-ID: <87v8dv2mfu.fsf@protesilaos.com> References: <877cqcw5m0.fsf@protesilaos.com> <87fs50835j.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22181"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65039@debbugs.gnu.org To: Visuwesh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 04 11:21:50 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qRr0I-0005ZI-9c for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Aug 2023 11:21:50 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qRqzY-00018c-KD; Fri, 04 Aug 2023 05:21:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRqzW-00018A-GN for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 05:21:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qRqzW-00022T-7u for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 05:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qRqzW-0003cS-1a for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 05:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Aug 2023 09:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65039 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65039-submit@debbugs.gnu.org id=B65039.169114084713884 (code B ref 65039); Fri, 04 Aug 2023 09:21:02 +0000 Original-Received: (at 65039) by debbugs.gnu.org; 4 Aug 2023 09:20:47 +0000 Original-Received: from localhost ([127.0.0.1]:53421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRqzG-0003bs-S2 for submit@debbugs.gnu.org; Fri, 04 Aug 2023 05:20:47 -0400 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:38535) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRqzF-0003bf-Ar for 65039@debbugs.gnu.org; Fri, 04 Aug 2023 05:20:45 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 8C4F040009; Fri, 4 Aug 2023 09:20:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protesilaos.com; s=gm1; t=1691140839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BCzXAJO72yWc+JjytvC2xbk9BlajYk11kcKMmuLmvA8=; b=Af7o42hl56ualSgDJoR/qMk3wLStBtiAQv2BB0NjJOmjyXV0iL+EGf12KG0A0GpwYuv+PZ k5f1gGwTCKqwE3ImGhRWhMPYMtqL5da6X8L23xaFyZEKRCp59H8UihPfWWGBK5FwKsRjso b2/IqeKalq15hTrX9G6fWjQKtsY74Sdx39ZXDStGM44XEW9tS/bmnWSbF0tuYxwdbOdiDM GQWGT/lJEfol+Kd8xuOVvX1Hl7ekAEm1rJMlyJ8TcDs2Ko2NBZwUuWCev2KeyFlf/0fk4d 3rImMMJBmLaZnvMis3uQP9rqHcQz/lS1dG/FuDYLq3AnO0XDKXAS+/ihUJFtHA== In-Reply-To: <87fs50835j.fsf@gmail.com> X-GND-Sasl: public@protesilaos.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266656 Archived-At: > From: Visuwesh > Date: Thu, 3 Aug 2023 22:38:24 +0530 > > [=E0=AE=B5=E0=AE=BF=E0=AE=AF=E0=AE=BE=E0=AE=B4=E0=AE=A9=E0=AF=8D =E0=AE= =86=E0=AE=95=E0=AE=B8=E0=AF=8D=E0=AE=9F=E0=AF=8D 03, 2023] Protesilaos Stav= rou wrote: > >> Dear maintainers, >> >> I noticed that M-x shell does not have a bookmark handler like M-x >> eshell does. What do you think about the attached patch? > > I think it would be nice to also store the "Remote shell path" for > remote TRAMP buffers. I have no idea how to retrieve this value, > however. > [ When I visit a TRAMP ssh buffer and say M-x shell, it asks for the > remote shell path. ] The code is adapted from Eshell, which has the capability you describe. I do not have the means to test an SSH connection. Though I tried the 'sudo' TRAMP method and the bookmarking correctly logs me in as root when I do 'bookmark-jump'. This works even if I kill the shell buffer and all TRAMP buffers. --=20 Protesilaos Stavrou https://protesilaos.com