From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: info@protesilaos.com, 65039@debbugs.gnu.org
Subject: bug#65039: 30.0.50; [PATCH] Add bookmark handler for M-x shell
Date: Sun, 03 Sep 2023 14:42:23 +0300 [thread overview]
Message-ID: <83r0nf7aao.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmmnpedGpgkFY3XeDUkindUS9D9vBzTMaZYypyf6UCQ1hg@mail.gmail.com> (message from Stefan Kangas on Sun, 3 Sep 2023 04:15:57 -0700)
> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Sun, 3 Sep 2023 04:15:57 -0700
> Cc: Protesilaos Stavrou <info@protesilaos.com>, 65039@debbugs.gnu.org
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> The revised patch includes a possible update to the manual. Are those
> >> examples sufficient?
> >
> > I guess so, thanks.
>
> Just to let you know, I had an issue with applying the patch, and had to
> manually edit it:
>
> 1 git … am --3way -- ~/wip/emacs/0001-Add-bookmark-handler-for-M-x-shell.patch
> Line longer than 78 characters in commit message
> Commit aborted; please see the file CONTRIBUTE
>
> Also, when the bug number is known, it is good if you can include it
> somewhere in the commit message.
>
> I was going to review and install this patch, but I noticed that there
> was some further discussion in a subthread regarding some Tramp stuff?
> Should that be resolved first, or is this ready as-is?
Yes, I think those issues need to be resolved first. I only reviewed
part of the patch.
next prev parent reply other threads:[~2023-09-03 11:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 14:41 bug#65039: 30.0.50; [PATCH] Add bookmark handler for M-x shell Protesilaos Stavrou
2023-08-03 15:56 ` Eli Zaretskii
2023-08-04 9:17 ` Protesilaos Stavrou
2023-08-04 10:32 ` Eli Zaretskii
2023-08-04 14:06 ` Protesilaos Stavrou
2023-08-05 9:18 ` Eli Zaretskii
2023-09-03 11:15 ` Stefan Kangas
2023-09-03 11:42 ` Eli Zaretskii [this message]
2023-09-05 4:39 ` Protesilaos Stavrou
2023-09-05 6:17 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-18 5:28 ` Protesilaos Stavrou
2023-08-04 14:35 ` Drew Adams
2023-08-03 17:08 ` Visuwesh
2023-08-04 9:20 ` Protesilaos Stavrou
2023-08-04 13:01 ` Visuwesh
2023-08-04 14:13 ` Protesilaos Stavrou
2023-08-04 14:35 ` Visuwesh
2023-08-11 4:55 ` Protesilaos Stavrou
2023-08-04 17:01 ` Jim Porter
2023-08-06 4:43 ` Protesilaos Stavrou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r0nf7aao.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=65039@debbugs.gnu.org \
--cc=info@protesilaos.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).