bug#14975: 24.3; org-mode's `org-clock-notify-once-if-expired' doesn't respect `org-clock-sound'

bug#14975: 24.3; org-mode's `org-clock-notify-once-if-expired' doesn't respect `org-clock-sound'

[Oleh]

[-- Attachment #1: Type: text/plain, Size: 137 bytes --]

Currently, this function behaves unconditionally
as if `org-clock-sound' was set to t.

I attach a patch of how I fixed it for my needs:

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 847 bytes --]

From db2cc63bbdd4e51bd7a150186b131a39d7d10a6e Mon Sep 17 00:00:00 2001
From: oleh <wave@mail.ua>
Date: Sun, 28 Jul 2013 15:39:57 +0200
Subject: [PATCH] org-clock.el: `org-clock-notify-once-if-expired' respects
 `org-clock-sound'.

---
 lisp/org-clock.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index 8ac215e..99479b2 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -718,7 +718,7 @@ Notification is shown only once."
 	    (setq org-clock-notification-was-shown t)
 	    (org-notify
 	     (format "Task '%s' should be finished by now. (%s)"
-		     org-clock-heading org-clock-effort) t))
+		     org-clock-heading org-clock-effort) org-clock-sound))
 	(setq org-clock-notification-was-shown nil)))))
 
 (defun org-notify (notification &optional play-sound)
-- 
1.8.1.2


[-- Attachment #3: Type: text/plain, Size: 18 bytes --]


regards,
Oleh

bug#14975: 24.3; org-mode's `org-clock-notify-once-if-expired' doesn't respect `org-clock-sound'

[Bastien]

Hi Oleh,

Oleh <o.krehel@tue.nl> writes:

> Currently, this function behaves unconditionally
> as if `org-clock-sound' was set to t.
>
> I attach a patch of how I fixed it for my needs:

Please send those patches to the org-mode list first.

I applied it but added a ChangeLog entry in the commit message
and the TINYCHANGE change cookie that helps us track small changes
by contributors who did not assign their copyright to the FSF (yet).

Thanks for catching this,

-- 
 Bastien

bug#14975: 24.3; org-mode's `org-clock-notify-once-if-expired' doesn't respect `org-clock-sound'

[Bastien]

Bastien <bzg@altern.org> writes:

> Please send those patches to the org-mode list first.

PS: Maybe it's just me and I did not see the initial bug
report on this list -- ignore the heads up if that's so!

-- 
 Bastien

bug#14975: 24.3; org-mode's `org-clock-notify-once-if-expired' doesn't respect `org-clock-sound'

[Glenn Morris]

Bastien wrote:

>> Please send those patches to the org-mode list first.
>
> PS: Maybe it's just me and I did not see the initial bug
> report on this list -- ignore the heads up if that's so!

If by "this list" you mean the org-mode list:
It was initially reported to bug-gnu-emacs. Then I assigned it to the
"emacs,org-mode" package, so that subsequent emails went to the org-mode
list as well as the bug-gnu-emacs list. This would have happened with
the initial report if it had specified a "Package: emacs,org-mode" line.
(Though there seems no point in having "emacs" in there really.)

bug#14975: 24.3; org-mode's `org-clock-notify-once-if-expired' doesn't respect `org-clock-sound'

[Bastien]

Hi Glenn,

Glenn Morris <rgm@gnu.org> writes:

>>> Please send those patches to the org-mode list first.
>>
>> PS: Maybe it's just me and I did not see the initial bug
>> report on this list -- ignore the heads up if that's so!
>
> If by "this list" you mean the org-mode list:
> It was initially reported to bug-gnu-emacs. Then I assigned it to the
> "emacs,org-mode" package, so that subsequent emails went to the org-mode
> list as well as the bug-gnu-emacs list. This would have happened with
> the initial report if it had specified a "Package: emacs,org-mode" line.
> (Though there seems no point in having "emacs" in there really.)

Thanks for the explanations.

This is what I expected, but I don't find the bug in the org-mode
mailing list.  The only reference I can find is my reply:
http://lists.gnu.org/archive/html/emacs-orgmode/2013-07/msg01094.html

Does anyone receive this bug on the first place?  Or someone can
browse the archives better than me?

-- 
 Bastien

bug#14975: 24.3; org-mode's `org-clock-notify-once-if-expired' doesn't respect `org-clock-sound'

[Glenn Morris]

Bastien wrote:

>> It was initially reported to bug-gnu-emacs. Then I assigned it to the
>> "emacs,org-mode" package, so that subsequent emails went to the org-mode
>> list as well as the bug-gnu-emacs list. This would have happened with
>> the initial report if it had specified a "Package: emacs,org-mode" line.
>> (Though there seems no point in having "emacs" in there really.)
>
> Thanks for the explanations.
>
> This is what I expected, but I don't find the bug in the org-mode
> mailing list.

That's what I'm saying. It was sent to bug-gnu-emacs ONLY. Because that
list is coupled to debbugs.gnu.org, and because I reassigned the bug
after it was received, subsequent replies went to both lists. But the
initial report is only on bug-gnu-emacs.

bug#14975: 24.3; org-mode's `org-clock-notify-once-if-expired' doesn't respect `org-clock-sound'

[Stefan Monnier]

> That's what I'm saying. It was sent to bug-gnu-emacs ONLY. Because that
> list is coupled to debbugs.gnu.org, and because I reassigned the bug
> after it was received, subsequent replies went to both lists. But the
> initial report is only on bug-gnu-emacs.

It would be nice if some message were sent to org-mode's list when
`org-mode' is added to the "Package:" list.


        Stefan "applicable to other packages than org-mode, obviously"

bug#14975: 24.3; org-mode's `org-clock-notify-once-if-expired' doesn't respect `org-clock-sound'

[Bastien]

Glenn Morris <rgm@gnu.org> writes:

> That's what I'm saying. It was sent to bug-gnu-emacs ONLY. Because that
> list is coupled to debbugs.gnu.org, and because I reassigned the bug
> after it was received, subsequent replies went to both lists. But the
> initial report is only on bug-gnu-emacs.

Got it now, thanks!

-- 
 Bastien, who agrees with Stefan's suggestion on this