From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Oleh Newsgroups: gmane.emacs.bugs Subject: bug#14975: 24.3; org-mode's `org-clock-notify-once-if-expired' doesn't respect `org-clock-sound' Date: Sun, 28 Jul 2013 15:49:00 +0200 Message-ID: <87a9l67q2b.fsf@tue.nl> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1375019423 24820 80.91.229.3 (28 Jul 2013 13:50:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 28 Jul 2013 13:50:23 +0000 (UTC) To: 14975@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 28 15:50:24 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1V3RMX-0001cN-SN for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Jul 2013 15:50:18 +0200 Original-Received: from localhost ([::1]:39795 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3RMX-0008Na-F0 for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Jul 2013 09:50:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40728) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3RMO-0008NU-Fi for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2013 09:50:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3RMI-00062Q-Gz for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2013 09:50:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59900) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3RMI-00062B-EL for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2013 09:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1V3RMI-0003DR-0E for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2013 09:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Oleh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jul 2013 13:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 14975 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.137501937212261 (code B ref -1); Sun, 28 Jul 2013 13:50:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 28 Jul 2013 13:49:32 +0000 Original-Received: from localhost ([127.0.0.1]:54216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3RLn-0003Bh-Pk for submit@debbugs.gnu.org; Sun, 28 Jul 2013 09:49:32 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38924) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3RLk-0003BG-BB for submit@debbugs.gnu.org; Sun, 28 Jul 2013 09:49:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3RLY-0005Rg-TG for submit@debbugs.gnu.org; Sun, 28 Jul 2013 09:49:22 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:39077) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3RLY-0005Rc-Pg for submit@debbugs.gnu.org; Sun, 28 Jul 2013 09:49:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40620) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3RLT-00080v-NC for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2013 09:49:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3RLL-0005LA-Dc for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2013 09:49:11 -0400 Original-Received: from mail-wi0-x232.google.com ([2a00:1450:400c:c05::232]:38427) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3RLL-0005K3-57 for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2013 09:49:03 -0400 Original-Received: by mail-wi0-f178.google.com with SMTP id j17so1661268wiw.11 for ; Sun, 28 Jul 2013 06:49:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:mime-version:content-type; bh=Mv8SE7cl/2UEoqiczt2nk/d0XitFRJgKzLA15nkz3Fs=; b=V87aM1xlz5YJE4mL+r21inQSml/+PN0b+jMR33RyL/IKgeszGAPPRg6GJglD6RIdCk ec+NmcrAcB3iKVHWcm3QVoVpSH+PgeThXassGAf7avvs61rPYQ9Bl+iYpa3DEzB0KHIL 3y1OUcip7ktF4dZVm/7ZJGMAPbf/KCtVpmHGlJZt/8mmge1oU2t9oJXrydbmfuymDC+9 cStH3Zr9TWxwlX+JlmGBNWwTtC+Ypocb9IraS66KVQqgm3uZec/ev1SczfNunY4bO+Uh jvCoC7T3QjmrR7JhFGeRGSWp7X9MSatNOl1yI/dyqSY/iMAaH1vZltrmB6q8d4dvObxe qdEQ== X-Received: by 10.180.208.104 with SMTP id md8mr4249263wic.57.1375019342152; Sun, 28 Jul 2013 06:49:02 -0700 (PDT) Original-Received: from firefly (dyn068175.nbw.tue.nl. [131.155.68.175]) by mx.google.com with ESMTPSA id i1sm16375072wiz.6.2013.07.28.06.49.00 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 28 Jul 2013 06:49:01 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:76725 Archived-At: --=-=-= Content-Type: text/plain Currently, this function behaves unconditionally as if `org-clock-sound' was set to t. I attach a patch of how I fixed it for my needs: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-org-clock.el-org-clock-notify-once-if-expired-respec.patch Content-Description: patch >From db2cc63bbdd4e51bd7a150186b131a39d7d10a6e Mon Sep 17 00:00:00 2001 From: oleh Date: Sun, 28 Jul 2013 15:39:57 +0200 Subject: [PATCH] org-clock.el: `org-clock-notify-once-if-expired' respects `org-clock-sound'. --- lisp/org-clock.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org-clock.el b/lisp/org-clock.el index 8ac215e..99479b2 100644 --- a/lisp/org-clock.el +++ b/lisp/org-clock.el @@ -718,7 +718,7 @@ Notification is shown only once." (setq org-clock-notification-was-shown t) (org-notify (format "Task '%s' should be finished by now. (%s)" - org-clock-heading org-clock-effort) t)) + org-clock-heading org-clock-effort) org-clock-sound)) (setq org-clock-notification-was-shown nil))))) (defun org-notify (notification &optional play-sound) -- 1.8.1.2 --=-=-= Content-Type: text/plain regards, Oleh --=-=-=--