From: John Shahid <jvshahid@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 31325-done@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#31325: 27.0.50; PROPOSAL: introduce a new function to recenter without redisplaying the frame
Date: Sun, 01 Jul 2018 16:54:53 +0000 [thread overview]
Message-ID: <87tvpiyjz6.fsf@gmail.com> (raw)
In-Reply-To: <83in5zkjsk.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
>> From: John Shahid <jvshahid@gmail.com>
>> Cc: Eli Zaretskii <eliz@gnu.org>, 31325@debbugs.gnu.org, monnier@iro.umontreal.ca
>> Date: Sun, 01 Jul 2018 13:17:17 +0000
>>
>> Fixed in the attached patch.
>
> Thanks, pushed to the master branch.
>
> Please in the future mention the bug number in the log message, and
> also grep the sources for callers of the functions you change. (In
> this case, there was one caller in w32console.c, and it wouldn't
> compile after the change, because the number of arguments changed.)
Thanks Eli. Sorry about that, I will try to be more careful in the
future.
It just occurred to me that this change will break backward
comparability for those who bind some key to the `recenter' command,
since now the second argument will always be nil and thus won't
redisplay. Should we also change the interactive form of recenter to
use "p" for the second argument? That way the second arg is never nil
when used interactively.
next prev parent reply other threads:[~2018-07-01 16:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 0:48 bug#31325: 27.0.50; PROPOSAL: introduce a new function to recenter without redisplaying the frame John Shahid
2018-05-08 1:37 ` Stefan Monnier
2018-06-28 13:27 ` John Shahid
2018-06-30 9:45 ` Eli Zaretskii
2018-06-30 20:20 ` John Shahid
2018-07-01 9:05 ` martin rudalics
2018-07-01 13:17 ` John Shahid
2018-07-01 16:22 ` Eli Zaretskii
2018-07-01 16:54 ` John Shahid [this message]
2018-07-01 17:03 ` Eli Zaretskii
2018-07-01 17:14 ` Eli Zaretskii
2018-07-01 17:25 ` John Shahid
2018-07-01 20:17 ` Drew Adams
2018-07-01 20:56 ` John Shahid
2018-07-01 23:04 ` Drew Adams
2018-07-02 2:27 ` John Shahid
2018-07-02 15:18 ` Eli Zaretskii
2018-07-01 17:18 ` John Shahid
2018-07-01 18:05 ` Eli Zaretskii
2018-07-01 18:58 ` John Shahid
2018-07-02 15:22 ` Eli Zaretskii
2018-07-02 20:38 ` John Shahid
2018-07-03 8:49 ` Robert Pluim
2018-07-03 16:38 ` John Shahid
2018-07-07 9:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvpiyjz6.fsf@gmail.com \
--to=jvshahid@gmail.com \
--cc=31325-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).