From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: John Shahid Newsgroups: gmane.emacs.bugs Subject: bug#31325: 27.0.50; PROPOSAL: introduce a new function to recenter without redisplaying the frame Date: Sun, 01 Jul 2018 16:54:53 +0000 Message-ID: <87tvpiyjz6.fsf@gmail.com> References: <87po2gkxpi.fsf@gmail.com> <87sh57yrax.fsf@gmail.com> <83lgawmwup.fsf@gnu.org> <878t6wxbzr.fsf@gmail.com> <5B38994B.2010605@gmx.at> <87va9zxfhe.fsf@gmail.com> <83in5zkjsk.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1530464048 11218 195.159.176.226 (1 Jul 2018 16:54:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 1 Jul 2018 16:54:08 +0000 (UTC) User-Agent: mu4e 1.1.0; emacs 27.0.50 Cc: 31325-done@debbugs.gnu.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 01 18:54:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fZfbv-0002o5-Dz for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Jul 2018 18:54:03 +0200 Original-Received: from localhost ([::1]:55007 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZfe2-0004uH-BQ for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Jul 2018 12:56:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49375) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZfdt-0004tz-Eq for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2018 12:56:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fZfdq-0005v3-C4 for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2018 12:56:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34393) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fZfdq-0005uh-8F for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2018 12:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fZfdp-0000Nm-U2 for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2018 12:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: John Shahid Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Jul 2018 16:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31325 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31325-done@debbugs.gnu.org id=D31325.15304641101410 (code D ref 31325); Sun, 01 Jul 2018 16:56:01 +0000 Original-Received: (at 31325-done) by debbugs.gnu.org; 1 Jul 2018 16:55:10 +0000 Original-Received: from localhost ([127.0.0.1]:42290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fZfcz-0000Mf-Pp for submit@debbugs.gnu.org; Sun, 01 Jul 2018 12:55:09 -0400 Original-Received: from mail-qt0-f180.google.com ([209.85.216.180]:44663) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fZfcx-0000MS-Sn for 31325-done@debbugs.gnu.org; Sun, 01 Jul 2018 12:55:08 -0400 Original-Received: by mail-qt0-f180.google.com with SMTP id b15-v6so2096557qtp.11 for <31325-done@debbugs.gnu.org>; Sun, 01 Jul 2018 09:55:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=12v6ykjOSMiKwzgtAsEJjqRbNDkm4Bv9K9VZcNpMprw=; b=EjSG031tNKt8kE3mlpIOKl2m/eQ+wEjxfObfT+YFub0dJ5G2+i77n4nPh6uFnfdOGB aA+s8jizvg8Sg/2e6xDPNPJwEr0+0MA6vBvvca3i3f+98jSzsOvzk8jV8LylCS6Hr/cd SiPodO8pGbPB77VZm5X0ILaeg4/xpY4WF7NGltYi5SSvGfbIdGqqwIjc4bQ7tVoBMskT LrW3J7ZCR7sXtoQ19gM3pbtMPnlHl5dpFmhyybXxYErosWj+hpumO+yX4F19LyhKbO3O GRPYmVFSLNEyEVAcOo7cKognraY2poImzflxUChyUnGgz8eKIyQa8m5+UUjQRPj/kKw5 uwyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=12v6ykjOSMiKwzgtAsEJjqRbNDkm4Bv9K9VZcNpMprw=; b=K+AH7jHQZePRtp/qZaOLSMlp1+GN09TKACTLvyYsGcbadNYKpac/SPkBmyQzqZAQ7m fxAu3kHN67+Oeo0p1TO9jRIHbx/DHVmZLVE0U4UR6BlxzEs9Hozw8wmDIj402ttYafz0 ZFRPnQVuGluToU31/N3AeOUnwxzSpyrswDv8mT17NDAnlFaPA18sXCvEHxdosMqAGLBf EnyJ7pig4yzF4o87dqXbIQGTQj7C5PVqO+wWewHJkjZMK91BfA/n9lDjY66mobNh0Ixk VXdPBzGYzw0cv/y3ZHIPzoezgY/HmlpeDOEjcrDd0V6ASaHTtow3Ap1/mn/cQSbEaj8q 4Z6Q== X-Gm-Message-State: APt69E37TWmw24VKbF1+9UrP/j7N71ufm7fi0TSPl3yW1Mgjcagfcgos QgsD/Mp96nZGK1zH+19qk80= X-Google-Smtp-Source: AAOMgpdrfF6fOv21QskwwnGnT96Xl1dfrtGvLgijRku5bZ5uw9cjXJXXmpkkTV7CRwqpI8PLnegsUw== X-Received: by 2002:a0c:8283:: with SMTP id i3-v6mr20030200qva.21.1530464101998; Sun, 01 Jul 2018 09:55:01 -0700 (PDT) Original-Received: from 9a50e8462956 (cpe-184-152-55-93.nyc.res.rr.com. [184.152.55.93]) by smtp.gmail.com with ESMTPSA id c93-v6sm2650195qkh.90.2018.07.01.09.55.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Jul 2018 09:55:01 -0700 (PDT) In-reply-to: <83in5zkjsk.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148051 Archived-At: Eli Zaretskii writes: >> From: John Shahid >> Cc: Eli Zaretskii , 31325@debbugs.gnu.org, monnier@iro.umontreal.ca >> Date: Sun, 01 Jul 2018 13:17:17 +0000 >> >> Fixed in the attached patch. > > Thanks, pushed to the master branch. > > Please in the future mention the bug number in the log message, and > also grep the sources for callers of the functions you change. (In > this case, there was one caller in w32console.c, and it wouldn't > compile after the change, because the number of arguments changed.) Thanks Eli. Sorry about that, I will try to be more careful in the future. It just occurred to me that this change will break backward comparability for those who bind some key to the `recenter' command, since now the second argument will always be nil and thus won't redisplay. Should we also change the interactive form of recenter to use "p" for the second argument? That way the second arg is never nil when used interactively.