unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: John Shahid <jvshahid@gmail.com>
Cc: 31325@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#31325: 27.0.50; PROPOSAL: introduce a new function to recenter without redisplaying the frame
Date: Mon, 02 Jul 2018 18:22:44 +0300	[thread overview]
Message-ID: <83woudk6gr.fsf@gnu.org> (raw)
In-Reply-To: <87po06ye9q.fsf@gmail.com> (message from John Shahid on Sun, 01 Jul 2018 18:58:09 +0000)

> From: John Shahid <jvshahid@gmail.com>
> Cc: rudalics@gmx.at, 31325@debbugs.gnu.org, monnier@iro.umontreal.ca
> Date: Sun, 01 Jul 2018 18:58:09 +0000
> 
> >From 3ac3d2d5f60593776563e27d4b406b2776de9b96 Mon Sep 17 00:00:00 2001
> From: John Shahid <jvshahid@gmail.com>
> Date: Sun, 1 Jul 2018 14:48:24 -0400
> Subject: [PATCH] Keep `recenter' behavior backward compatible when called
>  interactively
> 
> * window.c (recenter): Change the interactive spec to always pass a
>   non-nil value to the REDISPLAY argument when called interactively.
> * window.el (recenter-top-bottom): Make sure recenter's second
>   argument is non-nil everywhere.
> * windows.texi (Textual Scrolling): Edit documentation of `recenter'.

Bug number is missing.  Also, we prefer to quite in documentation (as
opposed to doc strings) 'like this', not `like this'.

> --- a/doc/lispref/windows.texi
> +++ b/doc/lispref/windows.texi
> @@ -4154,7 +4154,8 @@ Textual Scrolling
>  @code{recenter} puts the line containing point in the middle of the
>  window.  If @var{count} is @code{nil} and @var{redisplay} is
>  non-@code{nil}, this function may redraw the frame, according to the
> -value of @code{recenter-redisplay}.
> +value of @code{recenter-redisplay}. Interactive calls pass non-‘nil’
> +for @var{redisplay}.              ^^

Two spaces between sentences.

> -DEFUN ("recenter", Frecenter, Srecenter, 0, 2, "P",
> +DEFUN ("recenter", Frecenter, Srecenter, 0, 2, "P\np",
>         doc: /* Center point in selected window and maybe redisplay frame.
>  With a numeric prefix argument ARG, recenter putting point on screen line ARG
>  relative to the selected window.  If ARG is negative, it counts up from the
> @@ -5910,7 +5910,7 @@ non-nil, also erase the entire frame and redraw it (when
>  `auto-resize-tool-bars' is set to `grow-only', this resets the
>  tool-bar's height to the minimum height needed); if
>  `recenter-redisplay' has the special value `tty', then only tty frames
> -are redrawn.
> +are redrawn.  Interactive calls pass non-nil for REDISPLAY.

I think this text is slightly more clear:

  Interactively, REDISPLAY is always non-nil.

Thanks.





  reply	other threads:[~2018-07-02 15:22 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-01  0:48 bug#31325: 27.0.50; PROPOSAL: introduce a new function to recenter without redisplaying the frame John Shahid
2018-05-08  1:37 ` Stefan Monnier
2018-06-28 13:27   ` John Shahid
2018-06-30  9:45     ` Eli Zaretskii
2018-06-30 20:20       ` John Shahid
2018-07-01  9:05         ` martin rudalics
2018-07-01 13:17           ` John Shahid
2018-07-01 16:22             ` Eli Zaretskii
2018-07-01 16:54               ` John Shahid
2018-07-01 17:03                 ` Eli Zaretskii
2018-07-01 17:14                   ` Eli Zaretskii
2018-07-01 17:25                     ` John Shahid
2018-07-01 20:17                       ` Drew Adams
2018-07-01 20:56                         ` John Shahid
2018-07-01 23:04                           ` Drew Adams
2018-07-02  2:27                             ` John Shahid
2018-07-02 15:18                               ` Eli Zaretskii
2018-07-01 17:18                   ` John Shahid
2018-07-01 18:05                     ` Eli Zaretskii
2018-07-01 18:58                       ` John Shahid
2018-07-02 15:22                         ` Eli Zaretskii [this message]
2018-07-02 20:38                           ` John Shahid
2018-07-03  8:49                             ` Robert Pluim
2018-07-03 16:38                             ` John Shahid
2018-07-07  9:09                               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83woudk6gr.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=31325@debbugs.gnu.org \
    --cc=jvshahid@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).