* bug#38677: 26.3; `display-buffer-reuse-mode-window' doesn't check for derived modes
@ 2019-12-19 20:37 Trevor Murphy via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-12-20 2:28 ` bug#38677: [PATCH] Fix bug in `display-buffer-reuse-mode-window'. (bug#38677) Trevor Murphy via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 3+ messages in thread
From: Trevor Murphy via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2019-12-19 20:37 UTC (permalink / raw)
To: 38677
The problem is in the middle of the function:
(let ((mode?
(with-current-buffer (window-buffer window)
(cond ((memq major-mode allowed-modes)
'same)
((derived-mode-p allowed-modes) ; <= this line
'derived)))))
...)
`allowed-modes' is always a list at this point, but `derived-mode-p'
expects each mode as a separated argument (it takes them with an &rest
parameter). So this call always fails.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#38677: [PATCH] Fix bug in `display-buffer-reuse-mode-window'. (bug#38677)
2019-12-19 20:37 bug#38677: 26.3; `display-buffer-reuse-mode-window' doesn't check for derived modes Trevor Murphy via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2019-12-20 2:28 ` Trevor Murphy via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-01 22:31 ` Lars Ingebrigtsen
0 siblings, 1 reply; 3+ messages in thread
From: Trevor Murphy via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2019-12-20 2:28 UTC (permalink / raw)
To: 38677
Sorry about the delay getting this out, I can never remember how to
use git send-email.
---
lisp/window.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/window.el b/lisp/window.el
index a0280eba9b..96a22db885 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -7619,7 +7619,7 @@ indirectly called by the latter."
(with-current-buffer (window-buffer window)
(cond ((memq major-mode allowed-modes)
'same)
- ((derived-mode-p allowed-modes)
+ ((apply #'derived-mode-p allowed-modes)
'derived)))))
(when (and mode?
(not (and inhibit-same-window-p
--
2.24.1.735.g03f4e72817-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#38677: [PATCH] Fix bug in `display-buffer-reuse-mode-window'. (bug#38677)
2019-12-20 2:28 ` bug#38677: [PATCH] Fix bug in `display-buffer-reuse-mode-window'. (bug#38677) Trevor Murphy via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2020-10-01 22:31 ` Lars Ingebrigtsen
0 siblings, 0 replies; 3+ messages in thread
From: Lars Ingebrigtsen @ 2020-10-01 22:31 UTC (permalink / raw)
To: Trevor Murphy; +Cc: 38677
Trevor Murphy <trevormurphy@google.com> writes:
> - ((derived-mode-p allowed-modes)
> + ((apply #'derived-mode-p allowed-modes)
Thanks; applied to Emacs 28.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-01 22:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-19 20:37 bug#38677: 26.3; `display-buffer-reuse-mode-window' doesn't check for derived modes Trevor Murphy via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-12-20 2:28 ` bug#38677: [PATCH] Fix bug in `display-buffer-reuse-mode-window'. (bug#38677) Trevor Murphy via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-01 22:31 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).