From: Trevor Murphy via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: 38677@debbugs.gnu.org
Subject: bug#38677: 26.3; `display-buffer-reuse-mode-window' doesn't check for derived modes
Date: Thu, 19 Dec 2019 12:37:40 -0800 [thread overview]
Message-ID: <mt65pngkoxuz.fsf@google.com> (raw)
The problem is in the middle of the function:
(let ((mode?
(with-current-buffer (window-buffer window)
(cond ((memq major-mode allowed-modes)
'same)
((derived-mode-p allowed-modes) ; <= this line
'derived)))))
...)
`allowed-modes' is always a list at this point, but `derived-mode-p'
expects each mode as a separated argument (it takes them with an &rest
parameter). So this call always fails.
next reply other threads:[~2019-12-19 20:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 20:37 Trevor Murphy via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2019-12-20 2:28 ` bug#38677: [PATCH] Fix bug in `display-buffer-reuse-mode-window'. (bug#38677) Trevor Murphy via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-01 22:31 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mt65pngkoxuz.fsf@google.com \
--to=bug-gnu-emacs@gnu.org \
--cc=38677@debbugs.gnu.org \
--cc=trevormurphy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).