From: Lars Ingebrigtsen <larsi@gnus.org>
To: akater <nuclearspace@gmail.com>
Cc: "Mattias Engdegård" <mattiase@acm.org>,
9622@debbugs.gnu.org, "Diogo F. S. Ramos" <diogofsr@gmail.com>
Subject: bug#9622: [PATCH] Re: bug#9622: 23.3; flet indentation
Date: Thu, 30 Sep 2021 08:37:36 +0200 [thread overview]
Message-ID: <87tui26027.fsf@gnus.org> (raw)
In-Reply-To: <87lf3fntdx.fsf@gmail.com> (akater's message of "Wed, 29 Sep 2021 18:12:10 +0000")
akater <nuclearspace@gmail.com> writes:
> - We now check whether we're in the relevant subexpression of flet and
> friends.
>
> - Added -p to the predicate's name.
>
> - Added cl-macrolet cl-flet* cl-symbol-macrolet to the list of local
> definers. I added cl-symbol-macrolet too because this is how SLIME
> indents symbol-macrolet.
Thanks; applied to Emacs 28.
> - I attached flet-tests.sexp which only contains cl-flet forms written
> the way they are meant to be indented. I think writing them in
> strings in deftest forms would be quite ugly and unreliable.
Indeed. I have a new machinery for doing tests like this waiting for
Emacs 29 development to commence to fix this awkwardness.
> - You changed “iff” to “if”; I meant “iff”, i.e. “if and only if”; I
> now changed it to “when” simply because the semantics corresponds
> directly to that of lisp's own lingo and is thus in my opinion
> easier to read.
Oops, sorry.
> The more involved stylistic note is
>
> - a line split issue that I wanted to discuss for some time. See the
> diff when it comes to second-order-parent and (pop parents). TL;DR:
> it's entirely up to you but I wanted to point out that this was done
> deliberately. Note that if pop (or a hypothetical cdrf) accepted
> multiple arguments, most people would agree it's fine to keep these
> two on a single line; if you have time, see the discussion I started
> in emacs-devel:
> https://lists.gnu.org/archive/html/emacs-devel/2021-09/msg02189.html
We never put two statements on the same line like that, so I added a
newline there (and some other stylistic fixes, like changing the `and' to
a when (the `and' is logical here (since we're doing a predicate), but
we prefer `when' when it's a long and involved body).
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-09-30 6:37 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <504153FB-8633-4755-A91A-DF5DD64E6FAA@acm.org>
2021-09-28 3:01 ` bug#9622: 23.3; flet indentation akater
2021-09-28 5:23 ` Lars Ingebrigtsen
2021-09-28 10:11 ` Mattias Engdegård
2021-09-28 10:35 ` Mattias Engdegård
2021-09-28 16:39 ` akater
2021-09-29 18:12 ` bug#9622: [PATCH] " akater
2021-09-30 6:37 ` Lars Ingebrigtsen [this message]
2021-09-30 8:05 ` Mattias Engdegård
2021-09-30 13:06 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-30 13:41 ` Lars Ingebrigtsen
2021-09-30 13:57 ` akater
2021-10-01 11:27 ` Lars Ingebrigtsen
2021-10-09 7:26 ` akater
2021-10-09 11:23 ` Lars Ingebrigtsen
2021-10-28 19:23 ` akater
2021-10-28 21:53 ` Lars Ingebrigtsen
2021-09-30 14:52 ` Mattias Engdegård
2021-09-30 15:11 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-30 15:23 ` Thierry Volpiatto
2021-09-30 15:33 ` akater
2021-09-30 16:04 ` Thierry Volpiatto
2021-09-30 15:25 ` Mattias Engdegård
2021-09-30 15:56 ` akater
2021-09-30 19:28 ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-30 23:23 ` akater
2021-11-08 1:13 ` Michael Heerdegen
2021-11-08 6:18 ` bug#9622: [PATCH] " akater
2021-11-08 6:38 ` Lars Ingebrigtsen
2021-11-08 6:38 ` akater
2021-11-08 6:53 ` Lars Ingebrigtsen
2021-11-08 9:36 ` akater
2021-11-09 3:25 ` Lars Ingebrigtsen
2021-11-08 16:30 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tui26027.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=9622@debbugs.gnu.org \
--cc=diogofsr@gmail.com \
--cc=mattiase@acm.org \
--cc=nuclearspace@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).