From: "Mattias Engdegård" <mattiase@acm.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 9622@debbugs.gnu.org, akater <nuclearspace@gmail.com>
Subject: bug#9622: [PATCH] Re: bug#9622: 23.3; flet indentation
Date: Thu, 30 Sep 2021 10:05:33 +0200 [thread overview]
Message-ID: <7A41EEAF-B19C-48A2-9033-275B7E001884@acm.org> (raw)
In-Reply-To: <87tui26027.fsf@gnus.org>
30 sep. 2021 kl. 08.37 skrev Lars Ingebrigtsen <larsi@gnus.org>:
>> - I attached flet-tests.sexp which only contains cl-flet forms written
>> the way they are meant to be indented. I think writing them in
>> strings in deftest forms would be quite ugly and unreliable.
What would be unreliable?
> Indeed. I have a new machinery for doing tests like this waiting for
> Emacs 29 development to commence to fix this awkwardness.
We should insist on tests accompanying any bug fix from the start. Awkward is better than nothing. If the author finds it too difficult to write the test then we should help.
Akater, we have plenty of indentation tests for other programming modes already and they employ a variety of methods; there are many examples to look at. For instance, look at ruby-mode-tests.el; it contains a converted legacy test (ruby--indent/converted-from-manual-test) that reindents a separate source file, much like your example.
If you need further directions, we will assist.
next prev parent reply other threads:[~2021-09-30 8:05 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <504153FB-8633-4755-A91A-DF5DD64E6FAA@acm.org>
2021-09-28 3:01 ` bug#9622: 23.3; flet indentation akater
2021-09-28 5:23 ` Lars Ingebrigtsen
2021-09-28 10:11 ` Mattias Engdegård
2021-09-28 10:35 ` Mattias Engdegård
2021-09-28 16:39 ` akater
2021-09-29 18:12 ` bug#9622: [PATCH] " akater
2021-09-30 6:37 ` Lars Ingebrigtsen
2021-09-30 8:05 ` Mattias Engdegård [this message]
2021-09-30 13:06 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-30 13:41 ` Lars Ingebrigtsen
2021-09-30 13:57 ` akater
2021-10-01 11:27 ` Lars Ingebrigtsen
2021-10-09 7:26 ` akater
2021-10-09 11:23 ` Lars Ingebrigtsen
2021-10-28 19:23 ` akater
2021-10-28 21:53 ` Lars Ingebrigtsen
2021-09-30 14:52 ` Mattias Engdegård
2021-09-30 15:11 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-30 15:23 ` Thierry Volpiatto
2021-09-30 15:33 ` akater
2021-09-30 16:04 ` Thierry Volpiatto
2021-09-30 15:25 ` Mattias Engdegård
2021-09-30 15:56 ` akater
2021-09-30 19:28 ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-30 23:23 ` akater
2021-11-08 1:13 ` Michael Heerdegen
2021-11-08 6:18 ` bug#9622: [PATCH] " akater
2021-11-08 6:38 ` Lars Ingebrigtsen
2021-11-08 6:38 ` akater
2021-11-08 6:53 ` Lars Ingebrigtsen
2021-11-08 9:36 ` akater
2021-11-09 3:25 ` Lars Ingebrigtsen
2021-11-08 16:30 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7A41EEAF-B19C-48A2-9033-275B7E001884@acm.org \
--to=mattiase@acm.org \
--cc=9622@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=nuclearspace@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).