From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#9622: [PATCH] Re: bug#9622: 23.3; flet indentation Date: Thu, 30 Sep 2021 08:37:36 +0200 Message-ID: <87tui26027.fsf@gnus.org> References: <504153FB-8633-4755-A91A-DF5DD64E6FAA@acm.org> <87lf3fntdx.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19590"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 9622@debbugs.gnu.org, "Diogo F. S. Ramos" To: akater Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 30 08:54:45 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mVpxs-0004qg-Iq for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Sep 2021 08:54:44 +0200 Original-Received: from localhost ([::1]:40414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVpxr-0003kr-IG for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Sep 2021 02:54:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56284) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVphm-0000YA-It for bug-gnu-emacs@gnu.org; Thu, 30 Sep 2021 02:38:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39660) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mVphi-00057C-HV for bug-gnu-emacs@gnu.org; Thu, 30 Sep 2021 02:38:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mVphi-0001Ae-Fa for bug-gnu-emacs@gnu.org; Thu, 30 Sep 2021 02:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Sep 2021 06:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9622 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 9622-submit@debbugs.gnu.org id=B9622.16329838694479 (code B ref 9622); Thu, 30 Sep 2021 06:38:02 +0000 Original-Received: (at 9622) by debbugs.gnu.org; 30 Sep 2021 06:37:49 +0000 Original-Received: from localhost ([127.0.0.1]:51206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVphU-0001AB-Kh for submit@debbugs.gnu.org; Thu, 30 Sep 2021 02:37:48 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:38282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVphT-00019w-92 for 9622@debbugs.gnu.org; Thu, 30 Sep 2021 02:37:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=sTk9XTZFVJv8z483NHNpzmNWy7894VSlaybnjyPZ59I=; b=L0sXsKz5rlKcfsJ8txDPpUIQJ2 DOCG4DRScHF8aZIEsw8GbKJUt6MLYUEJfbjUlBkJr6ZCBjF3RWlcVvkL9vJIs348qsucpbPfgLdFg ul0McyMIe32Oqni/GqGlMDmlR/Efyjd7P5vSiZNFK7ZpWn5ma4rNmS8gJqol7qX7xxhA=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mVphI-0002ZX-Th; Thu, 30 Sep 2021 08:37:39 +0200 X-Now-Playing: The Notwist's _Close to the Glass_: "Signals" In-Reply-To: <87lf3fntdx.fsf@gmail.com> (akater's message of "Wed, 29 Sep 2021 18:12:10 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215936 Archived-At: akater writes: > - We now check whether we're in the relevant subexpression of flet and > friends. > > - Added -p to the predicate's name. > > - Added cl-macrolet cl-flet* cl-symbol-macrolet to the list of local > definers. I added cl-symbol-macrolet too because this is how SLIME > indents symbol-macrolet. Thanks; applied to Emacs 28. > - I attached flet-tests.sexp which only contains cl-flet forms written > the way they are meant to be indented. I think writing them in > strings in deftest forms would be quite ugly and unreliable. Indeed. I have a new machinery for doing tests like this waiting for Emacs 29 development to commence to fix this awkwardness. > - You changed =E2=80=9Ciff=E2=80=9D to =E2=80=9Cif=E2=80=9D; I meant =E2= =80=9Ciff=E2=80=9D, i.e. =E2=80=9Cif and only if=E2=80=9D; I > now changed it to =E2=80=9Cwhen=E2=80=9D simply because the semantics c= orresponds > directly to that of lisp's own lingo and is thus in my opinion > easier to read. Oops, sorry. > The more involved stylistic note is > > - a line split issue that I wanted to discuss for some time. See the > diff when it comes to second-order-parent and (pop parents). TL;DR: > it's entirely up to you but I wanted to point out that this was done > deliberately. Note that if pop (or a hypothetical cdrf) accepted > multiple arguments, most people would agree it's fine to keep these > two on a single line; if you have time, see the discussion I started > in emacs-devel: > https://lists.gnu.org/archive/html/emacs-devel/2021-09/msg02189.html We never put two statements on the same line like that, so I added a newline there (and some other stylistic fixes, like changing the `and' to a when (the `and' is logical here (since we're doing a predicate), but we prefer `when' when it's a long and involved body). --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no