From: Robert Pluim <rpluim@gmail.com>
To: Cyril Arnould <cyril.arnould@outlook.com>
Cc: "54730@debbugs.gnu.org" <54730@debbugs.gnu.org>,
Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#54730: AW: bug#54730: 28.1; vhdl-update-sensitivity-list not working in Windows
Date: Tue, 05 Apr 2022 20:09:28 +0200 [thread overview]
Message-ID: <87tub75rmv.fsf@gmail.com> (raw)
In-Reply-To: <AM5PR06MB3105A2A44512FB59DB2D61F9E3E49@AM5PR06MB3105.eurprd06.prod.outlook.com> (Cyril Arnould's message of "Tue, 5 Apr 2022 17:53:20 +0000")
>>>>> On Tue, 5 Apr 2022 17:53:20 +0000, Cyril Arnould <cyril.arnould@outlook.com> said:
Cyril> Nice, it’s working! Too bad this didn’t make it into the 28.1 release, I guess I should have
Cyril> tested more. So for now the solution is to keep the vhdl-mode.el locally until it finds its
Cyril> way into a maintenance release?
Yes. Eli might decide to put it in 28.2
An alternative (shorter) fix would be this. Stefan, is there a
preference for how these types of lexical-binding bugs are fixed?
diff --git a/lisp/progmodes/vhdl-mode.el b/lisp/progmodes/vhdl-mode.el
index c6693b4de5..a0e7f8a82f 100644
--- a/lisp/progmodes/vhdl-mode.el
+++ b/lisp/progmodes/vhdl-mode.el
@@ -8453,8 +8453,8 @@ vhdl-update-sensitivity-list
;; scan for signals read in process
(while scan-regions-list
(goto-char proc-mid)
- (while (and (setq beg (eval (nth 0 (car scan-regions-list))))
- (setq end (eval (nth 1 (car scan-regions-list)))))
+ (while (and (setq beg (eval (nth 0 (car scan-regions-list)) `((proc-end . ,proc-end))))
+ (setq end (eval (nth 1 (car scan-regions-list)) `((proc-end . ,proc-end)))))
(goto-char beg)
(unless (or (vhdl-in-literal)
(and seq-region-list
Robert
--
next prev parent reply other threads:[~2022-04-05 18:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 16:17 bug#54730: 28.1; vhdl-update-sensitivity-list not working in Windows Cyril Arnould
2022-04-05 16:43 ` Eli Zaretskii
2022-04-05 17:08 ` bug#54730: AW: " Cyril Arnould
2022-04-05 17:12 ` Cyril Arnould
2022-04-05 17:26 ` Eli Zaretskii
2022-04-05 17:53 ` bug#54730: AW: " Cyril Arnould
2022-04-05 18:09 ` Robert Pluim [this message]
2022-04-05 21:21 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-05 22:27 ` bug#54730: AW: " Cyril Arnould
2022-04-05 18:18 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tub75rmv.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=54730@debbugs.gnu.org \
--cc=cyril.arnould@outlook.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).