From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#54730: AW: bug#54730: 28.1; vhdl-update-sensitivity-list not working in Windows Date: Tue, 05 Apr 2022 20:09:28 +0200 Message-ID: <87tub75rmv.fsf@gmail.com> References: <83zgkzcwfq.fsf@gnu.org> <83y20jcugz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30126"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "54730@debbugs.gnu.org" <54730@debbugs.gnu.org>, Stefan Monnier To: Cyril Arnould Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 05 20:10:25 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbndJ-0007eQ-OK for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Apr 2022 20:10:25 +0200 Original-Received: from localhost ([::1]:53276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nbndI-00060m-Og for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Apr 2022 14:10:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34262) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbncx-00060c-Ju for bug-gnu-emacs@gnu.org; Tue, 05 Apr 2022 14:10:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33963) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nbncx-0007Sg-AP for bug-gnu-emacs@gnu.org; Tue, 05 Apr 2022 14:10:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nbncw-0002zS-NP for bug-gnu-emacs@gnu.org; Tue, 05 Apr 2022 14:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Apr 2022 18:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54730 X-GNU-PR-Package: emacs Original-Received: via spool by 54730-submit@debbugs.gnu.org id=B54730.164918217811449 (code B ref 54730); Tue, 05 Apr 2022 18:10:02 +0000 Original-Received: (at 54730) by debbugs.gnu.org; 5 Apr 2022 18:09:38 +0000 Original-Received: from localhost ([127.0.0.1]:56093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nbncX-0002yb-TO for submit@debbugs.gnu.org; Tue, 05 Apr 2022 14:09:38 -0400 Original-Received: from mail-wr1-f42.google.com ([209.85.221.42]:37573) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nbncW-0002yK-NI for 54730@debbugs.gnu.org; Tue, 05 Apr 2022 14:09:37 -0400 Original-Received: by mail-wr1-f42.google.com with SMTP id z1so8263641wrg.4 for <54730@debbugs.gnu.org>; Tue, 05 Apr 2022 11:09:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=TxBEBFTA4Z8sV0ZnDky/9p3FN8bK54pcanDwm9IgbV8=; b=XDqfXfFjplLxWGbqBr6XGSJlxCmC0eVHxPAsxM8aPBbLKjm5EWEqKmgn1CRqsoabE9 Jy+gJlaTtf/zmy0ZsHrVnUkomFQH7C6XAxGahZsvq2NDRUYLUKpRkhA/eoKxGo6GPCSA UjQ1TAG3QxfI50e2DAjyjzExhhcokXhgJTwxjjzUnbkBEgjukgjQ1NA8H5zuhy5DR45l U5CLnfl246fpRaRhdp9rOsVMB006UycKjXfrW6TxFKp+V5+9YkTvKlxhSHaipG+ECU8S m3osnzMWTHMOeL9TUK1/m4l2KecZ1FW8vCTjnYfEbcDrcGDVSm9OgY3EkWF8+0OZH2tk 9zug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=TxBEBFTA4Z8sV0ZnDky/9p3FN8bK54pcanDwm9IgbV8=; b=LHMTUl5JEKAzIQ6jBDsaaNz4HYulmvdYjG3Sx9U6uoXYVPWPhGDECQY/luCbyU6VF3 GnG972Pwi9TwJXctOPZh2iyOs1J1h/kz8ND4hnluAXTXoxdDeElYcDS8GaOVJ+u3M4Od E+qLrnc+DMZsX/1F98h/Is0RsOEP35P3jYUBvs36lwFsmf8/1ke4G9d54ryaNzGjsTMF NASdXoENFfIF9ZRHhcn49d0EbJno5j67T9+wckREK73VyTiT7HO9BFSU85nVwjYggSZN 5RK16tO7IO+QLnnWBLYxqZSiO//Vj10BeFCHC0f5+1rTsAiEmrFc08lG4DhHzwx0I45n 0PyQ== X-Gm-Message-State: AOAM533V0ZvJHnuqd7XqXzOnPgPdhN+vZ30hCUy0alHh7+3koANyHLHy 61zWu+9FeJvgnuReIQmRSNo= X-Google-Smtp-Source: ABdhPJz3lFtyzJIkzVLFFHgcywx9G+yRj3/RWeGHe1ySGs0gHNThbUhnqA723kw6WzG6/n8jy4Z98Q== X-Received: by 2002:a05:6000:2c9:b0:204:1675:843e with SMTP id o9-20020a05600002c900b002041675843emr3650160wry.699.1649182169708; Tue, 05 Apr 2022 11:09:29 -0700 (PDT) Original-Received: from rltb ([2a01:e0a:3f3:fb50:f97:ff71:7e0d:55c6]) by smtp.gmail.com with ESMTPSA id o14-20020a5d47ce000000b00203e0a21c16sm15444506wrc.3.2022.04.05.11.09.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Apr 2022 11:09:29 -0700 (PDT) In-Reply-To: (Cyril Arnould's message of "Tue, 5 Apr 2022 17:53:20 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229457 Archived-At: >>>>> On Tue, 5 Apr 2022 17:53:20 +0000, Cyril Arnould said: Cyril> Nice, it=E2=80=99s working! Too bad this didn=E2=80=99t make it = into the 28.1 release, I guess I should have Cyril> tested more. So for now the solution is to keep the vhdl-mode.el= locally until it finds its Cyril> way into a maintenance release? Yes. Eli might decide to put it in 28.2 An alternative (shorter) fix would be this. Stefan, is there a preference for how these types of lexical-binding bugs are fixed? diff --git a/lisp/progmodes/vhdl-mode.el b/lisp/progmodes/vhdl-mode.el index c6693b4de5..a0e7f8a82f 100644 --- a/lisp/progmodes/vhdl-mode.el +++ b/lisp/progmodes/vhdl-mode.el @@ -8453,8 +8453,8 @@ vhdl-update-sensitivity-list ;; scan for signals read in process (while scan-regions-list (goto-char proc-mid) - (while (and (setq beg (eval (nth 0 (car scan-regions-list)))) - (setq end (eval (nth 1 (car scan-regions-list))))) + (while (and (setq beg (eval (nth 0 (car scan-regions-list)) `((proc-e= nd . ,proc-end)))) + (setq end (eval (nth 1 (car scan-regions-list)) `((proc-end . ,proc-end= ))))) (goto-char beg) (unless (or (vhdl-in-literal) (and seq-region-list Robert --=20