From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matthias Meulien Newsgroups: gmane.emacs.bugs Subject: bug#57821: 29.0.50; ANSI sequence not filtered in compilation buffer Date: Sun, 18 Sep 2022 17:45:45 +0200 Message-ID: <87tu543cuu.fsf@gmail.com> References: <87fsgt11w0.fsf@gmail.com> <87bkrg28lu.fsf@gmail.com> <877d23a7mh.fsf@gnus.org> <87tu55zzll.fsf@gmail.com> <87mtax55v7.fsf@gnus.org> <8735co4zse.fsf@gmail.com> <87k06026bw.fsf@gnus.org> <87y1ug3ik4.fsf@gmail.com> <87fsgopv5j.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4880"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 57821@debbugs.gnu.org, Lars Ingebrigtsen To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 18 17:46:58 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZwVW-00014v-4G for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Sep 2022 17:46:58 +0200 Original-Received: from localhost ([::1]:52648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZwVU-0006B7-Sb for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Sep 2022 11:46:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37022) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZwUf-00069D-7G for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2022 11:46:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51962) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oZwUc-0005tG-E8 for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2022 11:46:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oZwUc-0003s4-0y for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2022 11:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Matthias Meulien Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Sep 2022 15:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57821 X-GNU-PR-Package: emacs Original-Received: via spool by 57821-submit@debbugs.gnu.org id=B57821.166351595514868 (code B ref 57821); Sun, 18 Sep 2022 15:46:01 +0000 Original-Received: (at 57821) by debbugs.gnu.org; 18 Sep 2022 15:45:55 +0000 Original-Received: from localhost ([127.0.0.1]:51040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZwUV-0003rj-3h for submit@debbugs.gnu.org; Sun, 18 Sep 2022 11:45:55 -0400 Original-Received: from mail-wm1-f51.google.com ([209.85.128.51]:54998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZwUS-0003rW-Sw for 57821@debbugs.gnu.org; Sun, 18 Sep 2022 11:45:53 -0400 Original-Received: by mail-wm1-f51.google.com with SMTP id az6so19110069wmb.4 for <57821@debbugs.gnu.org>; Sun, 18 Sep 2022 08:45:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date; bh=0QKTN5bQ9BfGCfiZ0VbeKTvy0uDsflB9LReYkMJGQOc=; b=CKqyQkKHhvQbecI1hTtWye8DhEUePIRRllebQwaE/cKhyeihkqHFSecD1ibS/znImK nMIlQ7219cthDaJAeZKD5oILOTKt9/wBov0az9Q1ItqKfTsX279Mj5qDY3uQEPdrZjVa ySzRFE6GnTBS8I4Yf2BO25zJiKHNjkf9mwkMvB4YU8N6hDJEa8flUkeUAEFbshuJnW+o oYUtisW0NLiRm/YpmPSw+ELix4NDLovx0O7+r/4ybEczqCag48RJ76/xUrqBA3+0XjKK H3m8lDITgs0QYuzu6dOLm3OqiijtDeT1AzkWeljKcqdEPYih1Z7FpsIiyrHS3aynNxet XZQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date; bh=0QKTN5bQ9BfGCfiZ0VbeKTvy0uDsflB9LReYkMJGQOc=; b=TaG3kdkYULw/UdmRkJXekzCuOQV7gFWsckDpzUAlx/T9gPDMoNVeyLbyDLNVQ95blR 7IsUKd2zvBX6Io0q/IocqMDsXzxLyBYnWqI7RH5Lp3iIVTPHHTObEafnKQr1ATVRqI+E i40ia5K6fk76Eo48albQ7Og6votIpQwsi//vzLFDnsoB75E6pMjXorXjTozVAfNzS/+4 uwJyZTNrJTC8H+uE2UeXbkjJwVuruINLGVMOLFgcw+Us/aAwvNHAZ51IaZeQTT1mPx0t LrfiVb5OtxdvBvVGEMioSlCW6gKnsmj183iFP9x8wqZlIVIPjusK7ZWg+AhI3MST7LgA tVtg== X-Gm-Message-State: ACrzQf0fkCE9LRHUW+biL4nIHdvaa0uSYjIMThsqsTJVhtu0pvIjefG8 5fW++uqUyj9ORGWtKcUzN0w= X-Google-Smtp-Source: AMsMyM7AkbKjgofyQGDTywefgxKqKZPyH5jJwxB9GVJGLoJb5K43qsSWlHJPi7+17V48wEnbX1xM2w== X-Received: by 2002:a1c:7213:0:b0:3b3:4065:66cc with SMTP id n19-20020a1c7213000000b003b3406566ccmr9712700wmc.184.1663515946747; Sun, 18 Sep 2022 08:45:46 -0700 (PDT) Original-Received: from carbon.localdomain ([2a01:e0a:245:c850:98f5:429a:aa8e:95bb]) by smtp.gmail.com with ESMTPSA id v13-20020adfebcd000000b0022a403954c3sm11183419wrn.42.2022.09.18.08.45.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Sep 2022 08:45:46 -0700 (PDT) In-Reply-To: <87fsgopv5j.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 18 Sep 2022 18:19:36 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243001 Archived-At: "Basil L. Contovounesios" writes: > Matthias Meulien [2022-09-18 15:42 +0200] wrote: > >> +*** New package 'osc'. >> +Support for OSC ("Operating System Command") espace sequences has been >> +extracted from 'comint.el' in order to provide interpretation of OSC >> +escape sequences in compilation buffers. >> + >> +Adding the new function 'osc-compilation-filter' to >> +'compilation-filter-hook' enables interpretation of OSC ("Operating >> +System Command") escape sequences in compilation buffers. By default, > ^^ > Two spaces after a full stop, here and in the other patches. Thanks for your careful reading! I failed to found places with this problem in the other patches... >> +all sequences are filtered out. >> + >> +A handler for OSC 2, the command to set a window title, is provided. > > Also OSC 7 and 8, no? Sure, I thought it's a new handler was implicit in the NEWS file; Other handlers were already mentionned in NEWS.28. But let's try to be more precise. > > BTW, the commentary in comint.el doesn't mention OSC 2. +1 Here is a patch improving the news entry and fixing the defalias for variables you mentionned in your other message. I didn't tried to solve the alias for the button; I'll have to learn more about aliases first, I thought that just "maintaining" the symbol would be ok. diff --git a/etc/NEWS b/etc/NEWS index 88d00d9474..5fe96b0e0c 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -2441,11 +2441,12 @@ extracted from 'comint.el' in order to provide interpretation of OSC escape sequences in compilation buffers. Adding the new function 'osc-compilation-filter' to -'compilation-filter-hook' enables interpretation of OSC ("Operating -System Command") escape sequences in compilation buffers. By default, -all sequences are filtered out. +'compilation-filter-hook' enables interpretation of OSC escape +sequences in compilation buffers. By default, all sequences are +filtered out. -A handler for OSC 2, the command to set a window title, is provided. +The list of handlers (covering OSC 7 and 8) has been extended with a +handler for OSC 2, the command to set a window title. +++ *** New user option 'project-vc-include-untracked'. diff --git a/lisp/comint.el b/lisp/comint.el index afaa27c2c0..202cf6eab5 100644 --- a/lisp/comint.el +++ b/lisp/comint.el @@ -3910,17 +3910,17 @@ comint-redirect-results-list-from-process ;;============================================================================ ;; Adding `comint-osc-process-output' to ;; `comint-output-filter-functions' enables the interpretation of OSC -;; escape sequences. By default, OSC 7 and 8 (for current directory -;; and hyperlinks respectively) are acted upon. Adding more entries -;; to `comint-osc-handlers' allows a customized treatment of further -;; sequences. +;; escape sequences. By default, OSC 2, 7 and 8 (for window title, +;; current directory and hyperlinks respectively) are acted upon. +;; Adding more entries to `comint-osc-handlers' allows a customized +;; treatment of further sequences. ;; Aliases defined for reverse compatibility -(defalias 'comint-osc-handlers 'osc-handlers) +(defvaralias 'comint-osc-handlers 'osc-handlers) (defalias 'comint-osc-directory-tracker 'osc-directory-tracker) (defalias 'comint-osc-hyperlink-handler 'osc-hyperlink-handler) (defalias 'comint-osc-hyperlink 'osc-hyperlink) -(defalias 'comint-osc-hyperlink-map 'osc-hyperlink-map) +(defvaralias 'comint-osc-hyperlink-map 'osc-hyperlink-map) (defun comint-osc-process-output (_) "Interpret OSC escape sequences in comint output.