From: Philip Kaludercic <philipk@posteo.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 58543@debbugs.gnu.org, larsi@gnus.org, stefankangas@gmail.com
Subject: bug#58543: 29.0.50; The 'q' key is not shown by "C-h ?"
Date: Sun, 16 Oct 2022 13:39:12 +0000 [thread overview]
Message-ID: <87tu433n27.fsf@posteo.net> (raw)
In-Reply-To: <83r0z83sga.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 16 Oct 2022 14:42:45 +0300")
[-- Attachment #1: Type: text/plain, Size: 891 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Philip Kaludercic <philipk@posteo.net>
>> Cc: larsi@gnus.org, 58543@debbugs.gnu.org, stefankangas@gmail.com
>> Date: Sun, 16 Oct 2022 11:11:20 +0000
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>> >> From: Philip Kaludercic <philipk@posteo.net>
>> >> Cc: Eli Zaretskii <eliz@gnu.org>, 58543@debbugs.gnu.org, Stefan Kangas
>> >> <stefankangas@gmail.com>
>> >> Date: Sun, 16 Oct 2022 10:21:05 +0000
>> >>
>> >> I would therefore remove entry from the "(make-help-screen
>> >> help-for-help" block, and consider some other place to mention the quick
>> >> help buffer.
>> >
>> > How about mentioning it in the "C-h" prompt itself?
>>
>> Do you mean the "C-h (Type ? for further options)-" prompt?
>
> Yes. Make it say
>
> C-h (Type ? for further options, q for quick help)-
>
> or somesuch.
That sounds good. How about this patch:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-src-keyboard.c-echo_add_key-Mention-quick-help.patch --]
[-- Type: text/x-patch, Size: 886 bytes --]
From 8db3c0a25bf88f8e4669fd7e2babc2ff8f5c98b2 Mon Sep 17 00:00:00 2001
From: Philip Kaludercic <philipk@posteo.net>
Date: Sun, 16 Oct 2022 15:38:28 +0200
Subject: [PATCH] * src/keyboard.c (echo_add_key): Mention quick-help
---
src/keyboard.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/keyboard.c b/src/keyboard.c
index 8ab4a451b4..8386b599c3 100644
--- a/src/keyboard.c
+++ b/src/keyboard.c
@@ -503,7 +503,7 @@ echo_add_key (Lisp_Object c)
if ((NILP (echo_string) || SCHARS (echo_string) == 0)
&& help_char_p (c))
{
- AUTO_STRING (str, " (Type ? for further options)");
+ AUTO_STRING (str, " (Type ? for further options, q for quick help)");
AUTO_LIST2 (props, Qface, Qhelp_key_binding);
Fadd_text_properties (make_fixnum (7), make_fixnum (8), props, str);
new_string = concat2 (new_string, str);
--
2.37.3
[-- Attachment #3: Type: text/plain, Size: 584 bytes --]
Stefan Kangas <stefankangas@gmail.com> writes:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>> C-h (Type ? for further options, q for quick help)-
>>
>> or somesuch.
>
> This is a nit, but is it just me that finds it confusing that the "-" is
> all the way to the right?
>
> IOW, shouldn't it say something like:
>
> C-h- (Type ? for further options, q for quick help)
>
> Or now that we have the `help-key-binding' maybe even
>
> C-h- [? further options, q quick help]
Ah, I didn't understand what the trailing dash was supposed to signify
so this looks like a good idea.
next prev parent reply other threads:[~2022-10-16 13:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-15 9:40 bug#58543: 29.0.50; The 'q' key is not shown by "C-h ?" Eli Zaretskii
2022-10-16 9:49 ` Lars Ingebrigtsen
2022-10-16 10:21 ` Philip Kaludercic
2022-10-16 10:39 ` Eli Zaretskii
2022-10-16 11:11 ` Philip Kaludercic
2022-10-16 11:42 ` Eli Zaretskii
2022-10-16 12:11 ` Stefan Kangas
2022-10-16 13:39 ` Philip Kaludercic [this message]
2022-10-16 14:03 ` Eli Zaretskii
2022-10-16 14:23 ` Lars Ingebrigtsen
2022-10-16 22:39 ` Philip Kaludercic
2022-11-04 22:59 ` Philip Kaludercic
2022-10-16 16:50 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu433n27.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=58543@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).