From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#58543: 29.0.50; The 'q' key is not shown by "C-h ?" Date: Sun, 16 Oct 2022 13:39:12 +0000 Message-ID: <87tu433n27.fsf@posteo.net> References: <838rlh77cy.fsf@gnu.org> <87mt9wjdxa.fsf@gnus.org> <87wn903w8e.fsf@posteo.net> <83v8ok3ve7.fsf@gnu.org> <87k0503twn.fsf@posteo.net> <83r0z83sga.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22535"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58543@debbugs.gnu.org, larsi@gnus.org, stefankangas@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 16 15:40:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ok3sM-0005in-0p for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Oct 2022 15:40:22 +0200 Original-Received: from localhost ([::1]:60920 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ok3sK-0005rA-N9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Oct 2022 09:40:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50974) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ok3s4-0005q1-3X for bug-gnu-emacs@gnu.org; Sun, 16 Oct 2022 09:40:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44620) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ok3s3-0002hM-4N for bug-gnu-emacs@gnu.org; Sun, 16 Oct 2022 09:40:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ok3s2-0001zK-SX for bug-gnu-emacs@gnu.org; Sun, 16 Oct 2022 09:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Oct 2022 13:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58543 X-GNU-PR-Package: emacs Original-Received: via spool by 58543-submit@debbugs.gnu.org id=B58543.16659275637582 (code B ref 58543); Sun, 16 Oct 2022 13:40:02 +0000 Original-Received: (at 58543) by debbugs.gnu.org; 16 Oct 2022 13:39:23 +0000 Original-Received: from localhost ([127.0.0.1]:43697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ok3rO-0001yE-Jx for submit@debbugs.gnu.org; Sun, 16 Oct 2022 09:39:22 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:59281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ok3rM-0001xy-Up for 58543@debbugs.gnu.org; Sun, 16 Oct 2022 09:39:21 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 50259240103 for <58543@debbugs.gnu.org>; Sun, 16 Oct 2022 15:39:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1665927555; bh=1KK6+wUCRtIEDGifaaYBuL2Ix0O9a0od+N8olaHftYI=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=Gaq9UU7Yw2LN314OXUwDS1SjK+70p0MxRDZdSgKB3jm/fvueyAx8/sJikSNqwMJ+b AAL5dZAq/M4d12eYDqMoWYfudL5HP0/U6IZ5E+Ss661/MsQ2gzg/BGDa6fYQPlhkAm ZUTTouv0NgMsON2mlLAsKtH8RJyUbD2iwKXBd+ilzDCsVL85S6YjtP/uZ8CO3JZPtB 5l4CPybyMST2VdLNmAXhwfcOHcB98G2x5I+EowfK41+Mc6FPWWSj9ry/hlfJ+MS/qG 69JNFEuZumGg2EnRfsH9gNczk3ncdy7PeORCqy21V0B40Qs0BZOY0AB2D1+jGXXLM5 UHpB3YM1zQVYQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Mr1SJ2ZbGz9rxL; Sun, 16 Oct 2022 15:39:12 +0200 (CEST) In-Reply-To: <83r0z83sga.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 16 Oct 2022 14:42:45 +0300") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245646 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: larsi@gnus.org, 58543@debbugs.gnu.org, stefankangas@gmail.com >> Date: Sun, 16 Oct 2022 11:11:20 +0000 >> >> Eli Zaretskii writes: >> >> >> From: Philip Kaludercic >> >> Cc: Eli Zaretskii , 58543@debbugs.gnu.org, Stefan Kangas >> >> >> >> Date: Sun, 16 Oct 2022 10:21:05 +0000 >> >> >> >> I would therefore remove entry from the "(make-help-screen >> >> help-for-help" block, and consider some other place to mention the quick >> >> help buffer. >> > >> > How about mentioning it in the "C-h" prompt itself? >> >> Do you mean the "C-h (Type ? for further options)-" prompt? > > Yes. Make it say > > C-h (Type ? for further options, q for quick help)- > > or somesuch. That sounds good. How about this patch: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-src-keyboard.c-echo_add_key-Mention-quick-help.patch >From 8db3c0a25bf88f8e4669fd7e2babc2ff8f5c98b2 Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Sun, 16 Oct 2022 15:38:28 +0200 Subject: [PATCH] * src/keyboard.c (echo_add_key): Mention quick-help --- src/keyboard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/keyboard.c b/src/keyboard.c index 8ab4a451b4..8386b599c3 100644 --- a/src/keyboard.c +++ b/src/keyboard.c @@ -503,7 +503,7 @@ echo_add_key (Lisp_Object c) if ((NILP (echo_string) || SCHARS (echo_string) == 0) && help_char_p (c)) { - AUTO_STRING (str, " (Type ? for further options)"); + AUTO_STRING (str, " (Type ? for further options, q for quick help)"); AUTO_LIST2 (props, Qface, Qhelp_key_binding); Fadd_text_properties (make_fixnum (7), make_fixnum (8), props, str); new_string = concat2 (new_string, str); -- 2.37.3 --=-=-= Content-Type: text/plain Stefan Kangas writes: > Eli Zaretskii writes: > >> C-h (Type ? for further options, q for quick help)- >> >> or somesuch. > > This is a nit, but is it just me that finds it confusing that the "-" is > all the way to the right? > > IOW, shouldn't it say something like: > > C-h- (Type ? for further options, q for quick help) > > Or now that we have the `help-key-binding' maybe even > > C-h- [? further options, q quick help] Ah, I didn't understand what the trailing dash was supposed to signify so this looks like a good idea. --=-=-=--