From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: 41742@debbugs.gnu.org
Subject: bug#41742: 28.0.50; Derive gnus-edit-form-mode from lisp-data-mode
Date: Sat, 06 Jun 2020 21:06:10 +0100 [thread overview]
Message-ID: <87r1usq7rh.fsf@tcd.ie> (raw)
In-Reply-To: <87wo4kroaf.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sat, 06 Jun 2020 12:23:52 -0700")
Eric Abrahamsen <eric@ericabrahamsen.net> writes:
> Hopefully this is fairly uncontroversial: Gnus has a gnus-edit-form-mode
> for editing group parameters and other things, which presents the data
> as elisp forms and is a perfect use-case for lisp-data-mode -- turning
> on paredit or what have you. This patch derives the former from the
> latter.
LGTM, FWIW.
While there, would you mind cleaning up how gnus-edit-form-mode-map is
defined? It currently does a defvar+unless+setq dance, whereas it
should ideally only be a defvar+let, as per the last few paragraphs of
(info "(elisp) Tips for Defining").
Thanks,
--
Basil
next prev parent reply other threads:[~2020-06-06 20:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-06 19:23 bug#41742: 28.0.50; Derive gnus-edit-form-mode from lisp-data-mode Eric Abrahamsen
2020-06-06 20:06 ` Basil L. Contovounesios [this message]
2020-06-06 20:25 ` Eric Abrahamsen
2020-06-06 22:31 ` Basil L. Contovounesios
2020-06-06 23:34 ` Eric Abrahamsen
2020-06-06 23:41 ` Basil L. Contovounesios
2020-06-06 23:46 ` Eric Abrahamsen
2020-06-12 16:30 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1usq7rh.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=41742@debbugs.gnu.org \
--cc=eric@ericabrahamsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).