unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 41742@debbugs.gnu.org
Subject: bug#41742: 28.0.50; Derive gnus-edit-form-mode from lisp-data-mode
Date: Sat, 06 Jun 2020 16:46:05 -0700	[thread overview]
Message-ID: <87pnabrc5e.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87d06bpxsj.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 07 Jun 2020 00:41:32 +0100")


On 06/07/20 00:41 AM, Basil L. Contovounesios wrote:
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> Here's another version...
>
> Thanks, LGTM except for one tiny nit.
>
>> From 0ee576ed0819a15a37a01e2b3a3bc176e9827c04 Mon Sep 17 00:00:00 2001
>> From: Eric Abrahamsen <eric@ericabrahamsen.net>
>> Date: Sat, 6 Jun 2020 12:13:15 -0700
>> Subject: [PATCH] Derive gnus-edit-form-mode from lisp-data-mode, fix mode map
>>
>> * lisp/gnus/gnus-eform.el (gnus-edit-form-mode): Handy for users who
>> have turned on things like paredit for lisp-data-mode.
>
> I'd say "Derive from lisp-data-mode" here as well, since the sentence
> does not otherwise stand on its own without the preceding commit
> summary's context.

Sure! I've made the change locally. I'll wait a few days for possible
objections (though I don't expect any) and then push.

Thanks,
Eric





  reply	other threads:[~2020-06-06 23:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-06 19:23 bug#41742: 28.0.50; Derive gnus-edit-form-mode from lisp-data-mode Eric Abrahamsen
2020-06-06 20:06 ` Basil L. Contovounesios
2020-06-06 20:25   ` Eric Abrahamsen
2020-06-06 22:31     ` Basil L. Contovounesios
2020-06-06 23:34       ` Eric Abrahamsen
2020-06-06 23:41         ` Basil L. Contovounesios
2020-06-06 23:46           ` Eric Abrahamsen [this message]
2020-06-12 16:30           ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pnabrc5e.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=41742@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).