From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#41742: 28.0.50; Derive gnus-edit-form-mode from lisp-data-mode Date: Sat, 06 Jun 2020 21:06:10 +0100 Message-ID: <87r1usq7rh.fsf@tcd.ie> References: <87wo4kroaf.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="52856"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 41742@debbugs.gnu.org To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 06 22:07:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jhf5y-000Dbh-NJ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Jun 2020 22:07:10 +0200 Original-Received: from localhost ([::1]:58046 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhf5x-0004xL-Ic for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Jun 2020 16:07:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46108) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhf5q-0004x8-5P for bug-gnu-emacs@gnu.org; Sat, 06 Jun 2020 16:07:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40998) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jhf5p-0006BD-Rf for bug-gnu-emacs@gnu.org; Sat, 06 Jun 2020 16:07:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jhf5p-0003LF-MS for bug-gnu-emacs@gnu.org; Sat, 06 Jun 2020 16:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Jun 2020 20:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41742 X-GNU-PR-Package: emacs Original-Received: via spool by 41742-submit@debbugs.gnu.org id=B41742.159147398112791 (code B ref 41742); Sat, 06 Jun 2020 20:07:01 +0000 Original-Received: (at 41742) by debbugs.gnu.org; 6 Jun 2020 20:06:21 +0000 Original-Received: from localhost ([127.0.0.1]:52544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhf5B-0003KF-9A for submit@debbugs.gnu.org; Sat, 06 Jun 2020 16:06:21 -0400 Original-Received: from mail-wr1-f52.google.com ([209.85.221.52]:34406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhf58-0003Jw-Ba for 41742@debbugs.gnu.org; Sat, 06 Jun 2020 16:06:20 -0400 Original-Received: by mail-wr1-f52.google.com with SMTP id r7so13292300wro.1 for <41742@debbugs.gnu.org>; Sat, 06 Jun 2020 13:06:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=rEVlDepisWSPE8jk2TS7ICnSGybRkhKnEV1ndj83/Ao=; b=OmZhSr0CdxgKFM97FE9yrBQlwiXhDT+Z2GXxFRfcy1sBEkUBKj4n4rmB1wTbg11LEI aoPp+xmM/sJJ8Lab/8DbyTtpeTZ5eBseHaZCENlmW++wBCiAmtWzeXvF28w3gA01o/y2 VTJW1PrgWbZisMlDnHdp2c5v62th9DeCe8gwOMjXq33LVmNqPjyv6PMyWl0LkOrEU9Y+ EGMJZn7ReG+1NSV0Q9xV7C8eb8aUYV/StHP6sBYj7R9MFiXrTxyYtUE051+fbDIQpCa/ GciNN9EsTMTasfqIPpfjCkSsQxxm+inXPcRuy6GZMoJVQLCm5nPVa9DmyBX3cWb92HhV BEmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=rEVlDepisWSPE8jk2TS7ICnSGybRkhKnEV1ndj83/Ao=; b=HzGhISDg52vYXKH4o0GlhJn3FbmIc7jrUCBp8zDxt0ttLuHvJFpLOvJnVeWU24dFGM SzFoMotMEd7wndaEWymoNRXwnaAk0+Emp5EmdKisy0sxioIFl2ckR5bd+KKeFDRe3fs3 Iz4E2HWswS/SFW1U0/7XN8Ab6hc80Wf924BuV8T98GVvFlK3nsJvDjlO++afJPcBSmH9 4VHOP13bxZCcMVYY/pvp+n0kMC1/NynLbK0Qy7hOTrnBHQDZrJvEy1l1phb06c6qpVKC GgK4DSOONc4fHzwEIRGX7cpWnB9yqMv6lbp09EGBTyPgruj6Ul3j6uWLyILesY6MfxQW lkVw== X-Gm-Message-State: AOAM530WovyZhs7x4seuzX9pihfonAeL9rwpTAfJdtoVWW9KUa83QGDG nCUQHHMwpnoxo7nd9z8RR5ySSw== X-Google-Smtp-Source: ABdhPJzI9LCSmm906wNY1yU7BBnWY7B5wZNgvEejdRkTEG4kHF460980VCf31TsWFVkSYsRpqec+0g== X-Received: by 2002:adf:9163:: with SMTP id j90mr15407389wrj.65.1591473972560; Sat, 06 Jun 2020 13:06:12 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id w15sm16684467wmk.30.2020.06.06.13.06.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jun 2020 13:06:11 -0700 (PDT) In-Reply-To: <87wo4kroaf.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sat, 06 Jun 2020 12:23:52 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181634 Archived-At: Eric Abrahamsen writes: > Hopefully this is fairly uncontroversial: Gnus has a gnus-edit-form-mode > for editing group parameters and other things, which presents the data > as elisp forms and is a perfect use-case for lisp-data-mode -- turning > on paredit or what have you. This patch derives the former from the > latter. LGTM, FWIW. While there, would you mind cleaning up how gnus-edit-form-mode-map is defined? It currently does a defvar+unless+setq dance, whereas it should ideally only be a defvar+let, as per the last few paragraphs of (info "(elisp) Tips for Defining"). Thanks, -- Basil