From: Lars Ingebrigtsen <larsi@gnus.org>
To: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
Cc: 37473@debbugs.gnu.org
Subject: bug#37473: 27.0.50; antialias setting is not preserved by inheriting
Date: Fri, 20 May 2022 12:42:42 +0200 [thread overview]
Message-ID: <87r14o4h99.fsf@gnus.org> (raw)
In-Reply-To: <wl36gq9t7a.wl-mituharu@math.s.chiba-u.ac.jp> (YAMAMOTO Mitsuharu's message of "Sat, 21 Sep 2019 13:19:53 +0900")
YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> writes:
> 1. % emacs -Q -fn monospace:antialias=0 &
>
> As expected, the normal text in the *scratch* buffer is not
> antialiased. But the bold text in the mode line is unexpectedly
> antialiased.
>
> 2. C-x C-+
>
> Observe that the scaled text in the *scratch* buffer is
> unexpectedly antialiased.
I can reproduce this in Emacs 29, too, and
diff --git a/src/xfaces.c b/src/xfaces.c
index 7395ce157e..1939a73d5e 100644
--- a/src/xfaces.c
+++ b/src/xfaces.c
@@ -5950,7 +5950,7 @@ realize_gui_face (struct face_cache *cache, Lisp_Object attrs[LFACE_VECTOR_SIZE]
}
if (! FONT_OBJECT_P (attrs[LFACE_FONT_INDEX]))
attrs[LFACE_FONT_INDEX]
- = font_load_for_lface (f, attrs, Ffont_spec (0, NULL));
+ = font_load_for_lface (f, attrs, attrs[LFACE_FONT_INDEX]);
if (FONT_OBJECT_P (attrs[LFACE_FONT_INDEX]))
{
face->font = XFONT_OBJECT (attrs[LFACE_FONT_INDEX]);
Fixes the issue. But that would bring bug#17973 back, I think.
What we want to happen here is, I think, that we want the "initial" font
spec (which would here just be family monospace + antialias, and not the
entire font spec that we initially realised? I think?
Is it immediately obvious to somebody how to achieve that here?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2022-05-20 10:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-21 4:19 bug#37473: 27.0.50; antialias setting is not preserved by inheriting YAMAMOTO Mitsuharu
2022-05-20 10:42 ` Lars Ingebrigtsen [this message]
2022-06-19 13:02 ` Lars Ingebrigtsen
2022-06-19 16:43 ` bug#37473: 27.0.50; antialias setting is not preserved by, inheriting David Ponce
2022-06-19 18:28 ` Colin Baxter
2022-06-19 19:14 ` Eli Zaretskii
2022-06-19 22:47 ` Lars Ingebrigtsen
2022-06-20 0:49 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-20 11:57 ` Eli Zaretskii
2022-06-20 12:04 ` Lars Ingebrigtsen
2022-06-20 12:11 ` Eli Zaretskii
2022-06-20 12:20 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-20 13:16 ` Eli Zaretskii
2022-06-20 13:20 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-20 13:37 ` Eli Zaretskii
2022-06-20 14:11 ` Eli Zaretskii
2022-06-20 15:43 ` Lars Ingebrigtsen
2022-06-20 15:57 ` Eli Zaretskii
2022-06-30 6:17 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r14o4h99.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=37473@debbugs.gnu.org \
--cc=mituharu@math.s.chiba-u.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).