unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: David Ponce <da_vid@orange.fr>, Po Lu <luangruo@yahoo.com>
Cc: larsi@gnus.org, 37473@debbugs.gnu.org
Subject: bug#37473: 27.0.50; antialias setting is not preserved by, inheriting
Date: Sun, 19 Jun 2022 22:14:53 +0300	[thread overview]
Message-ID: <83k09cmpn6.fsf@gnu.org> (raw)
In-Reply-To: <466d6eb8-b02f-9e49-6c79-95c5fa3d7252@orange.fr> (message from David Ponce on Sun, 19 Jun 2022 18:43:33 +0200)

> Cc: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Sun, 19 Jun 2022 18:43:33 +0200
> From: David Ponce <da_vid@orange.fr>
> 
> The below related today's commit to xface.c breaks antialiasing:
> 
>  From b2d11d69dd49864874f8fe53669b4049e83bfce9 Mon Sep 17 00:00:00 2001
> From: Po Lu <luangruo@yahoo.com>
> Date: Sun, 19 Jun 2022 21:57:11 +0800
> Subject: More conservative fix for bug#37473
> 
> * src/xfaces.c (realize_gui_face): Add more conservative fix,
> since the last change makes C-x C-+ lead to weight weirdness on
> my machine.

FWIW, I understand neither that commit nor the one it attempted to
fix.

First, why is :antialiasing being singled out? won't the same happen
for any attribute in FONT_EXTRA_INDEX, like :hinting, :hintstyle, and
whatnot?

And if indeed the issue is with FONT_EXTRA_INDEX, then I'd first ask
why the right value is not in attrs[] in the first place?  Because if
it is there, why not just use it directly, instead of via Ffont_put?

And in addition, why does it make sense to reset foundry, family,
registry, and adstyle of the font in attrs[]? don't we want the same
font, for example, when resizing the text?

IOW, do we really understand the reason for bug#37473?  Not the commit
which introduced it, but the reason why :antialiasing is being reset
and doesn't appear in attrs[] and in the realized face?  If so, could
someone please spell that out?





  parent reply	other threads:[~2022-06-19 19:14 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-21  4:19 bug#37473: 27.0.50; antialias setting is not preserved by inheriting YAMAMOTO Mitsuharu
2022-05-20 10:42 ` Lars Ingebrigtsen
2022-06-19 13:02   ` Lars Ingebrigtsen
2022-06-19 16:43 ` bug#37473: 27.0.50; antialias setting is not preserved by, inheriting David Ponce
2022-06-19 18:28   ` Colin Baxter
2022-06-19 19:14   ` Eli Zaretskii [this message]
2022-06-19 22:47     ` Lars Ingebrigtsen
2022-06-20  0:49     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-20 11:57       ` Eli Zaretskii
2022-06-20 12:04         ` Lars Ingebrigtsen
2022-06-20 12:11           ` Eli Zaretskii
2022-06-20 12:20         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-20 13:16           ` Eli Zaretskii
2022-06-20 13:20             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-20 13:37               ` Eli Zaretskii
2022-06-20 14:11                 ` Eli Zaretskii
2022-06-20 15:43                   ` Lars Ingebrigtsen
2022-06-20 15:57                     ` Eli Zaretskii
2022-06-30  6:17                   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k09cmpn6.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=37473@debbugs.gnu.org \
    --cc=da_vid@orange.fr \
    --cc=larsi@gnus.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).