From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#37473: 27.0.50; antialias setting is not preserved by inheriting Date: Fri, 20 May 2022 12:42:42 +0200 Message-ID: <87r14o4h99.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14414"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 37473@debbugs.gnu.org To: YAMAMOTO Mitsuharu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 20 12:43:33 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ns06X-0003aA-4U for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 May 2022 12:43:33 +0200 Original-Received: from localhost ([::1]:48220 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ns06V-0000Vp-Py for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 May 2022 06:43:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ns062-0000Va-2a for bug-gnu-emacs@gnu.org; Fri, 20 May 2022 06:43:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43772) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ns061-0001Vc-QG for bug-gnu-emacs@gnu.org; Fri, 20 May 2022 06:43:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ns061-0001qh-JG for bug-gnu-emacs@gnu.org; Fri, 20 May 2022 06:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 May 2022 10:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37473 X-GNU-PR-Package: emacs Original-Received: via spool by 37473-submit@debbugs.gnu.org id=B37473.16530433767083 (code B ref 37473); Fri, 20 May 2022 10:43:01 +0000 Original-Received: (at 37473) by debbugs.gnu.org; 20 May 2022 10:42:56 +0000 Original-Received: from localhost ([127.0.0.1]:37666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ns05v-0001q9-RA for submit@debbugs.gnu.org; Fri, 20 May 2022 06:42:56 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:33252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ns05t-0001ps-DQ for 37473@debbugs.gnu.org; Fri, 20 May 2022 06:42:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RdTNJmDiXpf2jpjtZ4UU/O0v4Z5y/Cm5/MXRPnw1SJk=; b=SRKdZUSb2MGC3J+awrrsrpq36V Q6izDIBYMUuB/5iuMrQ7Vtm+5GM/w+D/ED8JQNTiKjZvIpWCj0DMUrwDUL5tJKhSX9WBsIuTZ+J1n eO97yIyNLlA9aE5k8mYUnz4OPJHtLg4ZAntkgu/meFMD2pSc1e4soTQdyUrwxiKLqhyg=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ns05j-0006h3-Bg; Fri, 20 May 2022 12:42:46 +0200 X-Now-Playing: Bel Kanto's _White-out conditions_: "Upland" In-Reply-To: (YAMAMOTO Mitsuharu's message of "Sat, 21 Sep 2019 13:19:53 +0900") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:232721 Archived-At: YAMAMOTO Mitsuharu writes: > 1. % emacs -Q -fn monospace:antialias=0 & > > As expected, the normal text in the *scratch* buffer is not > antialiased. But the bold text in the mode line is unexpectedly > antialiased. > > 2. C-x C-+ > > Observe that the scaled text in the *scratch* buffer is > unexpectedly antialiased. I can reproduce this in Emacs 29, too, and diff --git a/src/xfaces.c b/src/xfaces.c index 7395ce157e..1939a73d5e 100644 --- a/src/xfaces.c +++ b/src/xfaces.c @@ -5950,7 +5950,7 @@ realize_gui_face (struct face_cache *cache, Lisp_Object attrs[LFACE_VECTOR_SIZE] } if (! FONT_OBJECT_P (attrs[LFACE_FONT_INDEX])) attrs[LFACE_FONT_INDEX] - = font_load_for_lface (f, attrs, Ffont_spec (0, NULL)); + = font_load_for_lface (f, attrs, attrs[LFACE_FONT_INDEX]); if (FONT_OBJECT_P (attrs[LFACE_FONT_INDEX])) { face->font = XFONT_OBJECT (attrs[LFACE_FONT_INDEX]); Fixes the issue. But that would bring bug#17973 back, I think. What we want to happen here is, I think, that we want the "initial" font spec (which would here just be family monospace + antialias, and not the entire font spec that we initially realised? I think? Is it immediately obvious to somebody how to achieve that here? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no