From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Florian Rommel <mail@florommel.de>
Cc: 55588@debbugs.gnu.org
Subject: bug#55588: pgtk: child-frame-border-width cannot be set to nil
Date: Mon, 23 May 2022 12:18:39 +0800 [thread overview]
Message-ID: <87r14kq3ts.fsf@yahoo.com> (raw)
In-Reply-To: <65b11da33708e6da3989750bfdb59804b8e9be3d.camel@florommel.de> (Florian Rommel's message of "Mon, 23 May 2022 00:03:23 +0200")
Florian Rommel <mail@florommel.de> writes:
> In pgtk, child-frame-border-width is set to 0 by default, and it cannot
> be set to nil.
> According to the manual it should be possible for child-frame-border-
> width to be nil. In such cases, the value of internal-border-width is
> used as the border width (see 30.4.3.4 "Layout Parameters"; and
> function FRAME_INTERNAL_BORDER_WIDTH in frame.h).
>
> The problem causes missing child-frame borders for code that depends on
> this behavior (e.g., lsp-doc-ui in the lsp-ui package), and it will
> cause errors for code that tries to set child-frame-border-width to
> nil.
>
> The attached patch fixes this. It essentially replicates the respective
> behavior of xfns.c.
I remember there was a reason internal (and child frame) borders don't
work quite right in child frames on PGTK. That might've been fixed in
December, but I cannot remember.
Please let me look into this first.
next prev parent reply other threads:[~2022-05-23 4:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-22 22:03 bug#55588: pgtk: child-frame-border-width cannot be set to nil Florian Rommel
2022-05-23 4:18 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-05-23 5:31 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-23 9:38 ` Florian Rommel
2022-05-23 12:15 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-21 11:45 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r14kq3ts.fsf@yahoo.com \
--to=bug-gnu-emacs@gnu.org \
--cc=55588@debbugs.gnu.org \
--cc=luangruo@yahoo.com \
--cc=mail@florommel.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).