From: Florian Rommel <mail@florommel.de>
To: Po Lu <luangruo@yahoo.com>
Cc: 55588@debbugs.gnu.org
Subject: bug#55588: pgtk: child-frame-border-width cannot be set to nil
Date: Mon, 23 May 2022 11:38:41 +0200 [thread overview]
Message-ID: <61716e5f3300f26bc64028effc857735b53e31fa.camel@florommel.de> (raw)
In-Reply-To: <87leusq0fz.fsf@yahoo.com>
[-- Attachment #1: Type: text/plain, Size: 372 bytes --]
On Mon, 2022-05-23 at 13:31 +0800, Po Lu wrote:
> It was fixed in December. I installed a similar change along with
> some
> other fixes to child frames on PGTK, please test.
Thanks! Almost works.
I believe that the default value of child-frame-border-width should be
nil (that's the case for xfns and others), with this everything works
as expected for me.
[-- Attachment #2: 0001-pgtk-Set-child-frame-border-width-to-nil.patch --]
[-- Type: text/x-patch, Size: 895 bytes --]
From 329ddb7c4e27836cdf26b9d530eae4399c391dac Mon Sep 17 00:00:00 2001
From: Florian Rommel <mail@florommel.de>
Date: Mon, 23 May 2022 11:17:48 +0200
Subject: [PATCH] pgtk: Set child-frame-border-width to nil
* src/pgtkfns.c (x-create-frame)
Copyright-paperwork-exempt: yes
---
src/pgtkfns.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/pgtkfns.c b/src/pgtkfns.c
index b26709d90c..35e3c10589 100644
--- a/src/pgtkfns.c
+++ b/src/pgtkfns.c
@@ -1437,8 +1437,7 @@ This function is an internal primitive--use `make-frame' instead. */ )
}
- gui_default_parameter (f, parms, Qchild_frame_border_width,
- make_fixnum (0),
+ gui_default_parameter (f, parms, Qchild_frame_border_width, Qnil,
"childFrameBorderWidth", "childFrameBorderWidth",
RES_TYPE_NUMBER);
gui_default_parameter (f, parms, Qright_divider_width, make_fixnum (0),
--
2.36.1
next prev parent reply other threads:[~2022-05-23 9:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-22 22:03 bug#55588: pgtk: child-frame-border-width cannot be set to nil Florian Rommel
2022-05-23 4:18 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-23 5:31 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-23 9:38 ` Florian Rommel [this message]
2022-05-23 12:15 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-21 11:45 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61716e5f3300f26bc64028effc857735b53e31fa.camel@florommel.de \
--to=mail@florommel.de \
--cc=55588@debbugs.gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).