From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#55588: pgtk: child-frame-border-width cannot be set to nil Date: Mon, 23 May 2022 12:18:39 +0800 Message-ID: <87r14kq3ts.fsf@yahoo.com> References: <65b11da33708e6da3989750bfdb59804b8e9be3d.camel@florommel.de> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13833"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: 55588@debbugs.gnu.org To: Florian Rommel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 23 06:19:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nszXD-0003PC-St for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 23 May 2022 06:19:11 +0200 Original-Received: from localhost ([::1]:59226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nszXC-0000rJ-BI for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 23 May 2022 00:19:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34312) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nszX4-0000qv-Qa for bug-gnu-emacs@gnu.org; Mon, 23 May 2022 00:19:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52964) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nszX4-0007Yr-GT for bug-gnu-emacs@gnu.org; Mon, 23 May 2022 00:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nszX4-0002ic-9q for bug-gnu-emacs@gnu.org; Mon, 23 May 2022 00:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 May 2022 04:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55588 X-GNU-PR-Package: emacs Original-Received: via spool by 55588-submit@debbugs.gnu.org id=B55588.165327953410436 (code B ref 55588); Mon, 23 May 2022 04:19:02 +0000 Original-Received: (at 55588) by debbugs.gnu.org; 23 May 2022 04:18:54 +0000 Original-Received: from localhost ([127.0.0.1]:46861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nszWw-0002iG-I0 for submit@debbugs.gnu.org; Mon, 23 May 2022 00:18:54 -0400 Original-Received: from sonic314-22.consmr.mail.ne1.yahoo.com ([66.163.189.148]:35676) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nszWu-0002hz-8E for 55588@debbugs.gnu.org; Mon, 23 May 2022 00:18:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1653279526; bh=jyKMNTBXhX/hwdirUkaCEw+xqeZ5SzcT/lW6hWfUFPk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=BC6riyicQvuaBKt78XC2En1lmDSdlcZw5N7t0W5Qzb4/Y0APem1+twTxqSNpDRtjJfST3CCnVCzlopZAJ0oH3TToeuardHhG1D2Ye7zLQ9fFsFbOgns+ps6YpinwzxfTaNDzt1o6hFaMnWYUQc0lMltDZPhmfWoC+YRHf8WM6YD20Vo3UoJed+PBmAMWY4IFO+oEzwRCIkOVpVjsCRhjVAc4YRQWNPsgcFzlp6iJ2EvQCyWklxdAZQzRIwWyro/XE4Dt1E86xEXO/ttGJmjN88gmJJ0+fmz9LfFISVvpMI2qZXCl5pgXJ5qfxpm9m7uEAOjy52dqa071zGkzzeWXow== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1653279526; bh=EP0BlVIgQHr9/VX4137hIhTUygAOAMA3lJz3ACzBTMJ=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=U7/86w5bM2ikC8VMMFacL811pj5UCsZwMAnK658GuUpSQLy1fZ8TSwOVkNOpPEYV9HoRqgeOoh/8MUKoQX7Rg993geQzrVsF7Bl9ROWo1fFpOgRtvHdzEm6/uypd94HYR36yY71ewcvcty+CM4h+aLSzvCssE6XXTsXTREOY2AWDUdR6BA9pd/KMZYTGoIIuSeMLuzo0gfcO7OdZz7GF0djKuMUNy6kd+VswebEfsVNlfslX3Ayu05o+usME7o4kS/t3jula6/GzYRrU/o4rh+3ap78FYxRDQ+aCq4y40aI+WFWQWodYTpDqsM5VWDZLR2wAv0kng8j5Sq5NmrFe/w== X-YMail-OSG: HzoKbYAVM1lgRUfnAW6t11TNuyiHyYPYxoi_d2aJVXitdWDSJkaOnIvYtrZtPaU vt_51.MY6OLx4298Suy8kMpIZxM70IdJACyubZW9wnB_tCW3N6dhtpwtprWwYsmhsjYkTpDLyO_y NQlFi7oY3OvY6LmAsAYxmu6FHCPbVXWHEK9gpsWGuV5i7Z7e34sxKKK.rbK3xUwYLiT0I2x90_Lr zS5T3bygl0fZXY6vvUc5ykHI4HzqMvdlxrBiKozp9.cOJVLIkCRDbYXM7BiqdZAT_2wWeBcEKwjO On2fEPLLguOJ.YV_tyQMj94h.MAS2a7T58iG5u3slVfb4h11.LN9dfnGgaiPrG.qScKgValgIlQB iKHv0omz5gf51SYOPf28pi8j2WLTefI2TzYQHVdtntSXcCfNqoVvO5of_wz8vtAakP.MubxHHndq oO3M790K0ayj9Yj5E.dhMC8HAvYzHvr2RtwGUFc7Kysqrd5lzbdX3jQ6189hdn958alEJbC.ZSqS VAWuAAMt8fzwdhoAWjxGQ9bFmCe5Yibmuckck.py2eQqhEAGlFVzQ_iaGvoisMFGBYGNSpZMebzH Y9OV1vSPmCFMPnznhRQj03khsFBBqXWXrp.DiVJLViG5j5V8H4YGT0KAHLvRpcsHUzOFxCWiiHhi TI96ugDWOGKcoaQjMyxerfPF1XAS3lFj2HczBPAb3B9T7teg7iNXQBwQqZ4Bos0_0YA3MltDeWWC Aq27fCMwhr.zal4hnI3xQC9o1welKoiNDd.PTW5m04okcF3_YUtwlKrIlb562Ftkw7BObjYncvat J.IFjdhmYC1nK1Scl64QlZAgOCmvzoWiP97ifHxgBD X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ne1.yahoo.com with HTTP; Mon, 23 May 2022 04:18:46 +0000 Original-Received: by hermes--canary-production-sg3-7959d4d9bd-lwwxg (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 71833acde37b6afae0f391504e77120e; Mon, 23 May 2022 04:18:43 +0000 (UTC) In-Reply-To: <65b11da33708e6da3989750bfdb59804b8e9be3d.camel@florommel.de> (Florian Rommel's message of "Mon, 23 May 2022 00:03:23 +0200") X-Mailer: WebService/1.1.20225 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:232929 Archived-At: Florian Rommel writes: > In pgtk, child-frame-border-width is set to 0 by default, and it cannot > be set to nil. > According to the manual it should be possible for child-frame-border- > width to be nil. In such cases, the value of internal-border-width is > used as the border width (see 30.4.3.4 "Layout Parameters"; and > function FRAME_INTERNAL_BORDER_WIDTH in frame.h). > > The problem causes missing child-frame borders for code that depends on > this behavior (e.g., lsp-doc-ui in the lsp-ui package), and it will > cause errors for code that tries to set child-frame-border-width to > nil. > > The attached patch fixes this. It essentially replicates the respective > behavior of xfns.c. I remember there was a reason internal (and child frame) borders don't work quite right in child frames on PGTK. That might've been fixed in December, but I cannot remember. Please let me look into this first.