* bug#58565: 29.0.50; ERTs for Python completion are not properly located
@ 2022-10-16 13:12 kobarity
2022-10-16 13:26 ` Lars Ingebrigtsen
0 siblings, 1 reply; 2+ messages in thread
From: kobarity @ 2022-10-16 13:12 UTC (permalink / raw)
To: 58565
[-- Attachment #1: Type: text/plain, Size: 283 bytes --]
Hello,
I'm afraid ERTs for Python completion in my patches #58389, #58441,
#58562, and #58548 were not properly located/named. Some of them
should be located in "Symbol completion" section, instead of "Shell
completion" section. Could you apply the attached patch?
Best Regards,
[-- Attachment #2: 0001-Move-and-rename-Python-completion-ERTs.patch --]
[-- Type: application/octet-stream, Size: 5899 bytes --]
From e23de7d63a690795e77f52ffb8dbf72765ab8be7 Mon Sep 17 00:00:00 2001
From: kobarity <kobarity@gmail.com>
Date: Sun, 16 Oct 2022 21:46:16 +0900
Subject: [PATCH] Move and rename Python completion ERTs
* test/lisp/progmodes/python-tests.el (python-shell-completion-at-point-1)
(python-shell-completion-at-point-native-1, python-completion-at-point-1)
(python-completion-at-point-2, python-completion-at-point-pdb-1)
(python-completion-at-point-native-1, python-completion-at-point-native-2)
(python-completion-at-point-native-with-ffap-1)
(python-completion-at-point-native-with-eldoc-1): Renamed tests.
---
test/lisp/progmodes/python-tests.el | 82 ++++++++++++++---------------
1 file changed, 41 insertions(+), 41 deletions(-)
diff --git a/test/lisp/progmodes/python-tests.el b/test/lisp/progmodes/python-tests.el
index 71bd0e0d68..81c9217c62 100644
--- a/test/lisp/progmodes/python-tests.el
+++ b/test/lisp/progmodes/python-tests.el
@@ -4396,7 +4396,41 @@ python-shell-completion-native-interpreter-disabled-p-1
(python-shell-interpreter "/some/path/to/bin/pypy"))
(should (python-shell-completion-native-interpreter-disabled-p))))
-(ert-deftest python-shell-completion-1 ()
+(ert-deftest python-shell-completion-at-point-1 ()
+ (skip-unless (executable-find python-tests-shell-interpreter))
+ (python-tests-with-temp-buffer-with-shell
+ ""
+ (python-shell-with-shell-buffer
+ (insert "import abc")
+ (comint-send-input)
+ (python-tests-shell-wait-for-prompt)
+ (insert "abc.")
+ (should (nth 2 (python-shell-completion-at-point)))
+ (end-of-line 0)
+ (should-not (nth 2 (python-shell-completion-at-point))))))
+
+(ert-deftest python-shell-completion-at-point-native-1 ()
+ (skip-unless (executable-find python-tests-shell-interpreter))
+ (python-tests-with-temp-buffer-with-shell
+ ""
+ (python-shell-completion-native-turn-on)
+ (python-shell-with-shell-buffer
+ (insert "import abc")
+ (comint-send-input)
+ (python-tests-shell-wait-for-prompt)
+ (insert "abc.")
+ (should (nth 2 (python-shell-completion-at-point)))
+ (end-of-line 0)
+ (should-not (nth 2 (python-shell-completion-at-point))))))
+
+
+\f
+;;; PDB Track integration
+
+\f
+;;; Symbol completion
+
+(ert-deftest python-completion-at-point-1 ()
(skip-unless (executable-find python-tests-shell-interpreter))
(python-tests-with-temp-buffer-with-shell
"
@@ -4411,7 +4445,7 @@ python-shell-completion-1
(insert "A")
(should (completion-at-point)))))
-(ert-deftest python-shell-completion-2 ()
+(ert-deftest python-completion-at-point-2 ()
"Should work regardless of the point in the Shell buffer."
(skip-unless (executable-find python-tests-shell-interpreter))
(python-tests-with-temp-buffer-with-shell
@@ -4427,7 +4461,7 @@ python-shell-completion-2
(insert "abc.")
(should (completion-at-point)))))
-(ert-deftest python-shell-completion-pdb-1 ()
+(ert-deftest python-completion-at-point-pdb-1 ()
"Should not complete PDB commands in Python buffer."
(skip-unless (executable-find python-tests-shell-interpreter))
(python-tests-with-temp-buffer-with-shell
@@ -4444,7 +4478,7 @@ python-shell-completion-pdb-1
(insert "u")
(should-not (nth 2 (python-completion-at-point))))))
-(ert-deftest python-shell-completion-native-1 ()
+(ert-deftest python-completion-at-point-native-1 ()
(skip-unless (executable-find python-tests-shell-interpreter))
(python-tests-with-temp-buffer-with-shell
"
@@ -4460,7 +4494,7 @@ python-shell-completion-native-1
(insert "A")
(should (completion-at-point)))))
-(ert-deftest python-shell-completion-native-2 ()
+(ert-deftest python-completion-at-point-native-2 ()
"Should work regardless of the point in the Shell buffer."
(skip-unless (executable-find python-tests-shell-interpreter))
(python-tests-with-temp-buffer-with-shell
@@ -4477,7 +4511,7 @@ python-shell-completion-native-2
(insert "abc.")
(should (completion-at-point)))))
-(ert-deftest python-shell-completion-native-with-ffap-1 ()
+(ert-deftest python-completion-at-point-native-with-ffap-1 ()
(skip-unless (executable-find python-tests-shell-interpreter))
(python-tests-with-temp-buffer-with-shell
"
@@ -4493,7 +4527,7 @@ python-shell-completion-native-with-ffap-1
(python-ffap-module-path "abc.")
(should (completion-at-point)))))
-(ert-deftest python-shell-completion-native-with-eldoc-1 ()
+(ert-deftest python-completion-at-point-native-with-eldoc-1 ()
(skip-unless (executable-find python-tests-shell-interpreter))
(python-tests-with-temp-buffer-with-shell
"
@@ -4509,40 +4543,6 @@ python-shell-completion-native-with-eldoc-1
(python-eldoc-function)
(should (completion-at-point)))))
-(ert-deftest python-shell-completion-shell-buffer-1 ()
- (skip-unless (executable-find python-tests-shell-interpreter))
- (python-tests-with-temp-buffer-with-shell
- ""
- (python-shell-with-shell-buffer
- (insert "import abc")
- (comint-send-input)
- (python-tests-shell-wait-for-prompt)
- (insert "abc.")
- (should (nth 2 (python-shell-completion-at-point)))
- (end-of-line 0)
- (should-not (nth 2 (python-shell-completion-at-point))))))
-
-(ert-deftest python-shell-completion-shell-buffer-native-1 ()
- (skip-unless (executable-find python-tests-shell-interpreter))
- (python-tests-with-temp-buffer-with-shell
- ""
- (python-shell-completion-native-turn-on)
- (python-shell-with-shell-buffer
- (insert "import abc")
- (comint-send-input)
- (python-tests-shell-wait-for-prompt)
- (insert "abc.")
- (should (nth 2 (python-shell-completion-at-point)))
- (end-of-line 0)
- (should-not (nth 2 (python-shell-completion-at-point))))))
-
-
-\f
-;;; PDB Track integration
-
-\f
-;;; Symbol completion
-
\f
;;; Fill paragraph
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#58565: 29.0.50; ERTs for Python completion are not properly located
2022-10-16 13:12 bug#58565: 29.0.50; ERTs for Python completion are not properly located kobarity
@ 2022-10-16 13:26 ` Lars Ingebrigtsen
0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2022-10-16 13:26 UTC (permalink / raw)
To: kobarity; +Cc: 58565
kobarity <kobarity@gmail.com> writes:
> I'm afraid ERTs for Python completion in my patches #58389, #58441,
> #58562, and #58548 were not properly located/named. Some of them
> should be located in "Symbol completion" section, instead of "Shell
> completion" section. Could you apply the attached patch?
Pushed to Emacs 29 now.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-16 13:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-16 13:12 bug#58565: 29.0.50; ERTs for Python completion are not properly located kobarity
2022-10-16 13:26 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).