From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: kobarity Newsgroups: gmane.emacs.bugs Subject: bug#58565: 29.0.50; ERTs for Python completion are not properly located Date: Sun, 16 Oct 2022 22:12:12 +0900 Message-ID: Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: multipart/mixed; boundary="Multipart_Sun_Oct_16_22:12:12_2022-1" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13201"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) To: 58565@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 16 15:13:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ok3SE-0003J6-Cs for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Oct 2022 15:13:22 +0200 Original-Received: from localhost ([::1]:59864 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ok3SD-0000yd-2t for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Oct 2022 09:13:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51734) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ok3Ru-0000xH-KO for bug-gnu-emacs@gnu.org; Sun, 16 Oct 2022 09:13:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44564) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ok3Ru-0006ue-DF for bug-gnu-emacs@gnu.org; Sun, 16 Oct 2022 09:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ok3Ru-0007WV-5l for bug-gnu-emacs@gnu.org; Sun, 16 Oct 2022 09:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: kobarity Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Oct 2022 13:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 58565 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.166592596428889 (code B ref -1); Sun, 16 Oct 2022 13:13:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 16 Oct 2022 13:12:44 +0000 Original-Received: from localhost ([127.0.0.1]:43642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ok3Rc-0007Vt-By for submit@debbugs.gnu.org; Sun, 16 Oct 2022 09:12:44 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:49556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ok3RZ-0007Vk-Dg for submit@debbugs.gnu.org; Sun, 16 Oct 2022 09:12:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59034) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ok3RX-0000ja-3b for bug-gnu-emacs@gnu.org; Sun, 16 Oct 2022 09:12:39 -0400 Original-Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]:37726) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ok3RV-0006sl-Ka for bug-gnu-emacs@gnu.org; Sun, 16 Oct 2022 09:12:38 -0400 Original-Received: by mail-pj1-x1035.google.com with SMTP id p3-20020a17090a284300b0020a85fa3ffcso11966538pjf.2 for ; Sun, 16 Oct 2022 06:12:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:subject:to:from:message-id:date:from:to:cc :subject:date:message-id:reply-to; bh=WPE5Yx53IZ/ArnMvk9N8uWHGPajD/qRvYfgZ1oOAX08=; b=VcJwTNzhZ8TEayXwAeDFR3mcmMLyBWXQFU8h1OCnbYPCNXnP2YvqFau2w2ZmDk8hnb YzRk0XFuh9wAt7Rz5SA0uy+Y6ATt0Nb1DQii74hMbgHwP8wUxDfFbWbC4LkqtEfga9SU ti34B5QYMbSj/CSyEYp42zIKuTI0SgJUvPw7l8DByTVk0Wk4ziKhA0OZZThtXSvYkLQl ZCFVEieXif7bN47h1TFvW7KGanLF6Sbsqo0DTX5w9mEA3IqBcKGEdLe3uqtUdf//QfEW cTM9guOgbdxzUUsGP1yGhBeAi2UkuFTC8KaijCzyiRK9lojjZBkMWg5KX2nbTSdnoQTr 8SWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:subject:to:from:message-id:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WPE5Yx53IZ/ArnMvk9N8uWHGPajD/qRvYfgZ1oOAX08=; b=xfQeIO7ihLemmTbn94b9OhqsGFNP2sCuM4UyI4GZumxdprt/sH1CfozVjvdUtvB0cf Fube1maqMkP1xxP37DspoBYdXKWL3daLiZ59xnSHqz4sa7WO34U8xicA1ql0MimUS8yN rUsRczQo4Qf03ROxLAvrQDydyfpXnvgzbQmY2lPIj1PgYGqbLuPHjxNbpHBkoiuUouxW D1PP3av9day/KtKFP5L/2uAm65kPwFKYpKl+9UD87DoWkVrXp5/eEMdk4wGRowo57J/5 j3T7BsZFKrQifmpClBmvpw6Qmf+vAVxI0KyWj+av23lHBZA0jqegJyZW9XJnMOskf0Wb L3iw== X-Gm-Message-State: ACrzQf3fc6DieJNWp6VcaDjoNUaSLTm48dj1YpKGF/S7yAHCAwoybdGt gtzHwORsaAWkyQHASSl0vBzEDB9jzPk= X-Google-Smtp-Source: AMsMyM6/f84OBlGQUYSZGcQJYMoeLqgrEZQbvN9oDHmjQuQLs45STWvjM/GuP1aHyBYjbrLW95LPIQ== X-Received: by 2002:a17:902:f643:b0:185:50e4:f55e with SMTP id m3-20020a170902f64300b0018550e4f55emr1303449plg.156.1665925954152; Sun, 16 Oct 2022 06:12:34 -0700 (PDT) Original-Received: from localhost (58x12x133x161.ap58.ftth.ucom.ne.jp. [58.12.133.161]) by smtp.gmail.com with ESMTPSA id i34-20020a632222000000b0045913a96837sm4521321pgi.24.2022.10.16.06.12.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Oct 2022 06:12:33 -0700 (PDT) Received-SPF: pass client-ip=2607:f8b0:4864:20::1035; envelope-from=kobarity@gmail.com; helo=mail-pj1-x1035.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245643 Archived-At: --Multipart_Sun_Oct_16_22:12:12_2022-1 Content-Type: text/plain; charset=US-ASCII Hello, I'm afraid ERTs for Python completion in my patches #58389, #58441, #58562, and #58548 were not properly located/named. Some of them should be located in "Symbol completion" section, instead of "Shell completion" section. Could you apply the attached patch? Best Regards, --Multipart_Sun_Oct_16_22:12:12_2022-1 Content-Type: application/octet-stream; type=patch; name="0001-Move-and-rename-Python-completion-ERTs.patch" Content-Disposition: attachment; filename="0001-Move-and-rename-Python-completion-ERTs.patch" Content-Transfer-Encoding: 7bit >From e23de7d63a690795e77f52ffb8dbf72765ab8be7 Mon Sep 17 00:00:00 2001 From: kobarity Date: Sun, 16 Oct 2022 21:46:16 +0900 Subject: [PATCH] Move and rename Python completion ERTs * test/lisp/progmodes/python-tests.el (python-shell-completion-at-point-1) (python-shell-completion-at-point-native-1, python-completion-at-point-1) (python-completion-at-point-2, python-completion-at-point-pdb-1) (python-completion-at-point-native-1, python-completion-at-point-native-2) (python-completion-at-point-native-with-ffap-1) (python-completion-at-point-native-with-eldoc-1): Renamed tests. --- test/lisp/progmodes/python-tests.el | 82 ++++++++++++++--------------- 1 file changed, 41 insertions(+), 41 deletions(-) diff --git a/test/lisp/progmodes/python-tests.el b/test/lisp/progmodes/python-tests.el index 71bd0e0d68..81c9217c62 100644 --- a/test/lisp/progmodes/python-tests.el +++ b/test/lisp/progmodes/python-tests.el @@ -4396,7 +4396,41 @@ python-shell-completion-native-interpreter-disabled-p-1 (python-shell-interpreter "/some/path/to/bin/pypy")) (should (python-shell-completion-native-interpreter-disabled-p)))) -(ert-deftest python-shell-completion-1 () +(ert-deftest python-shell-completion-at-point-1 () + (skip-unless (executable-find python-tests-shell-interpreter)) + (python-tests-with-temp-buffer-with-shell + "" + (python-shell-with-shell-buffer + (insert "import abc") + (comint-send-input) + (python-tests-shell-wait-for-prompt) + (insert "abc.") + (should (nth 2 (python-shell-completion-at-point))) + (end-of-line 0) + (should-not (nth 2 (python-shell-completion-at-point)))))) + +(ert-deftest python-shell-completion-at-point-native-1 () + (skip-unless (executable-find python-tests-shell-interpreter)) + (python-tests-with-temp-buffer-with-shell + "" + (python-shell-completion-native-turn-on) + (python-shell-with-shell-buffer + (insert "import abc") + (comint-send-input) + (python-tests-shell-wait-for-prompt) + (insert "abc.") + (should (nth 2 (python-shell-completion-at-point))) + (end-of-line 0) + (should-not (nth 2 (python-shell-completion-at-point)))))) + + + +;;; PDB Track integration + + +;;; Symbol completion + +(ert-deftest python-completion-at-point-1 () (skip-unless (executable-find python-tests-shell-interpreter)) (python-tests-with-temp-buffer-with-shell " @@ -4411,7 +4445,7 @@ python-shell-completion-1 (insert "A") (should (completion-at-point))))) -(ert-deftest python-shell-completion-2 () +(ert-deftest python-completion-at-point-2 () "Should work regardless of the point in the Shell buffer." (skip-unless (executable-find python-tests-shell-interpreter)) (python-tests-with-temp-buffer-with-shell @@ -4427,7 +4461,7 @@ python-shell-completion-2 (insert "abc.") (should (completion-at-point))))) -(ert-deftest python-shell-completion-pdb-1 () +(ert-deftest python-completion-at-point-pdb-1 () "Should not complete PDB commands in Python buffer." (skip-unless (executable-find python-tests-shell-interpreter)) (python-tests-with-temp-buffer-with-shell @@ -4444,7 +4478,7 @@ python-shell-completion-pdb-1 (insert "u") (should-not (nth 2 (python-completion-at-point)))))) -(ert-deftest python-shell-completion-native-1 () +(ert-deftest python-completion-at-point-native-1 () (skip-unless (executable-find python-tests-shell-interpreter)) (python-tests-with-temp-buffer-with-shell " @@ -4460,7 +4494,7 @@ python-shell-completion-native-1 (insert "A") (should (completion-at-point))))) -(ert-deftest python-shell-completion-native-2 () +(ert-deftest python-completion-at-point-native-2 () "Should work regardless of the point in the Shell buffer." (skip-unless (executable-find python-tests-shell-interpreter)) (python-tests-with-temp-buffer-with-shell @@ -4477,7 +4511,7 @@ python-shell-completion-native-2 (insert "abc.") (should (completion-at-point))))) -(ert-deftest python-shell-completion-native-with-ffap-1 () +(ert-deftest python-completion-at-point-native-with-ffap-1 () (skip-unless (executable-find python-tests-shell-interpreter)) (python-tests-with-temp-buffer-with-shell " @@ -4493,7 +4527,7 @@ python-shell-completion-native-with-ffap-1 (python-ffap-module-path "abc.") (should (completion-at-point))))) -(ert-deftest python-shell-completion-native-with-eldoc-1 () +(ert-deftest python-completion-at-point-native-with-eldoc-1 () (skip-unless (executable-find python-tests-shell-interpreter)) (python-tests-with-temp-buffer-with-shell " @@ -4509,40 +4543,6 @@ python-shell-completion-native-with-eldoc-1 (python-eldoc-function) (should (completion-at-point))))) -(ert-deftest python-shell-completion-shell-buffer-1 () - (skip-unless (executable-find python-tests-shell-interpreter)) - (python-tests-with-temp-buffer-with-shell - "" - (python-shell-with-shell-buffer - (insert "import abc") - (comint-send-input) - (python-tests-shell-wait-for-prompt) - (insert "abc.") - (should (nth 2 (python-shell-completion-at-point))) - (end-of-line 0) - (should-not (nth 2 (python-shell-completion-at-point)))))) - -(ert-deftest python-shell-completion-shell-buffer-native-1 () - (skip-unless (executable-find python-tests-shell-interpreter)) - (python-tests-with-temp-buffer-with-shell - "" - (python-shell-completion-native-turn-on) - (python-shell-with-shell-buffer - (insert "import abc") - (comint-send-input) - (python-tests-shell-wait-for-prompt) - (insert "abc.") - (should (nth 2 (python-shell-completion-at-point))) - (end-of-line 0) - (should-not (nth 2 (python-shell-completion-at-point)))))) - - - -;;; PDB Track integration - - -;;; Symbol completion - ;;; Fill paragraph -- 2.34.1 --Multipart_Sun_Oct_16_22:12:12_2022-1--