From: Tassilo Horn <tsdh@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Eshel Yaron <me@eshelyaron.com>, 65762@debbugs.gnu.org
Subject: bug#65762: [PATCH] ; Fix error in 'tex-recenter-output-buffer'
Date: Wed, 06 Sep 2023 13:03:26 +0200 [thread overview]
Message-ID: <87r0nba782.fsf@gnu.org> (raw)
In-Reply-To: <83v8cn36yg.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
Hi Eshel & Eli,
>> This fixes an issue in `tex-recenter-output-buffer` (which affect
>> several other commands that rely on it) where it calls
>> `display-buffer` and tries to select the returned window, without
>> checking that `display-buffer` returned non-nil. This leads to an
>> error when `display-tex-shell-buffer-action` or
>> `display-buffer-alist` are configured to prevent the display of the
>> *tex-shell* buffer.
>
> Thanks. Tassilo, any comments?
Yes, looks right in cases where display-tex-shell-buffer-action is
display-buffer-no-window or maybe something similar is achieved by
display-buffer-alist which would lead to errors right now. But I'm no
authority here, tex-mode.el is not tex.el (from auctex).
Bye,
Tassilo
next prev parent reply other threads:[~2023-09-06 11:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 17:12 bug#65762: [PATCH] ; Fix error in 'tex-recenter-output-buffer' Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-06 10:57 ` Eli Zaretskii
2023-09-06 11:03 ` Tassilo Horn [this message]
2023-09-06 12:27 ` Eli Zaretskii
2023-09-06 16:21 ` martin rudalics
2023-09-06 16:39 ` Eli Zaretskii
2023-09-06 16:51 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0nba782.fsf@gnu.org \
--to=tsdh@gnu.org \
--cc=65762@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=me@eshelyaron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).