From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: 65762@debbugs.gnu.org
Subject: bug#65762: [PATCH] ; Fix error in 'tex-recenter-output-buffer'
Date: Tue, 05 Sep 2023 19:12:41 +0200 [thread overview]
Message-ID: <m1a5u0bl2u.fsf@eshelyaron.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 404 bytes --]
Tags: patch
This fixes an issue in `tex-recenter-output-buffer` (which affect
several other commands that rely on it) where it calls `display-buffer`
and tries to select the returned window, without checking that
`display-buffer` returned non-nil. This leads to an error when
`display-tex-shell-buffer-action` or `display-buffer-alist` are
configured to prevent the display of the *tex-shell* buffer.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-error-in-tex-recenter-output-buffer.patch --]
[-- Type: text/patch, Size: 1666 bytes --]
From fb27907c07cf124773c1ae7add4a26be8ce02bbd Mon Sep 17 00:00:00 2001
From: Eshel Yaron <me@eshelyaron.com>
Date: Tue, 5 Sep 2023 18:58:02 +0200
Subject: [PATCH] ; Fix error in 'tex-recenter-output-buffer'
* lisp/textmodes/tex-mode.el (tex-recenter-output-buffer): Check that
'display-buffer' returned a window, rather than nil, before selecting it.
---
lisp/textmodes/tex-mode.el | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/lisp/textmodes/tex-mode.el b/lisp/textmodes/tex-mode.el
index 41c4a6a1373..a26e7b9c83a 100644
--- a/lisp/textmodes/tex-mode.el
+++ b/lisp/textmodes/tex-mode.el
@@ -2673,17 +2673,17 @@ tex-recenter-output-buffer
The last line of the buffer is displayed on
line LINE of the window, or centered if LINE is nil."
(interactive "P")
- (let ((tex-shell (get-buffer "*tex-shell*"))
- (window))
+ (let ((tex-shell (get-buffer "*tex-shell*")))
(if (null tex-shell)
(message "No TeX output buffer")
- (setq window (display-buffer tex-shell display-tex-shell-buffer-action))
- (with-selected-window window
- (bury-buffer tex-shell)
- (goto-char (point-max))
- (recenter (if linenum
- (prefix-numeric-value linenum)
- (/ (window-height) 2)))))))
+ (when-let ((window
+ (display-buffer tex-shell display-tex-shell-buffer-action)))
+ (with-selected-window window
+ (bury-buffer tex-shell)
+ (goto-char (point-max))
+ (recenter (if linenum
+ (prefix-numeric-value linenum)
+ (/ (window-height) 2))))))))
(defcustom tex-print-file-extension ".dvi"
"The TeX-compiled file extension for viewing and printing.
--
2.42.0
next reply other threads:[~2023-09-05 17:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 17:12 Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-09-06 10:57 ` bug#65762: [PATCH] ; Fix error in 'tex-recenter-output-buffer' Eli Zaretskii
2023-09-06 11:03 ` Tassilo Horn
2023-09-06 12:27 ` Eli Zaretskii
2023-09-06 16:21 ` martin rudalics
2023-09-06 16:39 ` Eli Zaretskii
2023-09-06 16:51 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1a5u0bl2u.fsf@eshelyaron.com \
--to=bug-gnu-emacs@gnu.org \
--cc=65762@debbugs.gnu.org \
--cc=me@eshelyaron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).