From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#65762: [PATCH] ; Fix error in 'tex-recenter-output-buffer' Date: Wed, 06 Sep 2023 13:03:26 +0200 Message-ID: <87r0nba782.fsf@gnu.org> References: <83v8cn36yg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13479"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.11.17; emacs 30.0.50 Cc: Eshel Yaron , 65762@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 06 13:10:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qdqQE-0003Dl-9U for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Sep 2023 13:10:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdqQ9-0006cl-Gp; Wed, 06 Sep 2023 07:10:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdqQ6-0006YQ-EV for bug-gnu-emacs@gnu.org; Wed, 06 Sep 2023 07:10:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdqQ6-00042G-4N for bug-gnu-emacs@gnu.org; Wed, 06 Sep 2023 07:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qdqQ7-0003nn-45 for bug-gnu-emacs@gnu.org; Wed, 06 Sep 2023 07:10:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Sep 2023 11:10:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65762 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65762-submit@debbugs.gnu.org id=B65762.169399859914587 (code B ref 65762); Wed, 06 Sep 2023 11:10:03 +0000 Original-Received: (at 65762) by debbugs.gnu.org; 6 Sep 2023 11:09:59 +0000 Original-Received: from localhost ([127.0.0.1]:33105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdqQ3-0003nC-Eq for submit@debbugs.gnu.org; Wed, 06 Sep 2023 07:09:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdqQ2-0003mx-Bb for 65762@debbugs.gnu.org; Wed, 06 Sep 2023 07:09:58 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdqPv-00040v-R8; Wed, 06 Sep 2023 07:09:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-reply-to:Date:Subject:To:From: References; bh=ofUHtJDBxnZ/4vWq7zFqek50w8mGMta6+O0BGXSJqrQ=; b=aIAbaI0OKqriEY oLQKfQhbhtHXG9IDPdaQxuuS6TOgLT3bQYY7KZCKI+UammMFQ1oevTucYEzjkmxoKc0dUxQfj7iT8 M1Br4GaJUmzfFn3db+ajD3ZgBIE+gAF2qlIl4Xyzcym34eb24GLUwKkVX7KC7AKqFuKk2LTZlGUdr yBkiRrqaT9HNT2AjPEQ5zYfO6HwnBWQHUIgpIY/uiS7oLgRUm4QOSiO6tIuDusNcoSKlFPuyhlBfR SYE8OERq4rEdOho5LbS1u8hHdmrby6jg00QBIbpmmO+auGu+8DMfJ84DtFzjGfEi1At2fJ9A4xMCw KL5Y+jD1xOHN8sApQ0oA==; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudehfedgfeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvvefuffgjkfggtgesthdtredttdertdenucfhrhhomhepvfgrshhs ihhlohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenucggtffrrghtthgvrhhnpe dujedtheduvdelffejkeetgedvheelhedvueefhfeukeekkeehvdfggeegffevgfenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhorhhnod hmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdekieejfeekjeekgedqieefhedv leekqdhtshguhheppehgnhhurdhorhhgsehfrghsthhmrghilhdrfhhm X-ME-Proxy: Feedback-ID: ib2b94485:Fastmail In-reply-to: <83v8cn36yg.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269507 Archived-At: Eli Zaretskii writes: Hi Eshel & Eli, >> This fixes an issue in `tex-recenter-output-buffer` (which affect >> several other commands that rely on it) where it calls >> `display-buffer` and tries to select the returned window, without >> checking that `display-buffer` returned non-nil. This leads to an >> error when `display-tex-shell-buffer-action` or >> `display-buffer-alist` are configured to prevent the display of the >> *tex-shell* buffer. > > Thanks. Tassilo, any comments? Yes, looks right in cases where display-tex-shell-buffer-action is display-buffer-no-window or maybe something similar is achieved by display-buffer-alist which would lead to errors right now. But I'm no authority here, tex-mode.el is not tex.el (from auctex). Bye, Tassilo