From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Stefan Kangas <stefan@marxist.se>
Cc: 35504@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>,
Rudi Schlatte <rudi@constantly.at>
Subject: bug#35504: 26.2; Key `g' should run `package-menu-refresh' in the *Packages* buffer
Date: Thu, 03 Oct 2019 02:53:54 +0100 [thread overview]
Message-ID: <87pnje8uh9.fsf@tcd.ie> (raw)
In-Reply-To: <CADwFkmn7aiMJtjPD+qvxzxHcVk7o1qHHrN1rQCSy3=F3Eavr5Q@mail.gmail.com> (Stefan Kangas's message of "Thu, 3 Oct 2019 01:59:25 +0200")
Stefan Kangas <stefan@marxist.se> writes:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>> > I also agree. How about the attached patch?
>>
>> Fine by me. I wonder, tho: why not set revert-buffer-function and then
>> redefine `package-menu-refresh` as an obsolete alias for `revert-buffer`?
>
> Sure, I've tried to do that in the attached patch. WDYT?
In addition to Stefan M.'s comments, I just noticed a couple of nits:
> -(defun package-menu-refresh ()
> +(defun package-menu-revert (&optional arg noconfirm)
If the arguments aren't used, they should be prefixed with underscores.
> "In Package Menu, download the Emacs Lisp package archive.
> Fetch the contents of each archive specified in
> `package-archives', and then refresh the package menu. Signal a
> -user-error if there is already a refresh running asynchronously."
> +user-error if there is already a refresh running asynchronously.
> +
> +`package-menu-mode' sets ‘revert-buffer-function’ to this
> +function. The args ARG and NOCONFIRM, passed from
> +‘revert-buffer’, are ignored."
revert-buffer-function and revert-buffer are quoted with curly single
quotes instead of the usual grave+apostrophe.
Thanks,
--
Basil
next prev parent reply other threads:[~2019-10-03 1:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 14:52 bug#35504: 26.2; Key `g' should run `package-menu-refresh' in the *Packages* buffer Rudi Schlatte
2019-04-30 15:47 ` Basil L. Contovounesios
2019-04-30 16:00 ` Rudi Schlatte
2019-04-30 16:59 ` Stefan Monnier
2019-09-14 19:21 ` Stefan Kangas
2019-09-16 18:12 ` Stefan Monnier
2019-10-02 23:59 ` Stefan Kangas
2019-10-03 1:47 ` Stefan Monnier
2019-10-04 15:09 ` Stefan Kangas
2019-11-02 2:32 ` Stefan Kangas
2019-11-06 0:00 ` Stefan Kangas
2019-10-03 1:53 ` Basil L. Contovounesios [this message]
2019-10-04 14:36 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnje8uh9.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=35504@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=rudi@constantly.at \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).