From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#35504: 26.2; Key `g' should run `package-menu-refresh' in the *Packages* buffer Date: Thu, 03 Oct 2019 02:53:54 +0100 Message-ID: <87pnje8uh9.fsf@tcd.ie> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="76813"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35504@debbugs.gnu.org, Stefan Monnier , Rudi Schlatte To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 03 03:55:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iFqKm-000JoO-JC for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Oct 2019 03:55:12 +0200 Original-Received: from localhost ([::1]:60566 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFqKk-0008Lz-W3 for geb-bug-gnu-emacs@m.gmane.org; Wed, 02 Oct 2019 21:55:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36686) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFqKd-0008Lj-DF for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2019 21:55:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFqKc-0002ZF-Ct for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2019 21:55:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58041) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iFqKc-0002Z4-3x for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2019 21:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iFqKc-00037D-0d for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2019 21:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Oct 2019 01:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35504 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35504-submit@debbugs.gnu.org id=B35504.157006764411886 (code B ref 35504); Thu, 03 Oct 2019 01:55:01 +0000 Original-Received: (at 35504) by debbugs.gnu.org; 3 Oct 2019 01:54:04 +0000 Original-Received: from localhost ([127.0.0.1]:38626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFqJg-00035e-4Y for submit@debbugs.gnu.org; Wed, 02 Oct 2019 21:54:04 -0400 Original-Received: from mail-wm1-f67.google.com ([209.85.128.67]:50924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFqJe-000350-Bc for 35504@debbugs.gnu.org; Wed, 02 Oct 2019 21:54:03 -0400 Original-Received: by mail-wm1-f67.google.com with SMTP id 5so781762wmg.0 for <35504@debbugs.gnu.org>; Wed, 02 Oct 2019 18:54:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=BaotlDb1DJ6o+hBQdQyXqp5SKFkgsAVImqTpLVCdW0s=; b=zy8rYsgxK4GPOoaOKTnxPcO2mLOUozR3CXLhbp+HFHUd28Gm/6CYu/Uh8fcXUYNYQS Acm2H2mTtMwd9DOidEJxOaFjM1gFZI+pK5MJZXMbCtMGDPrZ+xqI2NBYEEHL6MeXFHd9 NigpVJK5lQq91FNmQNAkfgjBgyTJ9ctZfczLadZMicQaGJZDBgUSnRftzve2D2vVLUQk omTKR2lc95ToPWDvgyH+MC1tj5Z2m99Xdb63VyFsVaFu9BT2SG++hEYP0o3y2t7hPe6S TWxWlGZJDPSg8WjMSNo0jGc/FWeeIHo/BMwaTfqfWQydbYvoU9OJ3oWe8P62Xk70ubeg W6CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=BaotlDb1DJ6o+hBQdQyXqp5SKFkgsAVImqTpLVCdW0s=; b=F4qz89CCwq0HnqAlej/8BZ0vcKrGSkE69UUBrCRvsfmSKIgswSAIsDeXODvsv6eZ0e LcVvNvdKufYPmE50ok0vMNsx5W2Lzt3VWsV40NerIRpt19VegPwW10cfxvUen72103bf dxhFo1pbL10okf+XtLPddBCK6m0Ryy5fFM46y49/mu2qMeEz9E2tpLrYUQ7+qvDiFTPK x5buwJzGoRHtuzD3AP5cqVFrydBlbYxJZfH+IwKzucQm7g7fg2ipcGfqaklnlb3y3Qv9 2V7+saJaeqa0X2wcL0FIDcI1B2r0HsQTysp4o9D1G2Bporb2M6VhXk84n13LrAaElGp0 NPYg== X-Gm-Message-State: APjAAAWz/vR2tFaj8HmI293iVdaPWsiqsSD37ruTRAJEC+KOVYPg1969 codUXr2cyClf6GiafHzBu8+3sA== X-Google-Smtp-Source: APXvYqyty2crm4jwDs+BsazmyzYk7ao76HRtm7m2OQYpPDCOZ3+mK+CO3587YoGu9uUKT3Cuc7xJJQ== X-Received: by 2002:a1c:a697:: with SMTP id p145mr4547789wme.24.1570067636288; Wed, 02 Oct 2019 18:53:56 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id l11sm903252wmh.34.2019.10.02.18.53.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Oct 2019 18:53:55 -0700 (PDT) In-Reply-To: (Stefan Kangas's message of "Thu, 3 Oct 2019 01:59:25 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168195 Archived-At: Stefan Kangas writes: > Stefan Monnier writes: > >> > I also agree. How about the attached patch? >> >> Fine by me. I wonder, tho: why not set revert-buffer-function and then >> redefine `package-menu-refresh` as an obsolete alias for `revert-buffer`? > > Sure, I've tried to do that in the attached patch. WDYT? In addition to Stefan M.'s comments, I just noticed a couple of nits: > -(defun package-menu-refresh () > +(defun package-menu-revert (&optional arg noconfirm) If the arguments aren't used, they should be prefixed with underscores. > "In Package Menu, download the Emacs Lisp package archive. > Fetch the contents of each archive specified in > `package-archives', and then refresh the package menu. Signal a > -user-error if there is already a refresh running asynchronously." > +user-error if there is already a refresh running asynchronously. > + > +`package-menu-mode' sets =E2=80=98revert-buffer-function=E2=80=99 to this > +function. The args ARG and NOCONFIRM, passed from > +=E2=80=98revert-buffer=E2=80=99, are ignored." revert-buffer-function and revert-buffer are quoted with curly single quotes instead of the usual grave+apostrophe. Thanks, --=20 Basil