From: Stefan Kangas <stefan@marxist.se>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 35504@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>,
Rudi Schlatte <rudi@constantly.at>
Subject: bug#35504: 26.2; Key `g' should run `package-menu-refresh' in the *Packages* buffer
Date: Fri, 4 Oct 2019 16:36:10 +0200 [thread overview]
Message-ID: <CADwFkm=k+EiUrsipqYrq9b2hO_100imQR3hFPA=RQct4YpkZnw@mail.gmail.com> (raw)
In-Reply-To: <87pnje8uh9.fsf@tcd.ie>
Basil L. Contovounesios <contovob@tcd.ie> writes:
> > -(defun package-menu-refresh ()
> > +(defun package-menu-revert (&optional arg noconfirm)
>
> If the arguments aren't used, they should be prefixed with underscores.
Indeed, fixed.
> > "In Package Menu, download the Emacs Lisp package archive.
> > Fetch the contents of each archive specified in
> > `package-archives', and then refresh the package menu. Signal a
> > -user-error if there is already a refresh running asynchronously."
> > +user-error if there is already a refresh running asynchronously.
> > +
> > +`package-menu-mode' sets ‘revert-buffer-function’ to this
> > +function. The args ARG and NOCONFIRM, passed from
> > +‘revert-buffer’, are ignored."
>
> revert-buffer-function and revert-buffer are quoted with curly single
> quotes instead of the usual grave+apostrophe.
Well spotted, fixed. Thanks for the review.
Best regards,
Stefan Kangas
prev parent reply other threads:[~2019-10-04 14:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 14:52 bug#35504: 26.2; Key `g' should run `package-menu-refresh' in the *Packages* buffer Rudi Schlatte
2019-04-30 15:47 ` Basil L. Contovounesios
2019-04-30 16:00 ` Rudi Schlatte
2019-04-30 16:59 ` Stefan Monnier
2019-09-14 19:21 ` Stefan Kangas
2019-09-16 18:12 ` Stefan Monnier
2019-10-02 23:59 ` Stefan Kangas
2019-10-03 1:47 ` Stefan Monnier
2019-10-04 15:09 ` Stefan Kangas
2019-11-02 2:32 ` Stefan Kangas
2019-11-06 0:00 ` Stefan Kangas
2019-10-03 1:53 ` Basil L. Contovounesios
2019-10-04 14:36 ` Stefan Kangas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkm=k+EiUrsipqYrq9b2hO_100imQR3hFPA=RQct4YpkZnw@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=35504@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=monnier@iro.umontreal.ca \
--cc=rudi@constantly.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).