From: Tino Calancha <tino.calancha@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: 46374@debbugs.gnu.org,
"Stefan Monnier" <monnier@iro.umontreal.ca>,
"Quách Mỹ Uyên Nhi" <uyennhi.qm@gmail.com>
Subject: bug#46374: 28.0.50; Ask me to save buffers only if they are under callers dir
Date: Sun, 21 Mar 2021 18:59:04 +0100 [thread overview]
Message-ID: <87pmzsgzh3.fsf@gmail.com> (raw)
In-Reply-To: <87blbhhghk.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 17 Mar 2021 19:10:15 +0200")
Juri Linkov <juri@linkov.net> writes:
>> How 'bout using something like `isearch-search-fun-function`:
>> i.e. *compute* the predicate by calling
>> save-some-buffers-predicate-function, so this function can return
>> a predicate that remembers the default-dir of the original buffer (or
>> any other aspect relevant to the state from which we started the
>> save-some-buffers).
>
> This should work. Then in save-some-buffers it's possible
> to add after the existing 2 lines:
>
> (unless pred
> (setq pred save-some-buffers-default-predicate))
>
> only 3 additional lines:
>
> (let ((pred-fun (and (functionp pred) (funcall pred))))
> (when (functionp pred-fun)
> (setq pred pred-fun)))
>
> Then a pred function could contain something like:
>
> (lambda ()
> (let ((project-dir (or (project-root (project-current)) default-directory)))
> (lambda () (file-in-directory-p default-directory project-dir))))
Thanks Juri and Stefan; it looks more general now.
I have noticed that I haven't enabled lexical-binding in my .emacs file,
which it is crucial for my use case.
To avoid surprises, I have mentioned this issue in the docstring.
--8<-----------------------------cut here---------------start------------->8---
diff --git a/lisp/files.el b/lisp/files.el
index dada69c145..e87fbe9599 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -5520,6 +5520,28 @@ save-some-buffers-default-predicate
:type '(choice (const :tag "Default" nil) function)
:version "26.1")
+(defvar save-some-buffers-fun-function (lambda () save-some-buffers-default-predicate)
+ "Overrides the behavior of `save-some-buffers-default-predicate'.
+This variable's value should be a function, which will be called
+by `save-some-buffers' with no arguments to override the default predicate.
+This allow you to capture variables in the environment of `save-some-buffers',
+and use them to decide which buffers must be saved.
+For instance, the following expression restricts to save only buffers inside
+the project from where `save-some-buffers' is invoked, or under the
+caller's `default-directory' if no project is found:
+
+\(lambda ()
+ (let ((project-dir
+ (or (and (project-current) (project-root (project-current)))
+ default-directory)))
+ (lambda () (file-in-directory-p default-directory project-dir))))
+
+Note that, the example above requires that you evaluate this expression
+in a file or buffer with lexical binding enabled.")
+
+(defun save-some-buffers-fun ()
+ (funcall save-some-buffers-fun-function))
+
(defun save-some-buffers (&optional arg pred)
"Save some modified file-visiting buffers. Asks user about each one.
You can answer `y' or SPC to save, `n' or DEL not to save, `C-r'
@@ -5547,8 +5569,17 @@ save-some-buffers
change the additional actions you can take on files."
(interactive "P")
(unless pred
- (setq pred save-some-buffers-default-predicate))
+ (setq pred (save-some-buffers-fun)))
+
--8<-----------------------------cut here---------------end--------------->8---
next prev parent reply other threads:[~2021-03-21 17:59 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-07 22:32 bug#46374: 28.0.50; Ask me to save buffers only if they are under callers dir Tino Calancha
2021-02-08 15:07 ` Eli Zaretskii
2021-02-08 15:47 ` Stefan Monnier
2021-02-09 17:50 ` Juri Linkov
2021-03-07 20:34 ` Tino Calancha
2021-03-07 21:08 ` Juri Linkov
[not found] ` <1952f2d9-51b6-a4ba-6c9e-98594222f017@gmail.com>
2021-03-08 17:28 ` Juri Linkov
2021-03-14 12:17 ` Tino Calancha
2021-03-15 17:10 ` Juri Linkov
2021-03-16 17:49 ` Juri Linkov
2021-03-16 22:54 ` Stefan Monnier
2021-03-16 23:37 ` bug#46374: [External] : " Drew Adams
2021-03-17 17:12 ` Juri Linkov
2021-03-17 17:10 ` Juri Linkov
2021-03-21 17:59 ` Tino Calancha [this message]
2021-03-21 20:10 ` Juri Linkov
2021-04-18 14:27 ` Tino Calancha
2021-04-24 22:13 ` Juri Linkov
2021-04-28 19:31 ` Tino Calancha
2021-04-28 19:51 ` Juri Linkov
2021-04-28 20:35 ` Tino Calancha
2021-04-29 9:17 ` Eli Zaretskii
2021-05-18 17:46 ` Tino Calancha
2021-04-29 16:04 ` Juri Linkov
[not found] ` <82abe5b9-7d42-b05d-26a5-fd63e1f59e3a@gmail.com>
2021-08-13 7:11 ` Juri Linkov
[not found] ` <3c7dc42a-e484-8068-d28d-49677f0b4a7@gmail.com>
2021-08-13 16:08 ` Juri Linkov
2021-04-29 9:16 ` Eli Zaretskii
2021-05-18 18:04 ` Tino Calancha
2021-05-18 18:23 ` Eli Zaretskii
2021-05-18 18:47 ` Tino Calancha
2021-08-28 16:25 ` bug#46374: Regression: erronous calls to PRED switch major-mode of unrelated modified buffers Hauke Rehfeld
2021-08-29 16:38 ` Juri Linkov
2021-08-30 7:28 ` Juri Linkov
2021-08-30 11:43 ` Hauke Rehfeld
2021-08-30 16:04 ` Hauke Rehfeld
2021-08-31 7:02 ` Juri Linkov
2021-09-05 10:09 ` bug#46374: 28.0.50; Ask me to save buffers only if they are under callers dir Tino Calancha
2021-09-05 16:21 ` Juri Linkov
2021-10-10 17:38 ` Juri Linkov
[not found] ` <jwv5yqwrgru.fsf-monnier+emacs@gnu.org>
2022-01-06 19:09 ` bug#46374: Regression: erronous calls to PRED switch major-mode of unrelated modified buffers Juri Linkov
2022-01-06 20:17 ` Eli Zaretskii
2022-01-06 20:28 ` Juri Linkov
2022-01-07 14:45 ` Eli Zaretskii
2022-01-10 3:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmzsgzh3.fsf@gmail.com \
--to=tino.calancha@gmail.com \
--cc=46374@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=monnier@iro.umontreal.ca \
--cc=uyennhi.qm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).