From: Tino Calancha <tino.calancha@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: 46374@debbugs.gnu.org,
"Stefan Monnier" <monnier@iro.umontreal.ca>,
"Quách Mỹ Uyên Nhi" <uyennhi.qm@gmail.com>
Subject: bug#46374: 28.0.50; Ask me to save buffers only if they are under callers dir
Date: Wed, 28 Apr 2021 21:31:25 +0200 [thread overview]
Message-ID: <87h7jq1a0i.fsf@gmail.com> (raw)
In-Reply-To: <87tunvnxfo.fsf@linkov.net> (Juri Linkov's message of "Sun, 25 Apr 2021 01:13:13 +0300")
Juri Linkov <juri@linkov.net> writes:
> Your first patch was better in terms of customizability.
> but its disadvantage was that it introduced a new defcustom.
>
> Would it be possible to merge the advantage of your first patch
> with the cleaner solution of your latest patch?
Good idea.
> Is it possible to add the default value as a function that returns nil?
> This will implement FIXME, and will allow adding more options
> with more predicates:
I have found a way to merge the two approaches. Not sure if
idiomatic, but it works.
[The patch omits NEWS entry and documentation; I will add those once we
found the implementation]
--8<-----------------------------cut here---------------start------------->8---
commit 3abcf022a1fb375f15df8438ebf0cf5b67082bbc
Author: Tino Calancha <ccalancha@suse.com>
Date: Wed Apr 28 21:18:28 2021 +0200
Merge the two approaches
* lisp/files (some-buffers-default-predicate):
Redefined; store a function that builds the actual predicate
used in save-some-buffers.
On top of commit 0c7f1e2e42d6bf9f95e88c02d4e1ed9cb40693d8
diff --git a/lisp/files.el b/lisp/files.el
index 8e8fbac8dc..707c6a77bc 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -5512,19 +5512,37 @@ save-some-buffers-action-alist
(defvar-local buffer-save-without-query nil
"Non-nil means `save-some-buffers' should save this buffer without asking.")
-(defcustom save-some-buffers-default-predicate nil
- "Default predicate for `save-some-buffers'.
+(defvar save-some-buffers-default-fun (lambda () nil))
-This allows you to stop `save-some-buffers' from asking
-about certain files that you'd usually rather not save.
+(defvar save-some-buffers-in-current-project-fun
+ (lambda ()
+ (let ((project-dir (or (and (project-current) (project-root (project-current)))
+ default-directory)))
+ (lambda () (file-in-directory-p default-directory project-dir)))))
-This function is called (with no parameters) from the buffer to
-be saved."
+(defcustom save-some-buffers-default-predicate save-some-buffers-default-fun
+ "Generator function of the default predicate for `save-some-buffers'.
+
+It must be a function with no arguments that returns a predicate.
+This predicate is called (with no parameters) from the buffer to be
+saved.
+
+This allows you to stop `save-some-buffers' from asking about certain
+files that you'd usually rather not save.
+
+The default value builds a predicate that prompts to save any modified
+file-visiting buffer. The second value restricts to buffers inside
+the project from where `save-some-buffers' is invoked, or under the
+caller's `default-directory' if no project is found."
:group 'auto-save
- ;; FIXME nil should not be a valid option, let alone the default,
- ;; eg so that add-function can be used.
- :type '(choice (const :tag "Default" nil) function)
- :version "26.1")
+ :type `(choice
+ (function :tag "All buffers" :value ,save-some-buffers-default-fun)
+ (function :tag "Buffers inside current project"
+ :value ,save-some-buffers-in-current-project-fun))
+ :version "28.1")
+
+(defun save-some-buffers-fun ()
+ (funcall save-some-buffers-default-predicate))
(defun save-some-buffers (&optional arg pred)
"Save some modified file-visiting buffers. Asks user about each one.
@@ -5553,7 +5571,8 @@ save-some-buffers
change the additional actions you can take on files."
(interactive "P")
(unless pred
- (setq pred save-some-buffers-default-predicate))
+ (setq pred (save-some-buffers-fun)))
+
(let* ((switched-buffer nil)
(save-some-buffers--switch-window-callback
(lambda (buffer)
--8<-----------------------------cut here---------------end--------------->8---
next prev parent reply other threads:[~2021-04-28 19:31 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-07 22:32 bug#46374: 28.0.50; Ask me to save buffers only if they are under callers dir Tino Calancha
2021-02-08 15:07 ` Eli Zaretskii
2021-02-08 15:47 ` Stefan Monnier
2021-02-09 17:50 ` Juri Linkov
2021-03-07 20:34 ` Tino Calancha
2021-03-07 21:08 ` Juri Linkov
[not found] ` <1952f2d9-51b6-a4ba-6c9e-98594222f017@gmail.com>
2021-03-08 17:28 ` Juri Linkov
2021-03-14 12:17 ` Tino Calancha
2021-03-15 17:10 ` Juri Linkov
2021-03-16 17:49 ` Juri Linkov
2021-03-16 22:54 ` Stefan Monnier
2021-03-16 23:37 ` bug#46374: [External] : " Drew Adams
2021-03-17 17:12 ` Juri Linkov
2021-03-17 17:10 ` Juri Linkov
2021-03-21 17:59 ` Tino Calancha
2021-03-21 20:10 ` Juri Linkov
2021-04-18 14:27 ` Tino Calancha
2021-04-24 22:13 ` Juri Linkov
2021-04-28 19:31 ` Tino Calancha [this message]
2021-04-28 19:51 ` Juri Linkov
2021-04-28 20:35 ` Tino Calancha
2021-04-29 9:17 ` Eli Zaretskii
2021-05-18 17:46 ` Tino Calancha
2021-04-29 16:04 ` Juri Linkov
[not found] ` <82abe5b9-7d42-b05d-26a5-fd63e1f59e3a@gmail.com>
2021-08-13 7:11 ` Juri Linkov
[not found] ` <3c7dc42a-e484-8068-d28d-49677f0b4a7@gmail.com>
2021-08-13 16:08 ` Juri Linkov
2021-04-29 9:16 ` Eli Zaretskii
2021-05-18 18:04 ` Tino Calancha
2021-05-18 18:23 ` Eli Zaretskii
2021-05-18 18:47 ` Tino Calancha
2021-08-28 16:25 ` bug#46374: Regression: erronous calls to PRED switch major-mode of unrelated modified buffers Hauke Rehfeld
2021-08-29 16:38 ` Juri Linkov
2021-08-30 7:28 ` Juri Linkov
2021-08-30 11:43 ` Hauke Rehfeld
2021-08-30 16:04 ` Hauke Rehfeld
2021-08-31 7:02 ` Juri Linkov
2021-09-05 10:09 ` bug#46374: 28.0.50; Ask me to save buffers only if they are under callers dir Tino Calancha
2021-09-05 16:21 ` Juri Linkov
2021-10-10 17:38 ` Juri Linkov
[not found] ` <jwv5yqwrgru.fsf-monnier+emacs@gnu.org>
2022-01-06 19:09 ` bug#46374: Regression: erronous calls to PRED switch major-mode of unrelated modified buffers Juri Linkov
2022-01-06 20:17 ` Eli Zaretskii
2022-01-06 20:28 ` Juri Linkov
2022-01-07 14:45 ` Eli Zaretskii
2022-01-10 3:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7jq1a0i.fsf@gmail.com \
--to=tino.calancha@gmail.com \
--cc=46374@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=monnier@iro.umontreal.ca \
--cc=uyennhi.qm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).