From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 46374@debbugs.gnu.org, hauke@haukerehfeld.de,
monnier@iro.umontreal.ca, tino.calancha@gmail.com
Subject: bug#46374: Regression: erronous calls to PRED switch major-mode of unrelated modified buffers
Date: Thu, 06 Jan 2022 22:28:02 +0200 [thread overview]
Message-ID: <86wnjczk19.fsf@mail.linkov.net> (raw)
In-Reply-To: <83h7ag7h6l.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 06 Jan 2022 22:17:06 +0200")
>> Then this change needs to be in the release branch, so users won't start
>> relying on the unintended case of using of the `save-some-buffers-function`
>> property on the `pred` argument.
>
> I don't see the message to which you are responding, so I cannot tell
> whether the patch you have in mind is appropriate for the release
> branch.
Oh, it was archived, so here is a copy:
> It's actually easy to distinguish this specific case: when the pred is
> passed directly to `save-some-buffers` we don't need to do the "call
> PRED to get the actual predicate" dance, since the caller could just as
> well do that dance before calling us if that's what they want.
>
> IOW, the test for `save-some-buffers-function` is only needed for those
> functions that come from `save-some-buffers-default-predicate`.
>
> Any objection to the patch below (which also aligns the code closer
> with the doc since the doc of `save-some-buffers` doesn't mention the
> use of the `save-some-buffers-function` property on its `pred`
> argument).
>
>
> Stefan
>
>
> diff --git a/lisp/files.el b/lisp/files.el
> index a11786fca2c..cd43b94622e 100644
> --- a/lisp/files.el
> +++ b/lisp/files.el
> @@ -5799,7 +5799,7 @@ save-some-buffers-default-predicate
> ;; FIXME nil should not be a valid option, let alone the default,
> ;; eg so that add-function can be used.
> :type '(choice (const :tag "Default" nil)
> - (function :tag "Only in subdirs of root"
> + (function :tag "Only in subdirs of current project"
> save-some-buffers-root)
> (function :tag "Custom function"))
> :version "26.1")
> @@ -5835,21 +5835,22 @@ save-some-buffers
> Optional second argument PRED determines which buffers are considered:
> If PRED is nil, all the file-visiting buffers are considered.
> If PRED is t, then certain non-file buffers will also be considered.
> -If PRED is a zero-argument function, it indicates for each buffer whether
> -to consider it or not when called with that buffer current.
> +If PRED is a function, it is called with no argument in each buffer and
> +should return non-nil if that buffer should be considered.
> PRED defaults to the value of `save-some-buffers-default-predicate'.
>
> See `save-some-buffers-action-alist' if you want to
> change the additional actions you can take on files."
> (interactive "P")
> (unless pred
> - (setq pred save-some-buffers-default-predicate))
> - ;; Allow `pred' to be a function that returns a predicate
> - ;; with lexical bindings in its original environment (bug#46374).
> - (when (and (symbolp pred) (get pred 'save-some-buffers-function))
> - (let ((pred-fun (and (functionp pred) (funcall pred))))
> - (when (functionp pred-fun)
> - (setq pred pred-fun))))
> + (setq pred
> + ;; Allow `pred' to be a function that returns a predicate
> + ;; with lexical bindings in its original environment (bug#46374).
> + (if (and (symbolp save-some-buffers-default-predicate)
> + (get save-some-buffers-default-predicate
> + 'save-some-buffers-function))
> + (funcall save-some-buffers-default-predicate)
> + save-some-buffers-default-predicate)))
> (let* ((switched-buffer nil)
> (save-some-buffers--switch-window-callback
> (lambda (buffer)
next prev parent reply other threads:[~2022-01-06 20:28 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-07 22:32 bug#46374: 28.0.50; Ask me to save buffers only if they are under callers dir Tino Calancha
2021-02-08 15:07 ` Eli Zaretskii
2021-02-08 15:47 ` Stefan Monnier
2021-02-09 17:50 ` Juri Linkov
2021-03-07 20:34 ` Tino Calancha
2021-03-07 21:08 ` Juri Linkov
[not found] ` <1952f2d9-51b6-a4ba-6c9e-98594222f017@gmail.com>
2021-03-08 17:28 ` Juri Linkov
2021-03-14 12:17 ` Tino Calancha
2021-03-15 17:10 ` Juri Linkov
2021-03-16 17:49 ` Juri Linkov
2021-03-16 22:54 ` Stefan Monnier
2021-03-16 23:37 ` bug#46374: [External] : " Drew Adams
2021-03-17 17:12 ` Juri Linkov
2021-03-17 17:10 ` Juri Linkov
2021-03-21 17:59 ` Tino Calancha
2021-03-21 20:10 ` Juri Linkov
2021-04-18 14:27 ` Tino Calancha
2021-04-24 22:13 ` Juri Linkov
2021-04-28 19:31 ` Tino Calancha
2021-04-28 19:51 ` Juri Linkov
2021-04-28 20:35 ` Tino Calancha
2021-04-29 9:17 ` Eli Zaretskii
2021-05-18 17:46 ` Tino Calancha
2021-04-29 16:04 ` Juri Linkov
[not found] ` <82abe5b9-7d42-b05d-26a5-fd63e1f59e3a@gmail.com>
2021-08-13 7:11 ` Juri Linkov
[not found] ` <3c7dc42a-e484-8068-d28d-49677f0b4a7@gmail.com>
2021-08-13 16:08 ` Juri Linkov
2021-04-29 9:16 ` Eli Zaretskii
2021-05-18 18:04 ` Tino Calancha
2021-05-18 18:23 ` Eli Zaretskii
2021-05-18 18:47 ` Tino Calancha
2021-08-28 16:25 ` bug#46374: Regression: erronous calls to PRED switch major-mode of unrelated modified buffers Hauke Rehfeld
2021-08-29 16:38 ` Juri Linkov
2021-08-30 7:28 ` Juri Linkov
2021-08-30 11:43 ` Hauke Rehfeld
2021-08-30 16:04 ` Hauke Rehfeld
2021-08-31 7:02 ` Juri Linkov
2021-09-05 10:09 ` bug#46374: 28.0.50; Ask me to save buffers only if they are under callers dir Tino Calancha
2021-09-05 16:21 ` Juri Linkov
2021-10-10 17:38 ` Juri Linkov
[not found] ` <jwv5yqwrgru.fsf-monnier+emacs@gnu.org>
2022-01-06 19:09 ` bug#46374: Regression: erronous calls to PRED switch major-mode of unrelated modified buffers Juri Linkov
2022-01-06 20:17 ` Eli Zaretskii
2022-01-06 20:28 ` Juri Linkov [this message]
2022-01-07 14:45 ` Eli Zaretskii
2022-01-10 3:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86wnjczk19.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=46374@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=hauke@haukerehfeld.de \
--cc=monnier@iro.umontreal.ca \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).