bug#50832: [PATCH] 28.0.50; Wrong mode in test-cl-flet-indentation

bug#50832: [PATCH] 28.0.50; Wrong mode in test-cl-flet-indentation

[akater]

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

This indentation does not work in lisp-mode, and it shouldn't.

In fact, lisp-mode-tests.el is a very confusing file name, and some
tests in it use emacs-lisp-mode while some use lisp-mode.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Fix cl-flet indentation test --]
[-- Type: text/x-diff, Size: 903 bytes --]

From e4821f07cce362d4be4f16ca9aec84822694464a Mon Sep 17 00:00:00 2001
From: akater <nuclearspace@gmail.com>
Date: Sun, 26 Sep 2021 22:29:56 +0000
Subject: [PATCH] ; Fix cl-flet indentation test

---
 test/lisp/emacs-lisp/lisp-mode-tests.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/lisp/emacs-lisp/lisp-mode-tests.el b/test/lisp/emacs-lisp/lisp-mode-tests.el
index 5e533b370e..64e1581d1e 100644
--- a/test/lisp/emacs-lisp/lisp-mode-tests.el
+++ b/test/lisp/emacs-lisp/lisp-mode-tests.el
@@ -333,7 +333,7 @@ defconst lisp-mode-tests--correctly-indented-sexp "\
 (ert-deftest test-cl-flet-indentation ()
   (should (equal
            (with-temp-buffer
-             (lisp-mode)
+             (emacs-lisp-mode)
              (insert "(cl-flet ((bla (x)\n(* x x)))\n(bla 42))")
              (indent-region (point-min) (point-max))
              (buffer-string))
-- 
2.32.0

bug#50832: [PATCH] 28.0.50; Wrong mode in test-cl-flet-indentation

[Lars Ingebrigtsen]

akater <nuclearspace@gmail.com> writes:

> This indentation does not work in lisp-mode, and it shouldn't.
>
> In fact, lisp-mode-tests.el is a very confusing file name, and some
> tests in it use emacs-lisp-mode while some use lisp-mode.

Indeed.  I've now fixed the test and moved it to the right file.

(That emacs-lisp-mode lives in progmodes/elisp-mode.el and that
lisp-mode lives in emacs-lisp/lisp-mode.el doesn't help with the
confusion.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no