* bug#4562: 23.1; Customize State button problems
@ 2009-09-26 18:37 Drew Adams
2009-09-28 5:41 ` Stefan Monnier
0 siblings, 1 reply; 6+ messages in thread
From: Drew Adams @ 2009-09-26 18:37 UTC (permalink / raw)
To: bug-gnu-emacs
emacs -Q
1. M-x customize-option default-frame-alist
The State text says "CHANGED outside Customize; operating on it here
may be unreliable.", which is untrue. This is immediately after using
`emacs -Q'.
2. Not only that, but the State menu shows `Undo Edits', even though
nothing has ever been edited.
3. If you in fact choose `Undo Edits', nothing happens, and `Undo
Edits' remains active in the State menu.
4. If you edit, e.g. click a DEL button, and then Set for Current
Session, and then you click `Reset to Backup', then the message says
"CHANGED outside Customize; operating on it here may be unreliable."
Again, this is incorrect - nothing was changed outside Customize.
In general, the State menu and its messages are pretty messed up. It
is quite confusing and error prone. Customize is supposed to be,
among other things, intended for non-Lisper novice users. It's no
wonder that so many hate it or give up in disbelief or
incomprehension.
In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600)
of 2009-07-29 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4)'
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#4562: 23.1; Customize State button problems
2009-09-26 18:37 bug#4562: 23.1; Customize State button problems Drew Adams
@ 2009-09-28 5:41 ` Stefan Monnier
2009-09-28 8:54 ` Drew Adams
2011-07-13 13:57 ` Lars Magne Ingebrigtsen
0 siblings, 2 replies; 6+ messages in thread
From: Stefan Monnier @ 2009-09-28 5:41 UTC (permalink / raw)
To: Drew Adams; +Cc: 4562
> The State text says "CHANGED outside Customize; operating on it here
> may be unreliable.", which is untrue. This is immediately after using
> `emacs -Q'.
You misunderstand: "CHANGED outside Customize" doesn't mean "You changed
it", but instead it means "some Lisp code somewhere changed it without
telling Customize". That Lisp code could be in your .emacs, but
not necesarily. I hope this makes the rest of the behavior a bit more
understable (tho probably not completely clear since it seems some part
are indeed odd).
So what you have here is simply a bug where Emacs's startup code
modifies default-frame-alist without telling Customize about it.
IIUC it's not easy to fix it, because some of those changes are things
which shoujldn't be saved in the Custom version of default-frame-alist
(they are dynamically set at startup depending on your window-system
and/or command-line args). I guess basically what it means is that
default-frame-alist shouldn't be a defcustom becaude we don't know how
to let Custom handle it correctly.
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#4562: 23.1; Customize State button problems
2009-09-28 5:41 ` Stefan Monnier
@ 2009-09-28 8:54 ` Drew Adams
2011-07-13 13:57 ` Lars Magne Ingebrigtsen
1 sibling, 0 replies; 6+ messages in thread
From: Drew Adams @ 2009-09-28 8:54 UTC (permalink / raw)
To: 'Stefan Monnier'; +Cc: 4562
> > The State text says "CHANGED outside Customize; operating on it here
> > may be unreliable.", which is untrue. This is immediately
> > after using `emacs -Q'.
>
> You misunderstand: "CHANGED outside Customize" doesn't mean
> "You changed it", but instead it means "some Lisp code somewhere
> changed it without telling Customize".
I do understand that.
Perhaps I shouldn't have said "which is untrue". The point is that the message
is not helpful to users. It shouldn't be the case that a virgin session, without
loading anything else, starts out by saying that something changed the Customize
initial settings, that is, what Customize expects its virgin state to be isn't.
Unless you're saying that it is normal for the initial Customize state to be
that. In which case I don't know whether I would agree, but I would in any case
say it's not normal to state things in those terms to users at the outset.
> That Lisp code could be in your .emacs, but
> not necesarily. I hope this makes the rest of the behavior a bit more
> understable (tho probably not completely clear since it seems
> some part are indeed odd).
>
> So what you have here is simply a bug where Emacs's startup code
> modifies default-frame-alist without telling Customize about it.
That's what I'm talking about (though I don't know the details).
> IIUC it's not easy to fix it, because some of those changes are things
> which shoujldn't be saved in the Custom version of default-frame-alist
> (they are dynamically set at startup depending on your window-system
> and/or command-line args). I guess basically what it means is that
> default-frame-alist shouldn't be a defcustom becaude we don't know how
> to let Custom handle it correctly.
I won't pronounce on any of that.
I will say that seeing that message at the outset is not a good thing. What the
right remedy is, I can't say. Maybe it _is_ normal to start out the way we do
(dunno), but in that case, we should at least suppress (fudge) the scary
message.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#4562: 23.1; Customize State button problems
2009-09-28 5:41 ` Stefan Monnier
2009-09-28 8:54 ` Drew Adams
@ 2011-07-13 13:57 ` Lars Magne Ingebrigtsen
2011-07-13 15:25 ` Drew Adams
2011-07-13 15:59 ` Chong Yidong
1 sibling, 2 replies; 6+ messages in thread
From: Lars Magne Ingebrigtsen @ 2011-07-13 13:57 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 4562
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> So what you have here is simply a bug where Emacs's startup code
> modifies default-frame-alist without telling Customize about it.
> IIUC it's not easy to fix it, because some of those changes are things
> which shoujldn't be saved in the Custom version of default-frame-alist
> (they are dynamically set at startup depending on your window-system
> and/or command-line args). I guess basically what it means is that
> default-frame-alist shouldn't be a defcustom becaude we don't know how
> to let Custom handle it correctly.
So should we just change `default-frame-alist' to a `defvar'?
I can't even find the custom definition of this variable.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#4562: 23.1; Customize State button problems
2011-07-13 13:57 ` Lars Magne Ingebrigtsen
@ 2011-07-13 15:25 ` Drew Adams
2011-07-13 15:59 ` Chong Yidong
1 sibling, 0 replies; 6+ messages in thread
From: Drew Adams @ 2011-07-13 15:25 UTC (permalink / raw)
To: 'Lars Magne Ingebrigtsen', 'Stefan Monnier'; +Cc: 4562
> So should we just change `default-frame-alist' to a `defvar'?
Certainly not. This is an important user option.
Likewise all the other `*-frame-alist' options.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#4562: 23.1; Customize State button problems
2011-07-13 13:57 ` Lars Magne Ingebrigtsen
2011-07-13 15:25 ` Drew Adams
@ 2011-07-13 15:59 ` Chong Yidong
1 sibling, 0 replies; 6+ messages in thread
From: Chong Yidong @ 2011-07-13 15:59 UTC (permalink / raw)
To: Lars Magne Ingebrigtsen; +Cc: 4562
Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
> So should we just change `default-frame-alist' to a `defvar'?
>
> I can't even find the custom definition of this variable.
The custom definition is in cus-start.el; that's where we put custom
definitions for built-in variables.
But the original bug no longer exists:
> 1. M-x customize-option default-frame-alist
>
> The State text says "CHANGED outside Customize; operating on it here
> may be unreliable.", which is untrue. This is immediately after using
> `emacs -Q'.
Several moons ago, I changed the frame code so that default-frame-alist
interacts properly with customize. In particular, the default value is
now nil. So this is a zombie bug; I'm closing it.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-07-13 15:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-09-26 18:37 bug#4562: 23.1; Customize State button problems Drew Adams
2009-09-28 5:41 ` Stefan Monnier
2009-09-28 8:54 ` Drew Adams
2011-07-13 13:57 ` Lars Magne Ingebrigtsen
2011-07-13 15:25 ` Drew Adams
2011-07-13 15:59 ` Chong Yidong
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).