bug#46257: 28.0.50; use flat-button in modus-operandi theme

bug#46257: 28.0.50; use flat-button in modus-operandi theme

[Pedro Andres Aranda Gutierrez]

[-- Attachment #1.1: Type: text/plain, Size: 281 bytes --]

This diff provides an example for the use of the :style flat-button in the
tab-line
of the modus-operandi theme. I've kept the original code commented.

Best, /Pedro A. Aranda


-- 
Fragen sind nicht da um beantwortet zu werden,
Fragen sind da um gestellt zu werden
Georg Kreisler

[-- Attachment #1.2: Type: text/html, Size: 513 bytes --]

[-- Attachment #2: flat-button-example.diff --]
[-- Type: text/x-patch, Size: 1535 bytes --]

diff --git a/etc/themes/modus-operandi-theme.el b/etc/themes/modus-operandi-theme.el
index c7a0f72c10..0455e6b639 100644
--- a/etc/themes/modus-operandi-theme.el
+++ b/etc/themes/modus-operandi-theme.el
@@ -4545,10 +4545,15 @@ modus-operandi-theme-scale
      `(tab-line ((,class :height 0.95 :background ,bg-tab-bar :foreground ,fg-main)))
      `(tab-line-close-highlight ((,class :foreground ,red)))
      `(tab-line-highlight ((,class :background ,blue-subtle-bg :foreground ,fg-dim)))
-     `(tab-line-tab ((,class :inherit bold :box (:line-width 2 :color ,bg-tab-active)
+     ;; Use flat-button style (don't need to repeat bg colour)
+     ;; `(tab-line-tab ((,class :inherit bold :box (:line-width 2 :color ,bg-tab-active)
+     ;;                         :background ,bg-tab-active :foreground ,fg-main)))
+     `(tab-line-tab ((,class :inherit bold :box (:line-width 2 :style flat-button)
                              :background ,bg-tab-active :foreground ,fg-main)))
      `(tab-line-tab-current ((,class :inherit tab-line-tab)))
-     `(tab-line-tab-inactive ((,class :box (:line-width 2 :color ,bg-tab-inactive)
+     ;; `(tab-line-tab-inactive ((,class :box (:line-width 2 :color ,bg-tab-inactive)
+     ;;                                  :background ,bg-tab-inactive :foreground ,fg-dim)))))
+     `(tab-line-tab-inactive ((,class :box (:line-width 2 :style flat-button)
                                       :background ,bg-tab-inactive :foreground ,fg-dim)))))
 ;;;; Emacs 28+
   (when (>= emacs-major-version 28)

bug#46257: 28.0.50; use flat-button in modus-operandi theme

[Basil L. Contovounesios]

Pedro Andres Aranda Gutierrez <paaguti@gmail.com> writes:

> This diff provides an example for the use of the :style flat-button in the tab-line
> of the modus-operandi theme. I've kept the original code commented.

Thanks, CCing Protesilao.

-- 
Basil

bug#46257: 28.0.50; use flat-button in modus-operandi theme

[Protesilaos Stavrou]

On 2021-02-02, 13:24 +0000, "Basil L. Contovounesios" <contovob@tcd.ie> wrote:

> Pedro Andres Aranda Gutierrez <paaguti@gmail.com> writes:
>
>> This diff provides an example for the use of the :style flat-button in the tab-line
>> of the modus-operandi theme. I've kept the original code commented.
>
> Thanks, CCing Protesilao.

Thanks Basil!

Hello Pedro!

That change looks good to me.  Please apply it wherever it would be
appropriate.  And please do the same for the modus-vivendi theme.

Now a question that is not pertinent to Emacs 28: does this flat-button
degrade gracefully on older versions, say, 27?  The reason I am asking
is because I will need to mirror any patch on my upstream repo; and I
know that there are users who run the themes on older versions of Emacs.

All the best,
Protesilaos or "Prot"

P.S. The version of the themes in Emacs is 0.13.0 while I currently have
them at 1.1.1.  This is due to change at some point, per bug#45068:
<https://debbugs.gnu.org/cgi/bugreport.cgi?bug=45068>.

-- 
Protesilaos Stavrou
protesilaos.com

bug#46257: 28.0.50; use flat-button in modus-operandi theme

[Pedro Andres Aranda Gutierrez]

[-- Attachment #1: Type: text/plain, Size: 1370 bytes --]

Hi Protesilaos,

the flat-button style is part of emacs28

Best, /PA

On Tue, 2 Feb 2021 at 19:46, Protesilaos Stavrou <info@protesilaos.com>
wrote:

> On 2021-02-02, 13:24 +0000, "Basil L. Contovounesios" <contovob@tcd.ie>
> wrote:
>
> > Pedro Andres Aranda Gutierrez <paaguti@gmail.com> writes:
> >
> >> This diff provides an example for the use of the :style flat-button in
> the tab-line
> >> of the modus-operandi theme. I've kept the original code commented.
> >
> > Thanks, CCing Protesilao.
>
> Thanks Basil!
>
> Hello Pedro!
>
> That change looks good to me.  Please apply it wherever it would be
> appropriate.  And please do the same for the modus-vivendi theme.
>
> Now a question that is not pertinent to Emacs 28: does this flat-button
> degrade gracefully on older versions, say, 27?  The reason I am asking
> is because I will need to mirror any patch on my upstream repo; and I
> know that there are users who run the themes on older versions of Emacs.
>
> All the best,
> Protesilaos or "Prot"
>
> P.S. The version of the themes in Emacs is 0.13.0 while I currently have
> them at 1.1.1.  This is due to change at some point, per bug#45068:
> <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=45068>.
>
> --
> Protesilaos Stavrou
> protesilaos.com
>


-- 
Fragen sind nicht da um beantwortet zu werden,
Fragen sind da um gestellt zu werden
Georg Kreisler

[-- Attachment #2: Type: text/html, Size: 2306 bytes --]

bug#46257: 28.0.50; use flat-button in modus-operandi theme

[Juri Linkov]

> This diff provides an example for the use of the :style flat-button in the
> tab-line

BTW, there are two possible contrasted styles for tab-line:

1. the active tab is lighter than inactive tabs;
2. the active tab is darker than inactive tabs.

For example, some desktop environments use the second style,
but currently Emacs tabs by default use the first style.

I'm not sure which one is better.

bug#46257: 28.0.50; use flat-button in modus-operandi theme

[Lars Ingebrigtsen]

Protesilaos Stavrou <info@protesilaos.com> writes:

> That change looks good to me.  Please apply it wherever it would be
> appropriate.  And please do the same for the modus-vivendi theme.
>
> Now a question that is not pertinent to Emacs 28: does this flat-button
> degrade gracefully on older versions, say, 27?  The reason I am asking
> is because I will need to mirror any patch on my upstream repo; and I
> know that there are users who run the themes on older versions of Emacs.

It won't degrade gracefully, so will applying the patch to Emacs 28
create problems for you?  If so, applying it doesn't seem all that
vital, since the visual result is the same (I think?), and it's just a
simplification (in Emacs 28).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#46257: 28.0.50; use flat-button in modus-operandi theme

[Protesilaos Stavrou]

On 2021-02-04, 09:40 +0100, Lars Ingebrigtsen <larsi@gnus.org> wrote:

> Protesilaos Stavrou <info@protesilaos.com> writes:
>
>> That change looks good to me.  Please apply it wherever it would be
>> appropriate.  And please do the same for the modus-vivendi theme.
>>
>> Now a question that is not pertinent to Emacs 28: does this flat-button
>> degrade gracefully on older versions, say, 27?  The reason I am asking
>> is because I will need to mirror any patch on my upstream repo; and I
>> know that there are users who run the themes on older versions of Emacs.
>
> It won't degrade gracefully, so will applying the patch to Emacs 28
> create problems for you?  If so, applying it doesn't seem all that
> vital, since the visual result is the same (I think?), and it's just a
> simplification (in Emacs 28).

In that case I would prefer not to introduce the patch, even though I
understand it would otherwise align the themes with the latest state of
emacs.git.

That granted, the pattern of hiding the :box border by colourising it
the same as the background is uncommon.  So if you still wish to apply
the flat-button, I will just maintain separate patches for whenever I
submit a new version of the themes to emacs.git.

-- 
Protesilaos Stavrou
protesilaos.com

bug#46257: 28.0.50; use flat-button in modus-operandi theme

[Lars Ingebrigtsen]

Protesilaos Stavrou <info@protesilaos.com> writes:

> In that case I would prefer not to introduce the patch, even though I
> understand it would otherwise align the themes with the latest state of
> emacs.git.
>
> That granted, the pattern of hiding the :box border by colourising it
> the same as the background is uncommon.  So if you still wish to apply
> the flat-button, I will just maintain separate patches for whenever I
> submit a new version of the themes to emacs.git.

I think that sounds like too much work -- it's best for if these
packages/themes that are meant to work over a range of Emacs versions if
they avoid using cutting-edge features, I think.

So I'm closing this bug report, and not applying the patch.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#46257: 28.0.50; use flat-button in modus-operandi theme

[Basil L. Contovounesios]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Protesilaos Stavrou <info@protesilaos.com> writes:
>
>> In that case I would prefer not to introduce the patch, even though I
>> understand it would otherwise align the themes with the latest state of
>> emacs.git.
>>
>> That granted, the pattern of hiding the :box border by colourising it
>> the same as the background is uncommon.  So if you still wish to apply
>> the flat-button, I will just maintain separate patches for whenever I
>> submit a new version of the themes to emacs.git.
>
> I think that sounds like too much work -- it's best for if these
> packages/themes that are meant to work over a range of Emacs versions if
> they avoid using cutting-edge features, I think.

Alternatively, when Elisp wants to work over a range of Emacs versions,
it can test for present features or the current Emacs version, and
expand to the appropriate form, as is done for the :extend keyword, for
example.

-- 
Basil