From: Protesilaos Stavrou <info@protesilaos.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: "Basil L. Contovounesios" <contovob@tcd.ie>,
Protesilaos Stavrou <info@protesilaos.com>,
46257@debbugs.gnu.org,
Pedro Andres Aranda Gutierrez <paaguti@gmail.com>
Subject: bug#46257: 28.0.50; use flat-button in modus-operandi theme
Date: Thu, 04 Feb 2021 14:09:56 +0200 [thread overview]
Message-ID: <87ft2cniej.fsf@protesilaos.com> (raw)
In-Reply-To: <87v9b8fcph.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 04 Feb 2021 09:40:10 +0100")
On 2021-02-04, 09:40 +0100, Lars Ingebrigtsen <larsi@gnus.org> wrote:
> Protesilaos Stavrou <info@protesilaos.com> writes:
>
>> That change looks good to me. Please apply it wherever it would be
>> appropriate. And please do the same for the modus-vivendi theme.
>>
>> Now a question that is not pertinent to Emacs 28: does this flat-button
>> degrade gracefully on older versions, say, 27? The reason I am asking
>> is because I will need to mirror any patch on my upstream repo; and I
>> know that there are users who run the themes on older versions of Emacs.
>
> It won't degrade gracefully, so will applying the patch to Emacs 28
> create problems for you? If so, applying it doesn't seem all that
> vital, since the visual result is the same (I think?), and it's just a
> simplification (in Emacs 28).
In that case I would prefer not to introduce the patch, even though I
understand it would otherwise align the themes with the latest state of
emacs.git.
That granted, the pattern of hiding the :box border by colourising it
the same as the background is uncommon. So if you still wish to apply
the flat-button, I will just maintain separate patches for whenever I
submit a new version of the themes to emacs.git.
--
Protesilaos Stavrou
protesilaos.com
next prev parent reply other threads:[~2021-02-04 12:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 11:34 bug#46257: 28.0.50; use flat-button in modus-operandi theme Pedro Andres Aranda Gutierrez
2021-02-02 13:24 ` Basil L. Contovounesios
2021-02-02 18:46 ` Protesilaos Stavrou
2021-02-02 19:21 ` Pedro Andres Aranda Gutierrez
2021-02-04 8:40 ` Lars Ingebrigtsen
2021-02-04 12:09 ` Protesilaos Stavrou [this message]
2021-02-04 16:16 ` Lars Ingebrigtsen
2021-02-06 10:33 ` Basil L. Contovounesios
2021-02-03 17:22 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ft2cniej.fsf@protesilaos.com \
--to=info@protesilaos.com \
--cc=46257@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=larsi@gnus.org \
--cc=paaguti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).