From: Lars Ingebrigtsen <larsi@gnus.org>
To: Noam Postavsky <npostavs@gmail.com>
Cc: Sebastian Urban <mrsebastianurban@gmail.com>, 35481@debbugs.gnu.org
Subject: bug#35481: 25.2; table.el should use 'font-lock-face' instead of 'face'
Date: Thu, 05 Dec 2019 10:55:21 +0100 [thread overview]
Message-ID: <87muc7rt9y.fsf@gnus.org> (raw)
In-Reply-To: <87tv6nd1jz.fsf@gmail.com> (Noam Postavsky's message of "Thu, 28 Nov 2019 18:27:28 -0500")
Noam Postavsky <npostavs@gmail.com> writes:
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> The patch below does this, but I'm not sure it's right. When we're
>> using font-lock-face instead of face, then things work as normal when
>> we're using global-font-lock-mode, but if that's off, then we won't get
>> any faces at all.
>>
>> Which would be bad.
>
> I missed this the first time around, but, why would that be bad? If the
> user turns off font-lock-mode then not getting faces should be expected,
> no?
Font locking is about adding decorative highlights. The background face
table.el adds is functional -- it says what cell is selected.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2019-12-05 9:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-28 21:31 bug#35481: 25.2; table.el should use 'font-lock-face' instead of 'face' Sebastian Urban
2019-04-28 22:04 ` Noam Postavsky
2019-05-13 7:16 ` Sebastian Urban
2019-08-04 12:09 ` Sebastian Urban
2019-10-30 19:44 ` Lars Ingebrigtsen
2019-11-17 9:07 ` Lars Ingebrigtsen
2019-11-28 23:27 ` Noam Postavsky
2019-12-05 9:55 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muc7rt9y.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=35481@debbugs.gnu.org \
--cc=mrsebastianurban@gmail.com \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).