From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#35481: 25.2; table.el should use 'font-lock-face' instead of 'face' Date: Thu, 05 Dec 2019 10:55:21 +0100 Message-ID: <87muc7rt9y.fsf@gnus.org> References: <89093c47-6449-8518-1d77-d43ba9b68891@gmail.com> <87d0eeow6p.fsf@gnus.org> <87tv6nd1jz.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="102513"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Sebastian Urban , 35481@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 05 10:56:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1icnrm-000QSa-TJ for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Dec 2019 10:56:11 +0100 Original-Received: from localhost ([::1]:52168 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icnrl-0003GU-Id for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Dec 2019 04:56:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34941) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icnrf-0003GM-2C for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 04:56:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1icnrd-0005wr-Tq for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 04:56:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37046) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1icnrd-0005vh-MX for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 04:56:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1icnrd-0000jg-K3 for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 04:56:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Dec 2019 09:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35481 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed fixed easy patch Original-Received: via spool by 35481-submit@debbugs.gnu.org id=B35481.15755397332735 (code B ref 35481); Thu, 05 Dec 2019 09:56:01 +0000 Original-Received: (at 35481) by debbugs.gnu.org; 5 Dec 2019 09:55:33 +0000 Original-Received: from localhost ([127.0.0.1]:43019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icnrA-0000i2-2r for submit@debbugs.gnu.org; Thu, 05 Dec 2019 04:55:33 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:45886) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icnr8-0000hj-EM for 35481@debbugs.gnu.org; Thu, 05 Dec 2019 04:55:30 -0500 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1icnqz-0004Im-Tp; Thu, 05 Dec 2019 10:55:24 +0100 In-Reply-To: <87tv6nd1jz.fsf@gmail.com> (Noam Postavsky's message of "Thu, 28 Nov 2019 18:27:28 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172881 Archived-At: Noam Postavsky writes: > Lars Ingebrigtsen writes: > >> The patch below does this, but I'm not sure it's right. When we're >> using font-lock-face instead of face, then things work as normal when >> we're using global-font-lock-mode, but if that's off, then we won't get >> any faces at all. >> >> Which would be bad. > > I missed this the first time around, but, why would that be bad? If the > user turns off font-lock-mode then not getting faces should be expected, > no? Font locking is about adding decorative highlights. The background face table.el adds is functional -- it says what cell is selected. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no