unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Sebastian Urban <mrsebastianurban@gmail.com>
To: 35481@debbugs.gnu.org
Subject: bug#35481: 25.2; table.el should use 'font-lock-face' instead of 'face'
Date: Sun, 28 Apr 2019 23:31:27 +0200	[thread overview]
Message-ID: <89093c47-6449-8518-1d77-d43ba9b68891@gmail.com> (raw)

This is follow up (part two of solution) to this bug#35044:
https://lists.gnu.org/archive/html/bug-gnu-emacs/2019-03/msg01011.html
and then (two months split)
https://lists.gnu.org/archive/html/bug-gnu-emacs/2019-04/msg00739.html
or at debbugs
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35044

In short "table.el" uses text property 'face' (table-cell) which causes
losing of cell highlight when user switches from modes like "Text" or
"Fundamental" to modes that use "Font lock", like "Outline".  Also when
user switches back, 'face' is not applied immediately in every cell, but
one by one, when cursor is moved from cell to cell.

For both problems a solution seems to be an update to "table.el", which
will change 'face' to 'font-lock-face'.

If it helps, I found 4 places in code that probably need to be changed:
- 'defface table-cell' at line 680,
- 'defun table--put-cell-face-property' at line 5172,
- 'defun table--remove-cell-properties' at line 5189,
- 'defun table--update-cell-face' at line 5209.

---

In GNU Emacs 25.2.1 (i686-w64-mingw32)
  of 2017-04-24 built on LAPHROAIG
Windowing system distributor 'Microsoft Corp.', version 6.1.7601
Configured using:
  'configure --host=i686-w64-mingw32 --without-dbus
  --without-compress-install 'CFLAGS=-static -O2 -g3''

Configured features:
XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY ACL GNUTLS LIBXML2 ZLIB
TOOLKIT_SCROLL_BARS

Important settings:
   value of $LANG: PLK
   locale-coding-system: cp1250

Major mode: Fundamental

Minor modes in effect:
   tooltip-mode: t
   global-eldoc-mode: t
   electric-indent-mode: t
   mouse-wheel-mode: t
   menu-bar-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   blink-cursor-mode: t
   auto-composition-mode: t
   auto-encryption-mode: t
   auto-compression-mode: t
   buffer-read-only: t
   line-number-mode: t
   transient-mark-mode: t

Recent messages:
Preparing diary...
No diary entries for Niedziela, 28 Kwiecień 2019
Preparing diary...done
For information about GNU Emacs and the GNU system, type C-h C-a.
next-line: End of buffer

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message dired format-spec rfc822 mml
mml-sec password-cache epg gnus-util mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util help-fns mail-prsvr mail-utils cal-china
lunar solar cal-dst cal-bahai cal-islam cal-hebrew holidays hol-loaddefs
diary-lib diary-loaddefs cal-menu calendar cal-loaddefs finder-inf
package epg-config seq byte-opt gv bytecomp byte-compile cl-extra
help-mode easymenu cconv cl-loaddefs pcase cl-lib time-date mule-util
tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel dos-w32 ls-lisp disp-table w32-win w32-vars term/common-win
tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment
elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan
thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian
slovak czech european ethiopic indian cyrillic chinese charscript
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote w32notify w32 multi-tty
make-network-process emacs)

Memory information:
((conses 8 114624 7479)
  (symbols 32 22205 0)
  (miscs 32 94 203)
  (strings 16 23812 4853)
  (string-bytes 1 741124)
  (vectors 8 15933)
  (vector-slots 4 485829 3692)
  (floats 8 712 215)
  (intervals 28 263 31)
  (buffers 520 21))





             reply	other threads:[~2019-04-28 21:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-28 21:31 Sebastian Urban [this message]
2019-04-28 22:04 ` bug#35481: 25.2; table.el should use 'font-lock-face' instead of 'face' Noam Postavsky
2019-05-13  7:16   ` Sebastian Urban
2019-08-04 12:09   ` Sebastian Urban
2019-10-30 19:44 ` Lars Ingebrigtsen
2019-11-17  9:07   ` Lars Ingebrigtsen
2019-11-28 23:27   ` Noam Postavsky
2019-12-05  9:55     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89093c47-6449-8518-1d77-d43ba9b68891@gmail.com \
    --to=mrsebastianurban@gmail.com \
    --cc=35481@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).