* bug#53491: 29.0.50; Fixing use of define-keymap in gnus-registry.el
@ 2022-01-24 4:21 Eric Abrahamsen
0 siblings, 0 replies; 3+ messages in thread
From: Eric Abrahamsen @ 2022-01-24 4:21 UTC (permalink / raw)
To: 53491
Commit 453db25 changes the Gnus registry's key bindings to use
`define-keymap'. The problem is that the old code *added* the registry
bindings to the "M" prefix in `gnus-summary-mode-map', while the new
code *overrides* everything that was defined on that "M" prefix, in
favor of the registry's keys. There used to be a lot of commands there.
The simple solution would be to not use `define-keymap' in the registry
code, and instead use `define-key' inside the loop at
gnus-registry.el:959, defining each command individually on a "M <key>"
binding.
Another possibility would be to explicitly name the sub-keymap that's
currently hung on the "M" prefix, at gnus-sum.el:2038. Then that could
be used as a :parent in the `define-keymap' call in gnus-registry.el.
Or is there a way to attach a `define-keymap' to an anonymous prefixed
keymap?
Eric
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#53491: 29.0.50; Fixing use of define-keymap in gnus-registry.el
2022-01-24 4:24 bug#53492: 29.0.50; Remove use of define-keymap in gnus-registry.el? Eric Abrahamsen
@ 2022-01-24 10:10 ` Lars Ingebrigtsen
2022-01-24 17:49 ` bug#53492: " Eric Abrahamsen
0 siblings, 1 reply; 3+ messages in thread
From: Lars Ingebrigtsen @ 2022-01-24 10:10 UTC (permalink / raw)
To: Eric Abrahamsen; +Cc: 53491, 53492
Eric Abrahamsen <eric@ericabrahamsen.net> writes:
> Commit 453db25 changes the Gnus registry's key bindings to use
> `define-keymap'. The problem is that the old code *added* the registry
> bindings to the "M" prefix in `gnus-summary-mode-map', while the new
> code *overrides* everything that was defined on that "M" prefix, in
> favor of the registry's keys. There used to be a lot of commands there.
Should be fixed now; please check.
> Or is there a way to attach a `define-keymap' to an anonymous prefixed
> keymap?
Don't think so...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#53491: 29.0.50; Fixing use of define-keymap in gnus-registry.el
2022-01-24 17:49 ` bug#53492: " Eric Abrahamsen
@ 2022-01-24 18:30 ` Lars Ingebrigtsen
0 siblings, 0 replies; 3+ messages in thread
From: Lars Ingebrigtsen @ 2022-01-24 18:30 UTC (permalink / raw)
To: Eric Abrahamsen; +Cc: 53491, 53492
Eric Abrahamsen <eric@ericabrahamsen.net> writes:
> Looks good! Thanks for the quick fix.
Thanks for checking; I'm closing this bug report, then.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-24 18:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-24 4:21 bug#53491: 29.0.50; Fixing use of define-keymap in gnus-registry.el Eric Abrahamsen
-- strict thread matches above, loose matches on Subject: below --
2022-01-24 4:24 bug#53492: 29.0.50; Remove use of define-keymap in gnus-registry.el? Eric Abrahamsen
2022-01-24 10:10 ` bug#53491: 29.0.50; Fixing use of define-keymap in gnus-registry.el Lars Ingebrigtsen
2022-01-24 17:49 ` bug#53492: " Eric Abrahamsen
2022-01-24 18:30 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).